matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

Fix slash command prefix to / #75

Merged
Gnome-py merged 1 commits from slash-prefix-fix into 2.0 2021-09-26 05:40:35 +00:00
Conversation 1 Commits 1 Files Changed 1 +34 -21
Gnome-py commented 2021-09-23 16:46:07 +00:00 (Migrated from github.com)
Copy Link

Summary

Previously slash commands would fetch the prefix and prepend this to the fake message content. This is stupid. I instead just made bot.get_prefix check if it is a _FakeSlashMessage then return "/" so the prefix is always / when using a slash command.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
<!-- Pull requests that do not fill this information in will likely be closed --> ## Summary <!-- What is this pull request for? Does it fix any issues? --> Previously slash commands would fetch the prefix and prepend this to the fake message content. This is stupid. I instead just made `bot.get_prefix` check if it is a `_FakeSlashMessage` then return `"/"` so the prefix is always `/` when using a slash command. ## Checklist <!-- Put an x inside [ ] to check it, like so: [x] --> - [x] If code changes were made then they have been tested. - [ ] I have updated the documentation to reflect the changes. - [ ] This PR fixes an issue. - [ ] This PR adds something new (e.g. new method or parameters). - [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed) - [ ] This PR is **not** a code change (e.g. documentation, README, ...)
IAmTomahawkx (Migrated from github.com) approved these changes 2021-09-26 05:39:47 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
IAmTomahawkx
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
matthew
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: matthew/enhanced-discord.py#75
No description provided.
Delete Branch "slash-prefix-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?