matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

Add better support for mentionable #74

Merged
Gnome-py merged 1 commits from mentionable into 2.0 2021-09-26 05:41:44 +00:00
Conversation 2 Commits 1 Files Changed 1 +15 -5
Gnome-py commented 2021-09-22 19:00:00 +00:00 (Migrated from github.com)
Copy Link

Summary

Previously, slash command's simply converted discord.Object into mentionable (type 9) but that wasn't entirely correct, as discord treats mentionable as Union[discord.Member, discord.Role], so, I did a small change to correct this.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
<!-- Pull requests that do not fill this information in will likely be closed --> ## Summary <!-- What is this pull request for? Does it fix any issues? --> Previously, slash command's simply converted `discord.Object` into mentionable (type 9) but that wasn't entirely correct, as discord treats mentionable as `Union[discord.Member, discord.Role]`, so, I did a small change to correct this. ## Checklist <!-- Put an x inside [ ] to check it, like so: [x] --> - [x] If code changes were made then they have been tested. - [ ] I have updated the documentation to reflect the changes. - [ ] This PR fixes an issue. - [ ] This PR adds something new (e.g. new method or parameters). - [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed) - [ ] This PR is **not** a code change (e.g. documentation, README, ...)
jay3332 commented 2021-09-22 22:23:38 +00:00 (Migrated from github.com)
Copy Link

comparing origin is Union is unnecessary

comparing ``origin is Union`` is unnecessary
IAmTomahawkx (Migrated from github.com) approved these changes 2021-09-26 05:41:26 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
IAmTomahawkx
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
matthew
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: matthew/enhanced-discord.py#74
No description provided.
Delete Branch "mentionable"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?