matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

added embed_background color #66

Open
Daishiky wants to merge 4 commits from Daishiky/master into master
pull from: Daishiky/master
merge into: matthew:master
Conversation 4 Commits 4 Files Changed 1 +19 -1
Daishiky commented 2021-09-19 16:56:01 +00:00 (Migrated from github.com)
Copy Link

Summary

This PR adds a new Colour embed_background which returns a cls() for the embed color
of each discord theme (dark & light), amoled is missing.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
<!-- Pull requests that do not fill this information in will likely be closed --> ## Summary <!-- What is this pull request for? Does it fix any issues? --> This PR adds a new Colour `embed_background` which returns a cls() for the embed color of each discord theme (dark & light), amoled is missing. ## Checklist <!-- Put an x inside [ ] to check it, like so: [x] --> - [x] If code changes were made then they have been tested. - [ ] I have updated the documentation to reflect the changes. - [ ] This PR fixes an issue. - [x] This PR adds something new (e.g. new method or parameters). - [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed) - [ ] This PR is **not** a code change (e.g. documentation, README, ...)
proguy914629bot (Migrated from github.com) reviewed 2021-09-19 23:44:48 +00:00
discord/colour.py
proguy914629bot (Migrated from github.com) commented 2021-09-19 23:44:44 +00:00
Copy Link

you switched, it.

    def embed_background(cls, theme: str = "dark"):

Also won't it be a little better with enums?

you switched, it. ```suggestion def embed_background(cls, theme: str = "dark"): ``` Also won't it be a little better with enums?
proguy914629bot (Migrated from github.com) reviewed 2021-09-20 07:46:01 +00:00
discord/colour.py
proguy914629bot (Migrated from github.com) commented 2021-09-19 23:49:13 +00:00
Copy Link
            raise TypeError("Theme must be one of \"dark\" or \"light\".")
```suggestion raise TypeError("Theme must be one of \"dark\" or \"light\".") ```
IAmTomahawkx commented 2021-09-21 18:56:50 +00:00 (Migrated from github.com)
Copy Link

I think these might fit better as two seperate classmethods, embed_dark and embed_light

I think these might fit better as two seperate classmethods, `embed_dark` and `embed_light`
👍 2
Gnome-py commented 2021-09-23 08:49:42 +00:00 (Migrated from github.com)
Copy Link

This should be targeting the 2.0 branch, master is 1.7

This should be targeting the 2.0 branch, `master` is 1.7
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin Daishiky/master:Daishiky/master
git checkout Daishiky/master
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
matthew
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: matthew/enhanced-discord.py#66
No description provided.
Delete Branch "Daishiky/master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?