matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

FIx _accent_colour being improperly typehinted #57

Merged
Astrea49 merged 1 commits from typehinting-fixes into 2.0 2021-09-21 18:37:28 +00:00
Conversation 1 Commits 1 Files Changed 1 +76 -86
Astrea49 commented 2021-09-05 17:48:50 +00:00 (Migrated from github.com)
Copy Link

Summary

_accent_colour in discord.User was typehinted as a Optional[str] when it's stated to be an Optional[int] (or, well ?integer) by the Discord API docs and is treated by the library as an Optional[int] when User.accent_colour is called. This PR is a quick change to fix that (and make Pylance happy).

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
## Summary `_accent_colour` in `discord.User` was typehinted as a `Optional[str]` when it's stated to be an `Optional[int]` (or, well `?integer`) by the [Discord API docs](https://discord.com/developers/docs/resources/user#user-object-user-structure) and is treated by the library as an `Optional[int]` when `User.accent_colour` is called. This PR is a quick change to fix that (and make Pylance happy). ## Checklist <!-- Put an x inside [ ] to check it, like so: [x] --> - [x] If code changes were made then they have been tested. - [ ] I have updated the documentation to reflect the changes. - [ ] This PR fixes an issue. - [ ] This PR adds something new (e.g. new method or parameters). - [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed) - [ ] This PR is **not** a code change (e.g. documentation, README, ...)
Gnome-py commented 2021-09-05 17:58:06 +00:00 (Migrated from github.com)
Copy Link

Looks good, checked at runtime and it is indeed int.

Looks good, checked at runtime and it is indeed `int`.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
matthew
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: matthew/enhanced-discord.py#57
No description provided.
Delete Branch "typehinting-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?