Add datetime converter and util #54

2021-09-04T20:39:28Z

Daggy1234 commented

2021-09-04 20:39:28 +00:00

(Migrated from github.com)

Summary

Checklist

If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed)
This PR is not a code change (e.g. documentation, README, ...)

## Summary ## Checklist  - [ ] If code changes were made then they have been tested. - [ ] I have updated the documentation to reflect the changes. - [ ] This PR fixes an issue. - [x] This PR adds something new (e.g. new method or parameters). - [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed) - [ ] This PR is **not** a code change (e.g. documentation, README, ...)

Astrea49 commented

2021-09-04 21:54:26 +00:00

(Migrated from github.com)

Is this really needed? I remember seeing Danny and some other people in d.py talk about this - they agreed that since they're no easy way for users themselves to the Discord timestamp markdown, that it really wasn't worth it, and I kinda have to agree. There's no UI to make the timestamp, meaning most users would have to hear about this markdown from some source and then actually learn how to use it, which I'm willing to bet most users won't be able to do both.

I think it's best to let bot developers decide if it's worth making a converter like this for the small amount of Discord users that know how to use said markdown.

Is this really needed? I remember seeing Danny and some other people in d.py talk about this - they agreed that since they're no easy way for users themselves to the Discord timestamp markdown, that it really wasn't worth it, and I kinda have to agree. There's no UI to make the timestamp, meaning most users would have to hear about this markdown from some source and then actually learn how to use it, which I'm willing to bet most users won't be able to do both. I think it's best to let bot developers decide if it's worth making a converter like this for the small amount of Discord users that know how to use said markdown.

IAmTomahawkx commented

2021-09-04 22:21:58 +00:00

(Migrated from github.com)

I'm with astrea/Danny/others on this one, I don't see this as useful in the library. If discord added some sort of UI to create timestamps I could see a use case here. As it stands, I don't see this being used

👍 1

Daggy1234 commented

2021-09-05 05:53:28 +00:00

(Migrated from github.com)

I'll reiterate that as NC has suggested there is an incuded util, I think thats important for a user to be able to extract a datetime from a timemstamp. I can remove the converter however. Also having a converter doesn't hurt, but I think yeah users can implement the converters with the util.

Astrea49 commented

2021-09-05 05:59:53 +00:00

(Migrated from github.com)

Yeah, I can agree that the util itself makes sense - I can think of some uses a bot maker might have for it. Just think a converter doesn't make much sense at this time - it doesn't hurt, but I think it's best not to add unnecessary features if possible.

Yeah, I can agree that the util itself makes sense - I can think of some uses a bot maker might have for it. Just think a converter doesn't make much sense at this time - it doesn't *hurt*, but I think it's best not to add unnecessary features if possible.

This pull request has changes conflicting with the target branch.

discord/ext/commands/errors.py
discord/utils.py

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin Daggy1234/patch-1:Daggy1234/patch-1

git checkout Daggy1234/patch-1

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: matthew/enhanced-discord.py#54