If code changes were made then they have been tested.
I have updated the documentation to reflect the changes.
This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed)
This PR is not a code change (e.g. documentation, README, ...)
## Summary
<!-- What is this pull request for? Does it fix any issues? -->
## Checklist
<!-- Put an x inside [ ] to check it, like so: [x] -->
- [ ] If code changes were made then they have been tested.
- [ ] I have updated the documentation to reflect the changes.
- [ ] This PR fixes an issue.
- [ ] This PR adds something new (e.g. new method or parameters).
- [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
- [ ] This PR is **not** a code change (e.g. documentation, README, ...)
Gnome-py
(Migrated from github.com)
reviewed 2021-08-29 00:04:14 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Summary
Checklist
@@ -244,0 +258,4 @@def embed_color(self):"""Optional[:class:`.Colour`]: The default embed colour that isbeing used for all embed if no colour is passed."""col = os.getenv("DEFAULT_EMBED_COLOR")No, never use env vars like this, instead store this under
discord.Embed.default_colour@@ -244,0 +280,4 @@"""if isinstance(color, (Color, Colour)):os.environ['DEFAULT_EMBED_COLOR'] = str(hex(color))return colorSame here, do not use env vars
@@ -244,0 +283,4 @@return colorelse:try:HEX = re.compile(r'^(#)[A-Fa-f0-9]{6}$')Why are you compiling this regex per invoke, store global.
Going to go with Gnome here, fix these and you should be good.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.