matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

Add try_member to guild. #14

Merged
paris-ci merged 2 commits from try_member into 2.0 2021-09-02 00:47:15 +00:00
Conversation 3 Commits 2 Files Changed 1
+31 -1
paris-ci commented 2021-08-28 22:21:14 +00:00 (Migrated from github.com)
Copy Link
Copy Source

This also fix an omission in the fetch_member docs. fetch_member raises NotFound if the given user isn't in the guild.

This also fix an omission in the fetch_member docs. `fetch_member` raises `NotFound` if the given user isn't in the guild.
IAmTomahawkx (Migrated from github.com) requested changes 2021-08-29 17:59:38 +00:00
discord/guild.py
IAmTomahawkx (Migrated from github.com) commented 2021-08-29 17:59:23 +00:00
Copy Link
Copy Source

Import NotFound directly to avoid importing the whole module?
Wouldn't this result in an import loop?

Import NotFound directly to avoid importing the whole module? Wouldn't this result in an import loop?
paris-ci (Migrated from github.com) reviewed 2021-08-29 19:45:35 +00:00
discord/guild.py
paris-ci (Migrated from github.com) commented 2021-08-29 19:45:35 +00:00
Copy Link
Copy Source

It works for me, doesn't result in an import loop at all, but I'll still optimize the import. It's just cosmetic.

It works for me, doesn't result in an import loop at all, but I'll still optimize the import. It's just cosmetic.
IAmTomahawkx (Migrated from github.com) approved these changes 2021-09-02 00:47:09 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
paris-ci
IAmTomahawkx
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
matthew (Matthew)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: matthew/enhanced-discord.py#14