matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

Make Embed.image and Embed.thumbnail full-featured properties #13

Merged
paris-ci merged 2 commits from rework_set_in_embeds into 2.0 2021-09-01 02:24:57 +00:00
Conversation 4 Commits 2 Files Changed 1
+53 -27
paris-ci commented 2021-08-28 21:18:27 +00:00 (Migrated from github.com)
Copy Link
Copy Source

This avoids the need for set_* methods.

Bikeshedding: https://discord.com/channels/514232441498763279/881248749849026590/881282858977738803

This avoids the need for set_* methods. Bikeshedding: https://discord.com/channels/514232441498763279/881248749849026590/881282858977738803
paris-ci commented 2021-08-28 21:19:00 +00:00 (Migrated from github.com)
Copy Link
Copy Source

This keeps the set_* methods as a compatibility layer, and further commits might deprecate and remove them entirely.

This keeps the set_* methods as a compatibility layer, and further commits might deprecate and remove them entirely.
TheMoksej (Migrated from github.com) reviewed 2021-08-28 21:27:31 +00:00
discord/embeds.py
TheMoksej (Migrated from github.com) commented 2021-08-28 21:27:22 +00:00
Copy Link
Copy Source

Shouldn't this be called set_thumbnail?

Shouldn't this be called `set_thumbnail`?
paris-ci (Migrated from github.com) reviewed 2021-08-28 21:29:29 +00:00
discord/embeds.py
paris-ci (Migrated from github.com) commented 2021-08-28 21:29:29 +00:00
Copy Link
Copy Source

Oh I'm dumb, thanks

Oh I'm dumb, thanks
WhoTheOOF commented 2021-08-28 22:16:13 +00:00 (Migrated from github.com)
Copy Link
Copy Source

This keeps the set_* methods as a compatibility layer, and further commits might deprecate and remove them entirely.

This is a very good idea, that way you don't have to really change too much code, yet you can use the new way if liked. Good job.

> This keeps the set_* methods as a compatibility layer, and further commits might deprecate and remove them entirely. This is a very good idea, that way you don't have to really change too much code, yet you can use the new way if liked. Good job.
Sign in to join this conversation.
Reviewers
No Reviewers
TheMoksej
paris-ci
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
matthew (Matthew)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: matthew/enhanced-discord.py#13