matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

Cleaned up some general python #12

Merged
chillymosh merged 8 commits from 2.0 into 2.0 2021-09-02 19:32:47 +00:00
Conversation 7 Commits 8 Files Changed 9
+74 -84
chillymosh commented 2021-08-28 20:50:46 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
## Summary <!-- What is this pull request for? Does it fix any issues? --> ## Checklist <!-- Put an x inside [ ] to check it, like so: [x] --> - [ ] If code changes were made then they have been tested. - [ ] I have updated the documentation to reflect the changes. - [ ] This PR fixes an issue. - [ ] This PR adds something new (e.g. new method or parameters). - [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed) - [ ] This PR is **not** a code change (e.g. documentation, README, ...)
paris-ci (Migrated from github.com) reviewed 2021-08-28 20:54:49 +00:00
discord/__main__.py
paris-ci (Migrated from github.com) commented 2021-08-28 20:51:59 +00:00
Copy Link
Copy Source

I preferred the old way since it was more consistent.

I preferred the old way since it was more consistent.
discord/ext/commands/bot.py
paris-ci (Migrated from github.com) commented 2021-08-28 20:52:55 +00:00
Copy Link
Copy Source

Same here, before was more readable IMO.

Same here, before was more readable IMO.
discord/ext/tasks/__init__.py
paris-ci (Migrated from github.com) commented 2021-08-28 20:54:19 +00:00
Copy Link
Copy Source

Could maybe place this in utils, since it's (almost) the same function as before

Could maybe place this in utils, since it's (almost) the same function as before
chillymosh (Migrated from github.com) reviewed 2021-08-28 20:58:26 +00:00
discord/ext/tasks/__init__.py
chillymosh (Migrated from github.com) commented 2021-08-28 20:58:25 +00:00
Copy Link
Copy Source

Reason I extracted into a method here was to prevent code duplication but yea it's nearly identical to the other raise in commands.bot

Reason I extracted into a method here was to prevent code duplication but yea it's nearly identical to the other raise in commands.bot
paris-ci (Migrated from github.com) reviewed 2021-08-28 21:15:39 +00:00
discord/ext/tasks/__init__.py
paris-ci (Migrated from github.com) commented 2021-08-28 21:15:39 +00:00
Copy Link
Copy Source

I was saying to extract that further in discord.utils

I was saying to extract that further in discord.utils
chillymosh (Migrated from github.com) reviewed 2021-08-28 22:14:50 +00:00
discord/__main__.py
chillymosh (Migrated from github.com) commented 2021-08-28 22:14:50 +00:00
Copy Link
Copy Source

reverted

reverted
chillymosh (Migrated from github.com) reviewed 2021-09-01 17:28:00 +00:00
discord/ext/commands/bot.py
chillymosh (Migrated from github.com) commented 2021-09-01 17:28:00 +00:00
Copy Link
Copy Source

reverted

reverted
chillymosh (Migrated from github.com) reviewed 2021-09-01 17:28:08 +00:00
discord/ext/tasks/__init__.py
chillymosh (Migrated from github.com) commented 2021-09-01 17:28:08 +00:00
Copy Link
Copy Source

done

done
IAmTomahawkx commented 2021-09-02 19:32:32 +00:00 (Migrated from github.com)
Copy Link
Copy Source

LGTM

LGTM
Sign in to join this conversation.
Reviewers
No Reviewers
paris-ci
chillymosh
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
matthew (Matthew)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: matthew/enhanced-discord.py#12