matthew/enhanced-discord.py
1
0
Fork 0
Code Issues 4 Pull Requests 21 Projects Releases Wiki Activity

Type-Hint some files that were not type-hinted #101

Open
Sengolda wants to merge 16 commits from unknown repository into 2.0
pull from: unknown repository
merge into: matthew:2.0
Conversation 2 Commits 16 Files Changed 6 +44 -33
Sengolda commented 2021-10-13 20:45:45 +00:00 (Migrated from github.com)
Copy Link

Summary

This pr type-hints Some files that were not typed (__main__.py, activity.py and utils.py)

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
## Summary This pr type-hints Some files that were not typed (`__main__.py`, `activity.py` and `utils.py`) ## Checklist - [x] If code changes were made then they have been tested. - [ ] I have updated the documentation to reflect the changes. - [ ] This PR fixes an issue. - [ ] This PR adds something new (e.g. new method or parameters). - [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed) - [ ] This PR is **not** a code change (e.g. documentation, README, ...)
StockerMC (Migrated from github.com) reviewed 2021-10-18 14:53:26 +00:00
discord/abc.py
StockerMC (Migrated from github.com) commented 2021-10-18 14:53:25 +00:00
Copy Link

The default for overwrite here should not have been removed.

The default for `overwrite` here should not have been removed.
Sengolda (Migrated from github.com) reviewed 2021-10-18 14:57:05 +00:00
discord/abc.py
Sengolda (Migrated from github.com) commented 2021-10-18 14:57:05 +00:00
Copy Link

Fixed.

Fixed.
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin unknown repository:unknown repository
git checkout unknown repository
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
matthew
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: matthew/enhanced-discord.py#101
No description provided.
Delete Branch "unknown repository"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?