mirrors/hdpv_ble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

no exceptions on BT errors, avoid api calls if position is correct

Browse Source
This commit is contained in:
patman15
2024-08-29 22:16:34 +02:00
parent 236c608dda
commit 2a800f1db3
1 changed files with 31 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
custom_components/hunterdouglas_powerview_ble/cover.py
View File

@@ -1,6 +1,8 @@
"""Hunter Douglas Powerview cover.""" """Hunter Douglas Powerview cover."""
from typing import Any from typing import Any, Final
from bleak.exc import BleakError
from homeassistant.components.bluetooth.passive_update_coordinator import ( from homeassistant.components.bluetooth.passive_update_coordinator import (
PassiveBluetoothCoordinatorEntity, PassiveBluetoothCoordinatorEntity,
@@ -54,7 +56,6 @@ class PowerViewCover(PassiveBluetoothCoordinatorEntity[PVCoordinator], CoverEnti
self._attr_name = CoverDeviceClass.SHADE self._attr_name = CoverDeviceClass.SHADE
self._coord = coordinator self._coord = coordinator
self._attr_device_info = self._coord.device_info self._attr_device_info = self._coord.device_info
self._target_position: int | None = None
self._attr_unique_id = ( self._attr_unique_id = (
f"{DOMAIN}_{format_mac(self._coord.address)}_{CoverDeviceClass.SHADE}" f"{DOMAIN}_{format_mac(self._coord.address)}_{CoverDeviceClass.SHADE}"
) )
@@ -83,7 +84,9 @@ class PowerViewCover(PassiveBluetoothCoordinatorEntity[PVCoordinator], CoverEnti
@property @property
def supported_features(self) -> CoverEntityFeature: # type: ignore[reportIncompatibleVariableOverride] def supported_features(self) -> CoverEntityFeature: # type: ignore[reportIncompatibleVariableOverride]
"""Flag supported features, disable control if encryption is needed.""" """Flag supported features, disable control if encryption is needed."""
if (self._coord.data.get("home_id") and len(HOME_KEY) != 16) or self._coord.data.get("battery_charging"): if (
self._coord.data.get("home_id") and len(HOME_KEY) != 16
) or self._coord.data.get("battery_charging"):
return CoverEntityFeature(0) return CoverEntityFeature(0)
return super().supported_features return super().supported_features
@@ -94,52 +97,49 @@ class PowerViewCover(PassiveBluetoothCoordinatorEntity[PVCoordinator], CoverEnti
None is unknown, 0 is closed, 100 is fully open. None is unknown, 0 is closed, 100 is fully open.
""" """
if ATTR_CURRENT_POSITION in self._coord.data:
pos = self._coord.data.get(ATTR_CURRENT_POSITION) pos = self._coord.data.get(ATTR_CURRENT_POSITION)
return int(pos) if pos is not None else None return round(pos) if pos is not None else None
return None
async def async_set_cover_position(self, **kwargs: Any) -> None: async def async_set_cover_position(self, **kwargs: Any) -> None:
"""Move the cover to a specific position.""" """Move the cover to a specific position."""
self._target_position = kwargs.get(ATTR_POSITION, None) target_position: Final[int | None] = kwargs.get(ATTR_POSITION)
if self._target_position is not None: if target_position is not None:
LOGGER.debug("set cover to position %i", self._target_position) LOGGER.debug("set cover to position %i", target_position)
if not self._coord.device_present: if self.current_cover_position == round(target_position) and not (
LOGGER.debug("device not present") self.is_closing or self.is_opening
):
return return
try: try:
await self._coord.api.set_position(self._target_position) await self._coord.api.set_position(round(target_position))
except Exception as err: except BleakError as err:
raise HomeAssistantError( LOGGER.error(
f"Failed to move cover '{self.name}' to {self._target_position}%: {err}" f"Failed to move cover '{self.name}' to {target_position}%: {err}"
) from err )
async def async_open_cover(self, **kwargs: Any) -> None: async def async_open_cover(self, **kwargs: Any) -> None:
"""Open the cover.""" """Open the cover."""
LOGGER.debug("open cover") LOGGER.debug("open cover")
if self.current_cover_position == OPEN_POSITION:
return
try: try:
await self._coord.api.set_position(OPEN_POSITION) await self._coord.api.open()
except Exception as err: except BleakError as err:
raise HomeAssistantError( LOGGER.error(f"Failed to open cover '{self.name}': {err}")
f"Failed open cover '{self.name}': {err}"
) from err
async def async_close_cover(self, **kwargs: Any) -> None: async def async_close_cover(self, **kwargs: Any) -> None:
"""Close the cover tilt.""" """Close the cover tilt."""
LOGGER.debug("close cover") LOGGER.debug("close cover")
if self.current_cover_position == CLOSED_POSITION:
return
try: try:
await self._coord.api.set_position(CLOSED_POSITION) await self._coord.api.close()
except Exception as err: except BleakError as err:
raise HomeAssistantError( LOGGER.error(f"Failed to close cover '{self.name}': {err}")
f"Failed close cover '{self.name}': {err}"
) from err
async def async_stop_cover(self, **kwargs: Any) -> None: async def async_stop_cover(self, **kwargs: Any) -> None:
"""Stop the cover.""" """Stop the cover."""
LOGGER.debug("stop cover") LOGGER.debug("stop cover")
try: try:
await self._coord.api.stop() await self._coord.api.stop()
except Exception as err: except BleakError as err:
raise HomeAssistantError( LOGGER.error(f"Failed to stop cover '{self.name}': {err}")
f"Failed stop cover '{self.name}': {err}"
) from err