Commit Graph

653 Commits

Author SHA1 Message Date
b308b54b89 [tasks] Fix change_interval raising when called during execution 2022-03-07 17:35:42 -05:00
13355f3712 Fix HelpCommand.invoked_with raising an error
This would happen if the context hasn't been set yet.
2022-03-06 23:02:01 -05:00
aa725f4a4a [docs] Fix typo in tasks docs 2022-03-06 19:03:36 -05:00
9d3fa3d29b [commands] Simplify typing of command hooks 2022-03-06 03:44:20 -05:00
eaf94e84bc Fix unbound ParamSpec to use ... over Any 2022-03-06 01:44:48 -05:00
625c416f18 [commands] Fix command parameter handling in HelpCommand 2022-03-06 01:39:43 -05:00
bfaee44b1f [commands] Fix types for Bot.is_owner 2022-03-05 22:06:21 -05:00
00b61e2148 Parameters->Attributes in NSFWChannelRequired's doc for consistency 2022-03-05 19:15:48 -05:00
5439a67056 [tasks] Fix sleep handling behaviour depending on interval type
Relative time intervals can be thought of as:

  for _ in range(count):
    await body()
    await asyncio.sleep(interval)

While explicit time intervals should be thought of as:

  times = [1pm, 2pm, 3pm, 12am]
  current = 0
  for _ in range(count):
    time = times.wrapping_index(current)  # magic to wrap around
    await utils.sleep_until(time)
    await body()
    current += 1
2022-03-05 05:12:22 -05:00
147948af9b Use typing.Self throughout library 2022-03-01 07:53:24 -05:00
90cabd1673 Fix various typos 2022-02-27 21:19:19 -05:00
f1ac25809c [tasks] Fix behavior when task overruns interval
In a scenario with `tasks.loop(seconds=5)`:

The task takes 30 seconds to run on the first two iterations, and then
is nearly instant for iterations afterward. The behavior should be
that the task runs at:

t = 0  (on time)
t = 30 (late, should've been at t = 5)
t = 60 (late, should've been at t = 10)
t = 60 (late, should've been at t = 15)
t = 60 (late, should've been at t = 20)
t = 60 (late, should've been at t = 25)
... 6 more iterations
t = 60 (on time)
t = 65 (on time)

In a scenario with a loop with explicit times set at UTC 1pm, 2pm, 
3pm, 4pm, and 5pm:

- The task takes 6 hour to run on the first iteration, and then is
  nearly instant for iterations afterward. Assuming the task is started
  at noon, the behavior should be that the task runs at `t = 0` and
  then at `t = 3600` 4 times ("catching up" on the missed iterations
  at 2pm, 3pm, 4pm, and 5pm).

- The task takes 30 days to run on the first iteration, and then is
  nearly instant for iterations afterward. Assuming the task is started
  at noon, the behavior should be that the task runs at `t = 0` and
  then at `t = 43200` 149 times ("catching up" on the missed
  iterations for the past month).

This behavior should be documented in the ext.tasks docs
2022-02-26 01:48:27 -05:00
8226f0df2c [commands] Require number of parameters at instantiation time
This allows it to bypass annotation evaluation for arguments that don't
matter like self and context.
2022-02-25 10:55:45 -05:00
39c5a4fdc3 Fix type-errors in commands extension 2022-02-23 08:04:49 -05:00
a315786869 Handle type-errors in upcoming pyright release 2022-02-22 08:51:11 -05:00
cd1dd7d670 [commands] Properly eject listeners with custom names 2022-02-21 21:42:00 -05:00
19ad64adda [tasks] Fix initial loop execution running prematurely 2022-02-21 20:45:03 -05:00
88b520b5ab Reformat code using black
Segments where readability was hampered were fixed by appropriate
format skipping directives. New code should hopefully be black
compatible. The moment they remove the -S option is probably the moment
I stop using black though.
2022-02-20 08:04:58 -05:00
4dbe1af32f Update sphinx and fix documentation issues 2022-02-19 22:35:32 -05:00
dc19c6c7d5 Add positional-only arguments in more places 2022-02-19 20:28:01 -05:00
4e331704ae [commands] Fix typing problems in commands.converter 2022-02-18 23:04:56 -05:00
61974411df [commands] Fix issue in PartialMessageConverter._resolve channel 2022-02-18 23:00:52 -05:00
b1571ccc25 [commands] Fix Command.cog being reset after update 2022-02-18 08:31:45 -05:00
a2a7b0f076 [tasks] Improve typing parity 2021-08-27 17:18:15 -04:00
b2ac327bd8 [commands] Fix a small typo in Context.invoke docs 2021-08-27 16:02:10 -04:00
2d8f299b6b Use MISSING instead of None for HelpCommand.context
It's basically just late-init
2021-08-25 09:53:55 -04:00
9727b56503 Fix references in docs 2021-08-22 05:50:28 -04:00
ea2d972666 Make global log variable in modules private 2021-08-22 02:33:51 -04:00
166152647c [commands] Make GroupMixin Generic 2021-08-21 14:35:05 -04:00
9246bbc8e3 [commands] De-indent after hook call
Close #7412
2021-08-20 20:08:27 -04:00
fa5a2188bb Copy docs from Client.close() to Bot.close() 2021-08-20 20:06:51 -04:00
1d2eaf8526 [commands] reset view when Optional argument encounters parsing error 2021-08-19 19:56:28 -04:00
f3cb197429 [commands][types] Type hint commands-ext 2021-08-19 19:51:26 -04:00
8fdd1f0d8f [commands] Typehinted errors.py 2021-08-18 01:03:44 -04:00
6b6bcb92e6 Fix missing or broken versionadded in docstrings
This also documents BadFlagArgument.flag
2021-08-18 00:45:02 -04:00
c4ee9dcafa [commands] Return removed cog in Bot.remove_cog
The method now returns the removed cog, if it exists.
2021-08-18 00:39:54 -04:00
1c63816cc0 [commands] Document / type-hint cooldown 2021-08-10 08:35:15 -04:00
c628224403 [commands] Add GuildStickerConverter 2021-08-10 08:31:20 -04:00
8851e03a6d [commands] fix bot_has_role and is_nsfw for threads 2021-07-30 21:26:49 -04:00
731a8816bb [commands] Check for ctx.guild instead of abc.GuildChannel 2021-07-28 23:53:24 -04:00
1472e9ed7c Fixes minor grammatical error in Command.update 2021-07-28 19:56:36 -04:00
8675a18185 [commands] Remove unused copy import in Cog 2021-07-21 02:48:11 -04:00
26e68b31ef [commands] fix incorrect typings in ThreadConverter 2021-07-21 02:43:37 -04:00
e2624b9a31 [commands] Fix (Partial)MessageConverter to work with thread messages 2021-07-10 03:11:34 -04:00
1a4e73d599 [commands] Get guild_id from message link for message converters 2021-07-09 09:14:01 -04:00
1ca5b7b8b2 [commands] update clean_content to work when standalone 2021-07-07 20:15:54 -04:00
3cb539d91b [commands] Document the thread converter 2021-07-07 20:15:18 -04:00
5a7cfb3ce6 [commands] Add ThreadConverter 2021-07-05 00:40:57 -04:00
d047cebc35 [commands] Remove window reassignment when tokens reach 0 2021-07-04 03:05:06 -04:00
a3d7e06f25 [commands] Add back CommandOnCooldown.type 2021-07-02 05:39:54 -04:00