mirrors/discord.py
1
0
Fork 0
mirror of https://github.com/Rapptz/discord.py.git synced 2025-06-07 20:28:38 +00:00
Code Issues Projects Releases Wiki Activity

[tasks] Compare using full datetime rather than sole time

Browse Source 
Comparisons using just the time object without an attached date
are pretty buggy and incomplete -- comparisons only make sense when
given a particular instant of time.

Ref: #7676
This commit is contained in:
Rapptz 2022-03-13 20:44:05 -04:00
parent 58ad146a4e
commit a339e01047
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
discord/ext/tasks/__init__.py
View File

@ -603,9 +603,16 @@ class Loop(Generic[LF]):
# to calculate the next time index from # to calculate the next time index from
# pre-condition: self._time is set # pre-condition: self._time is set
time_now = now.timetz()
# Sole time comparisons are apparently broken, therefore, attach today's date
# to it in order to make the comparisons make sense.
# For example, if given a list of times [0, 3, 18]
# If it's 04:00 today then we know we have to wait until 18:00 today
# If it's 19:00 today then we know we we have to wait until 00:00 tomorrow
date = now.date()
for idx, time in enumerate(self._time): for idx, time in enumerate(self._time):
if time >= time_now: start_time = datetime.datetime.combine(date, time, tzinfo=time.tzinfo)
if start_time >= now:
return idx return idx
else: else:
return None return None