mirrors/discord.py
1
0
Fork 0
mirror of https://github.com/Rapptz/discord.py.git synced 2025-06-07 12:18:59 +00:00
Code Issues Projects Releases Wiki Activity

Fix abc.GuildChannel.overwrites returning None keys.

Browse Source 
This has potential for data loss as a consequence of how the function
works.
This commit is contained in:
Rapptz 2019-04-14 07:19:22 -04:00
parent 321efb11ed
commit 9b089c9a7b
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
discord/abc.py
View File

@ -365,7 +365,14 @@ class GuildChannel:
target = self.guild.get_role(ow.id) target = self.guild.get_role(ow.id)
elif ow.type == 'member': elif ow.type == 'member':
target = self.guild.get_member(ow.id) target = self.guild.get_member(ow.id)
ret[target] = overwrite
# TODO: There is potential data loss here in the non-chunked
# case, i.e. target is None because get_member returned nothing.
# This can be fixed with a slight breaking change to the return type,
# i.e. adding discord.Object to the list of it
# However, for now this is an acceptable compromise.
if target is not None:
ret[target] = overwrite
return ret return ret
@property @property