mirrors/discord.py
1
0
Fork 0
mirror of https://github.com/Rapptz/discord.py.git synced 2025-09-06 09:56:09 +00:00
Code Issues Projects Releases Wiki Activity

Change internal representation of roles in Member and Emoji.

Browse Source 
Introduce a new internal type, SnowflakeList, which has better memory
footprint over a regular list or set of roles. It is suspected that
there will be a 9x reduction of memory for every Emoji instance and a
48 byte saving per Member instance. However, these savings will
probably only be evident on larger bots.

As a consequence of this change, Member.roles is now computed lazily.

Currently I am not sure if I want to do the initial sorting on the
SnowflakeList for Member, as this comes with a O(n log n) cost when
creating a Member for little purpose since SnowflakeList.has is not
overly relied on. If CPU time becomes an issue this might change.
This commit is contained in:
Rapptz
2018-09-24 22:06:49 -04:00
parent 3d03dbc451
commit 95d8bb2e85
5 changed files with 67 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
discord/emoji.py
View File

@ -154,7 +154,7 @@ class Emoji(Hashable):
self.id = int(emoji['id'])
self.name = emoji['name']
self.animated = emoji.get('animated', False)
self._roles = set(emoji.get('roles', []))
self._roles = utils.SnowflakeList(map(int, emoji.get('roles', [])))
def _iterator(self):
for attr in self.__slots__:
@ -187,7 +187,7 @@ class Emoji(Hashable):
@property
def roles(self):
"""List[:class:`Role`]: A list of roles that is allowed to use this emoji.
"""List[:class:`Role`]: A :class:`list` of roles that is allowed to use this emoji.
If roles is empty, the emoji is unrestricted.
"""
@ -195,7 +195,7 @@ class Emoji(Hashable):
if guild is None:
return []
return [role for role in guild.roles if role.id in self._roles]
return [role for role in guild.roles if self._roles.has(role.id)]
@property
def guild(self):