mirrors/discord.py
1
0
Fork 0
mirror of https://github.com/Rapptz/discord.py.git synced 2025-07-12 12:55:31 +00:00
Code Issues Projects Releases Wiki Activity

Fix views not being removed from message store backing

Browse Source 
This uses the original interaction ID if available for cache eviction
This commit is contained in:
Rapptz 2023-01-24 11:10:22 -05:00
parent 02031d08fb
commit 6cb9a84898
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
discord/interactions.py
View File

@ -860,7 +860,15 @@ class InteractionResponse(Generic[ClientT]):
parent = self._parent parent = self._parent
msg = parent.message msg = parent.message
state = parent._state state = parent._state
message_id = msg.id if msg else None if msg is not None:
message_id = msg.id
# If this was invoked via an application command then we can use its original interaction ID
# Since this is used as a cache key for view updates
original_interaction_id = msg.interaction.id if msg.interaction is not None else None
else:
message_id = None
original_interaction_id = None
if parent.type not in (InteractionType.component, InteractionType.modal_submit): if parent.type not in (InteractionType.component, InteractionType.modal_submit):
return return
@ -890,7 +898,7 @@ class InteractionResponse(Generic[ClientT]):
) )
if view and not view.is_finished(): if view and not view.is_finished():
state.store_view(view, message_id) state.store_view(view, message_id, interaction_id=original_interaction_id)
self._response_type = InteractionResponseType.message_update self._response_type = InteractionResponseType.message_update

1
discord/ui/view.py
View File

@ -638,6 +638,7 @@ class ViewStore:
def remove_interaction_mapping(self, interaction_id: int) -> None: def remove_interaction_mapping(self, interaction_id: int) -> None:
# This is called before re-adding the view # This is called before re-adding the view
self._views.pop(interaction_id, None) self._views.pop(interaction_id, None)
self._synced_message_views.pop(interaction_id, None)
def is_message_tracked(self, message_id: int) -> bool: def is_message_tracked(self, message_id: int) -> bool:
return message_id in self._synced_message_views return message_id in self._synced_message_views