mirrors/discord.py
1
0
Fork 0
mirror of https://github.com/Rapptz/discord.py.git synced 2025-09-03 08:35:53 +00:00
Code Issues Projects Releases Wiki Activity

[commands] Fix nested hybrid groups inserting manual app commands

Browse Source
This commit is contained in:
Rapptz
2023-08-24 14:26:17 -04:00
parent c7f6e95f1c
commit 69e9bc9454
2 changed files with 98 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
discord/ext/commands/cog.py
View File

@ -305,6 +305,7 @@ class Cog(metaclass=CogMeta):
# Register the application commands
children: List[Union[app_commands.Group, app_commands.Command[Self, ..., Any]]] = []
app_command_refs: Dict[str, Union[app_commands.Group, app_commands.Command[Self, ..., Any]]] = {}
if cls.__cog_is_app_commands_group__:
group = app_commands.Group(
@ -331,6 +332,16 @@ class Cog(metaclass=CogMeta):
# Get the latest parent reference
parent = lookup[parent.qualified_name] # type: ignore
# Hybrid commands already deal with updating the reference
# Due to the copy below, so we need to handle them specially
if hasattr(parent, '__commands_is_hybrid__') and hasattr(command, '__commands_is_hybrid__'):
app_command: Optional[Union[app_commands.Group, app_commands.Command[Self, ..., Any]]] = getattr(
command, 'app_command', None
)
updated = app_command_refs.get(command.qualified_name)
if app_command and updated:
command.app_command = updated # type: ignore # Safe attribute access
# Update our parent's reference to our self
parent.remove_command(command.name) # type: ignore
parent.add_command(command) # type: ignore
@ -345,6 +356,11 @@ class Cog(metaclass=CogMeta):
# The type checker does not see the app_command attribute even though it exists
command.app_command = app_command # type: ignore
# Update all the references to point to the new copy
if isinstance(app_command, app_commands.Group):
for child in app_command.walk_commands():
app_command_refs[child.qualified_name] = child
if self.__cog_app_commands_group__:
children.append(app_command) # type: ignore # Somehow it thinks it can be None here