mirrors/discord.py
1
0
Fork 0
mirror of https://github.com/Rapptz/discord.py.git synced 2025-06-07 20:28:38 +00:00
Code Issues Projects Releases Wiki Activity

Fix SyncWebhook not working across thread barriers

Browse Source 
Fix #7310
This commit is contained in:
Rapptz 2021-07-30 22:59:03 -04:00
parent 06a371e80a
commit 658b61d468
1 changed files with 22 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
discord/webhook/sync.py
View File

@ -147,7 +147,9 @@ class WebhookAdapter:
file_data[name] = (p['filename'], p['value'], p['content_type']) file_data[name] = (p['filename'], p['value'], p['content_type'])
try: try:
with session.request(method, url, data=to_send, files=file_data, headers=headers, params=params) as response: with session.request(
method, url, data=to_send, files=file_data, headers=headers, params=params
) as response:
log.debug( log.debug(
'Webhook ID %s with %s %s has returned status code %s', 'Webhook ID %s with %s %s has returned status code %s',
webhook_id, webhook_id,
@ -346,8 +348,17 @@ class WebhookAdapter:
return self.request(route, session=session) return self.request(route, session=session)
_context = threading.local() class _WebhookContext(threading.local):
adapter: Optional[WebhookAdapter] = None
_context = _WebhookContext()
def _get_webhook_adapter() -> WebhookAdapter:
if _context.adapter is None:
_context.adapter = WebhookAdapter() _context.adapter = WebhookAdapter()
return _context.adapter
class SyncWebhookMessage(Message): class SyncWebhookMessage(Message):
@ -621,7 +632,7 @@ class SyncWebhook(BaseWebhook):
:class:`SyncWebhook` :class:`SyncWebhook`
The fetched webhook. The fetched webhook.
""" """
adapter: WebhookAdapter = _context.adapter adapter: WebhookAdapter = _get_webhook_adapter()
if prefer_auth and self.auth_token: if prefer_auth and self.auth_token:
data = adapter.fetch_webhook(self.id, self.auth_token, session=self.session) data = adapter.fetch_webhook(self.id, self.auth_token, session=self.session)
@ -659,7 +670,7 @@ class SyncWebhook(BaseWebhook):
if self.token is None and self.auth_token is None: if self.token is None and self.auth_token is None:
raise InvalidArgument('This webhook does not have a token associated with it') raise InvalidArgument('This webhook does not have a token associated with it')
adapter: WebhookAdapter = _context.adapter adapter: WebhookAdapter = _get_webhook_adapter()
if prefer_auth and self.auth_token: if prefer_auth and self.auth_token:
adapter.delete_webhook(self.id, token=self.auth_token, session=self.session, reason=reason) adapter.delete_webhook(self.id, token=self.auth_token, session=self.session, reason=reason)
@ -713,7 +724,7 @@ class SyncWebhook(BaseWebhook):
if avatar is not MISSING: if avatar is not MISSING:
payload['avatar'] = utils._bytes_to_base64_data(avatar) if avatar is not None else None payload['avatar'] = utils._bytes_to_base64_data(avatar) if avatar is not None else None
adapter: WebhookAdapter = _context.adapter adapter: WebhookAdapter = _get_webhook_adapter()
# If a channel is given, always use the authenticated endpoint # If a channel is given, always use the authenticated endpoint
if channel is not None: if channel is not None:
@ -873,7 +884,7 @@ class SyncWebhook(BaseWebhook):
allowed_mentions=allowed_mentions, allowed_mentions=allowed_mentions,
previous_allowed_mentions=previous_mentions, previous_allowed_mentions=previous_mentions,
) )
adapter: WebhookAdapter = _context.adapter adapter: WebhookAdapter = _get_webhook_adapter()
thread_id: Optional[int] = None thread_id: Optional[int] = None
if thread is not MISSING: if thread is not MISSING:
thread_id = thread.id thread_id = thread.id
@ -921,7 +932,7 @@ class SyncWebhook(BaseWebhook):
if self.token is None: if self.token is None:
raise InvalidArgument('This webhook does not have a token associated with it') raise InvalidArgument('This webhook does not have a token associated with it')
adapter: WebhookAdapter = _context.adapter adapter: WebhookAdapter = _get_webhook_adapter()
data = adapter.get_webhook_message( data = adapter.get_webhook_message(
self.id, self.id,
self.token, self.token,
@ -995,7 +1006,7 @@ class SyncWebhook(BaseWebhook):
allowed_mentions=allowed_mentions, allowed_mentions=allowed_mentions,
previous_allowed_mentions=previous_mentions, previous_allowed_mentions=previous_mentions,
) )
adapter: WebhookAdapter = _context.adapter adapter: WebhookAdapter = _get_webhook_adapter()
adapter.edit_webhook_message( adapter.edit_webhook_message(
self.id, self.id,
self.token, self.token,
@ -1029,7 +1040,7 @@ class SyncWebhook(BaseWebhook):
if self.token is None: if self.token is None:
raise InvalidArgument('This webhook does not have a token associated with it') raise InvalidArgument('This webhook does not have a token associated with it')
adapter: WebhookAdapter = _context.adapter adapter: WebhookAdapter = _get_webhook_adapter()
adapter.delete_webhook_message( adapter.delete_webhook_message(
self.id, self.id,
self.token, self.token,