mirrors/discord.py
1
0
Fork 0
mirror of https://github.com/Rapptz/discord.py.git synced 2025-07-13 05:15:22 +00:00
Code Issues Projects Releases Wiki Activity

Validate and bind parent in Group.add_command

Browse Source
This commit is contained in:
Rapptz 2022-03-16 07:31:40 -04:00
parent 7c0a9e901d
commit 5b8bcaff73
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
discord/app_commands/commands.py
View File

@ -872,7 +872,8 @@ class Group:
The command or group is already registered. Note that the :attr:`CommandAlreadyRegistered.guild_id` The command or group is already registered. Note that the :attr:`CommandAlreadyRegistered.guild_id`
attribute will always be ``None`` in this case. attribute will always be ``None`` in this case.
ValueError ValueError
There are too many commands already registered. There are too many commands already registered or the group is too
deeply nested.
TypeError TypeError
The wrong command type was passed. The wrong command type was passed.
""" """
@ -880,10 +881,19 @@ class Group:
if not isinstance(command, (Command, Group)): if not isinstance(command, (Command, Group)):
raise TypeError(f'expected Command or Group not {command.__class__!r}') raise TypeError(f'expected Command or Group not {command.__class__!r}')
if isinstance(command, Group) and self.parent is not None:
# In a tree like so:
# <group>
# <self>
# <group>
# this needs to be forbidden
raise ValueError('groups can only be nested at most one level')
if not override and command.name in self._children: if not override and command.name in self._children:
raise CommandAlreadyRegistered(command.name, guild_id=None) raise CommandAlreadyRegistered(command.name, guild_id=None)
self._children[command.name] = command self._children[command.name] = command
command.parent = self
if len(self._children) > 25: if len(self._children) > 25:
raise ValueError('maximum number of child commands exceeded') raise ValueError('maximum number of child commands exceeded')