Fix typing issues and improve typing completeness across the library

Co-authored-by: Danny <Rapptz@users.noreply.github.com>
Co-authored-by: Josh <josh.ja.butt@gmail.com>
This commit is contained in:
Stocker
2022-03-13 23:52:10 -04:00
committed by GitHub
parent 603681940f
commit 5aa696ccfa
66 changed files with 1071 additions and 802 deletions

View File

@ -121,7 +121,7 @@ class Select(Item[V]):
options=options,
disabled=disabled,
)
self.row = row
self.row: Optional[int] = row
@property
def custom_id(self) -> str:
@ -129,7 +129,7 @@ class Select(Item[V]):
return self._underlying.custom_id
@custom_id.setter
def custom_id(self, value: str):
def custom_id(self, value: str) -> None:
if not isinstance(value, str):
raise TypeError('custom_id must be None or str')
@ -141,7 +141,7 @@ class Select(Item[V]):
return self._underlying.placeholder
@placeholder.setter
def placeholder(self, value: Optional[str]):
def placeholder(self, value: Optional[str]) -> None:
if value is not None and not isinstance(value, str):
raise TypeError('placeholder must be None or str')
@ -153,7 +153,7 @@ class Select(Item[V]):
return self._underlying.min_values
@min_values.setter
def min_values(self, value: int):
def min_values(self, value: int) -> None:
self._underlying.min_values = int(value)
@property
@ -162,7 +162,7 @@ class Select(Item[V]):
return self._underlying.max_values
@max_values.setter
def max_values(self, value: int):
def max_values(self, value: int) -> None:
self._underlying.max_values = int(value)
@property
@ -171,7 +171,7 @@ class Select(Item[V]):
return self._underlying.options
@options.setter
def options(self, value: List[SelectOption]):
def options(self, value: List[SelectOption]) -> None:
if not isinstance(value, list):
raise TypeError('options must be a list of SelectOption')
if not all(isinstance(obj, SelectOption) for obj in value):
@ -187,7 +187,7 @@ class Select(Item[V]):
description: Optional[str] = None,
emoji: Optional[Union[str, Emoji, PartialEmoji]] = None,
default: bool = False,
):
) -> None:
"""Adds an option to the select menu.
To append a pre-existing :class:`discord.SelectOption` use the
@ -226,7 +226,7 @@ class Select(Item[V]):
self.append_option(option)
def append_option(self, option: SelectOption):
def append_option(self, option: SelectOption) -> None:
"""Appends an option to the select menu.
Parameters
@ -251,7 +251,7 @@ class Select(Item[V]):
return self._underlying.disabled
@disabled.setter
def disabled(self, value: bool):
def disabled(self, value: bool) -> None:
self._underlying.disabled = bool(value)
@property