From 128c9f4eb8048713ba5c6cf0dfc768a5b8473c60 Mon Sep 17 00:00:00 2001 From: Steve C Date: Sun, 10 May 2020 01:20:04 -0400 Subject: [PATCH] Use GuildChannel abc for CategoryChannel edit I noticed nothing happened when I did `ch.edit(overwrites=oh.overwrites)` `http.edit_channel` doesn't do anything with the `overwrites` keyword, it's processed as `permission_overwrites` instead which `self._edit` takes care of. I feel this was an oversight at some point. --- discord/channel.py | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/discord/channel.py b/discord/channel.py index 1879a974d..68383b8c0 100644 --- a/discord/channel.py +++ b/discord/channel.py @@ -791,17 +791,7 @@ class CategoryChannel(discord.abc.GuildChannel, Hashable): Editing the category failed. """ - try: - position = options.pop('position') - except KeyError: - pass - else: - await self._move(position, reason=reason) - self.position = position - - if options: - data = await self._state.http.edit_channel(self.id, reason=reason, **options) - self._update(self.guild, data) + await self._edit(options=options, reason=reason) @property def channels(self):