mirror of
https://github.com/pmmp/PocketMine-MP.git
synced 2025-06-12 22:45:28 +00:00
a62ce64fdd
This reverts commit a5418a019dc2a83210084632130db8ce06f529ea. The more I assessed this, the more I realized that this implementation doesn't actually offer any value. Since modcounters don't persist after chunk unload + reload, they can't be reliably used to detect changes in chunks without additional event subscriptions. For the purpose I actually intended to use them for (population task cancellation) there's a) another solution, and b) modcounts are unreliable for that too, because of the aforementioned potential for chunks to get unloaded and reloaded. For the case of detecting dirty chunks within PopulationTask itself, they are also unnecessary, since the dirty flags are sufficient within there, since FastChunkSerializer doesn't copy dirty flags. In conclusion, this was a misbegotten addition with little real value, but does impact performance in hot paths.