mirror of
https://github.com/pmmp/PocketMine-MP.git
synced 2025-05-09 15:29:47 +00:00
6a26c0bebf
this commit removes the ability to replace centrally registered entity classes in favour of using constructors directly. In future commits I may introduce a dedicated factory interface which allows an _actual_ factory pattern (e.g. factory->createArrow(world, pos, shooter, isCritical) with proper static analysability) but for now it's peripheral to my intended objective. The purpose of this change is to facilitate untangling of NBT from entity constructors so that they can be properly created without using NBT at all, and instead use nice APIs. Spawn eggs now support arbitrary entity creation functions like EntityFactory does, allowing much more flexibility in what can be passed to an entity's constructor (e.g. a Plugin reference can be injected by use()ing it in a closure or via traditional DI.
43 lines
1.5 KiB
Plaintext
43 lines
1.5 KiB
Plaintext
parameters:
|
|
ignoreErrors:
|
|
-
|
|
message: "#^Parameter \\#1 \\$class of method pocketmine\\\\world\\\\format\\\\io\\\\WorldProviderManager\\:\\:setDefault\\(\\) expects class\\-string\\<pocketmine\\\\world\\\\format\\\\io\\\\WritableWorldProvider\\>, class\\-string\\<pocketmine\\\\world\\\\format\\\\io\\\\WorldProvider\\> given\\.$#"
|
|
count: 1
|
|
path: ../../../src/Server.php
|
|
|
|
-
|
|
message: "#^Comparison operation \"\\>\\=\" between 0 and 2 is always false\\.$#"
|
|
count: 1
|
|
path: ../../../src/block/Liquid.php
|
|
|
|
-
|
|
message: "#^If condition is always false\\.$#"
|
|
count: 1
|
|
path: ../../../src/block/Liquid.php
|
|
|
|
-
|
|
message: "#^Call to function is_resource\\(\\) with resource will always evaluate to true\\.$#"
|
|
count: 3
|
|
path: ../../../src/command/CommandReader.php
|
|
|
|
-
|
|
message: "#^Call to function assert\\(\\) with false and 'unknown hit type' will always evaluate to false\\.$#"
|
|
count: 1
|
|
path: ../../../src/entity/projectile/Projectile.php
|
|
|
|
-
|
|
message: "#^Strict comparison using \\=\\=\\= between string and false will always evaluate to false\\.$#"
|
|
count: 1
|
|
path: ../../../src/utils/Utils.php
|
|
|
|
-
|
|
message: "#^Call to function is_resource\\(\\) with resource will always evaluate to true\\.$#"
|
|
count: 2
|
|
path: ../../../src/world/format/io/region/RegionLoader.php
|
|
|
|
-
|
|
message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertNotNull\\(\\) with int and string will always evaluate to true\\.$#"
|
|
count: 1
|
|
path: ../../phpunit/block/BlockTest.php
|
|
|