*/ final class UnsafeForeachArrayOfStringRule implements Rule{ public function getNodeType() : string{ return Foreach_::class; } public function processNode(Node $node, Scope $scope) : array{ /** @var Foreach_ $node */ if($node->keyVar === null){ return []; } $iterableType = $scope->getType($node->expr); if($iterableType->isArray()->no()){ return []; } if($iterableType->isIterableAtLeastOnce()->no()){ return []; } $hasCastableKeyTypes = false; $expectsIntKeyTypes = false; TypeTraverser::map($iterableType->getIterableKeyType(), function(Type $type, callable $traverse) use (&$hasCastableKeyTypes, &$expectsIntKeyTypes) : Type{ if($type instanceof IntegerType){ $expectsIntKeyTypes = true; return $type; } if(!$type instanceof StringType){ return $traverse($type); } if($type->isNumericString()->no() || $type instanceof ClassStringType){ //class-string cannot be numeric, even if PHPStan thinks they can be return $type; } $hasCastableKeyTypes = true; return $type; }); if($hasCastableKeyTypes && !$expectsIntKeyTypes){ $func = \Closure::fromCallable([Utils::class, 'stringifyKeys']); return [ RuleErrorBuilder::message(sprintf( "Unsafe foreach on array with key type %s (they might be casted to int).", $iterableType->getIterableKeyType()->describe(VerbosityLevel::value()) ))->tip(sprintf("Use %s() for a safe Generator-based iterator.", Utils::getNiceClosureName($func)))->build() ]; } return []; } }