14569 Commits

Author SHA1 Message Date
Dylan K. Taylor
6aab07debd
Release 5.4.4 2023-09-06 11:53:01 +01:00
Dylan K. Taylor
b160b87e24
Server: stop discriminating against crashes caused by folder plugins
these are the de facto standard, which means that a lot of crashes aren't getting reported from servers with folder plugins.
2023-09-06 11:34:03 +01:00
Dylan K. Taylor
690ee4c574
CrashDump: fixed empty elements in lastError trace
as shown by #6010
2023-09-06 11:24:08 +01:00
Jonathan B
ce04478395
Fix SmithingTableInventory size (#6035)
Since 1.20 SmithingTable has a new Template slot, size is now 3

Fix debug error from InventoryManager
2023-09-06 08:15:27 +01:00
ねらひかだ
19e3d339f6
InGamePacketHandler: subtract from raw position before rounding it (#6022)
This allows better compensation for floating point errors introduced by the subtraction of the 1.62 height offset.

For example, if the player is at y=7 exactly, their Y coordinate will be reported as 8.62, which, because of floating point errors, will be something like `8.619999999`. Subtracting `1.62` from this (really something like `1.62000000000005...`) leads to the calculated Y coordinate being slightly below 7.

Rounding after subtracting this offset allows this to be rounded to 7 sharp. Similar errors appear in various other coordinates.
2023-08-29 11:43:21 +01:00
Dylan K. Taylor
4cc858829f
5.4.4 is next 2023-08-21 18:31:45 +01:00
Dylan K. Taylor
e852a43821
Release 5.4.3 2023-08-21 18:31:45 +01:00
Dylan K. Taylor
18ca3a37d9
CrashDump: fixed crashdump generation failure on fatal error
closes #6007
2023-08-21 14:51:54 +01:00
Dylan K. Taylor
4b41fca991
Merge branch 'legacy/pm4' into stable 2023-08-18 12:28:29 +01:00
Dylan K. Taylor
9f09acc079
Workaround for slot IDs not changing client side when old item == new item
this is a really dumb bug and seems similar to the armor bug I fixed a while ago.

fixes #5987

it's unlikely that #5727 will be solved by this, but one can hope...
2023-08-18 12:27:27 +01:00
ipad54
af9ae445fc
Fix cake drops (#5985)
closes #5984
2023-08-10 17:42:32 +01:00
Dylan K. Taylor
91d5a3ddfe
PotionCauldron: fixed setPotionItem() not validating the given item
we should probably remove this API and have enums for potion container and type tbh... this API was a mistake
2023-08-10 16:06:41 +01:00
Hugo_
f03e708f64
Fix chorus not working if the destination would be below y=0 (#5979) 2023-08-10 09:42:58 +01:00
Dylan K. Taylor
e27121a437
5.4.3 is next 2023-08-09 14:04:57 +01:00
Dylan K. Taylor
2d5c9e64ce
Release 5.4.2 2023-08-09 14:04:57 +01:00
Dylan K. Taylor
78f5fbddf3
Merge branch 'legacy/pm4' into stable 2023-08-09 13:58:14 +01:00
Dylan K. Taylor
aa3f4f2545
4.23.6 is next 2023-08-09 13:56:19 +01:00
Dylan K. Taylor
f7279b6672
Release 4.23.5 2023-08-09 13:56:19 +01:00
Dylan K. Taylor
b4c5f5d58d
PluginBase: fixed resource leak
all this time we've been harping at plugin devs to fix their own leaks, and here's one right under our noses that no one spotted for 10 years ...

this leak is rather common, since it will occur whenever a plugin attempts to save a resource which already exists in the data folder.

This bug was introduced in 2014 by commit 63288346814b7b827f1f7cc7a16419af43bd0bfa.
2023-08-09 13:28:05 +01:00
Dylan K. Taylor
735d9a5bf4
CandleTrait: allow candle to be lit by fire charges 2023-08-09 12:04:02 +01:00
Dylan K. Taylor
f4a06605b1
Cake: only accept candle when no slices have been taken
otherwise, cake slices can be regenerated using candle
2023-08-09 11:42:08 +01:00
Dylan K. Taylor
662f2495e9
5.4.2 is next 2023-08-08 18:41:09 +01:00
Dylan K. Taylor
b8a4ca45e4
Release 5.4.1 2023-08-08 18:41:06 +01:00
Dylan K. Taylor
ebcd6a0bb2
CraftItemEvent: fixed inputs and outputs not being cloned 2023-08-08 18:29:49 +01:00
Dylan K. Taylor
9c1ab943bc
Bump ext-pmmpthread min version to 6.0.7 2023-08-08 17:43:31 +01:00
Dylan K. Taylor
c1638ffaab
Ban foreach by-reference at the PHPStan level 2023-08-08 17:08:13 +01:00
Dylan K. Taylor
710177ceb5
CS
this mistake actually hasn't happened for a while
2023-08-08 15:10:31 +01:00
Dylan K. Taylor
2559d1719f
All pocketmine\thread\Thread now log uncaught exceptions and fatal errors by default 2023-08-08 14:56:54 +01:00
Dylan K. Taylor
2e58387a43
Fixed thread error capture fail in shutdown function
the shutdown handler currently isn't called until join(), which sets isKilled to true and stops the error information from being recorded.
2023-08-08 14:55:53 +01:00
ipad54
35a28300f6
Podzol should be affected by silk touch (#5969) 2023-08-07 11:47:29 +01:00
jasonw_4331
1a2c10e844
World: Fixed getSafeSpawn() not accepting seed positions below y=1 (#5955)
this should have been changed during the introduction of y=-64 minimum world height, but it got missed.
2023-08-02 18:05:16 +01:00
Dylan K. Taylor
d88c3d8ced
Fixed coral block killing itself when calling getDropsForCompatibleTool()
this might be called by plugins without actually breaking the block, in which case the block will glitch.
2023-08-02 13:43:36 +01:00
Dylan K. Taylor
bb0e648276
Fixed BlockDeathEvent usages showing an oldState which is already dead 2023-08-02 13:36:54 +01:00
Dylan K. Taylor
53de55dcde
5.4.1 is next 2023-08-01 12:46:56 +01:00
Dylan K. Taylor
01664d2e81
Release 5.4.0 2023-08-01 12:46:53 +01:00
Dylan K. Taylor
0a90a5928a
Added TallGrassTrait, remove weirdly specific logic from FortuneDropHelper
this needs to be dealt with before release otherwise we'll be stuck with FortuneDropHelper::grass()
this is the obvious solution and should have been done some time ago - stuff like flammability was already a problem for double tall grass anyway
2023-08-01 12:33:36 +01:00
Dylan K. Taylor
46f24b165a
Rename PlayerMissedSwingEvent -> PlayerMissSwingEvent
all the other events are present tense, so it doesn't make sense for this one to be past tense.
2023-08-01 12:21:39 +01:00
Dylan K. Taylor
6f09286fed
Merge branch 'minor-next' into stable 2023-08-01 11:57:02 +01:00
Dylan K. Taylor
774eb3e72b
5.3.5 is next 2023-08-01 11:16:51 +01:00
Dylan K. Taylor
cd8219d9fd
Release 5.3.4 2023-08-01 11:16:50 +01:00
Dylan K. Taylor
e9e5923639
4.23.5 is next 2023-08-01 11:12:52 +01:00
Dylan K. Taylor
49a9da147b
Release 4.23.4 2023-08-01 11:12:41 +01:00
Dylan K. Taylor
4c737b2ee3
Merge branch 'legacy/pm4' into stable 2023-07-31 11:29:58 +01:00
Dylan K. Taylor
eb53b795d5
ItemEntity: fixed O(n^2) performance issue when many of the same unstackable item are in the same place
this produced a 40% performance improvement in a simulation with 800 item entities.

If the items were all different, then this would still be a problem. However, many of the same unstackable items occupying the same space is a problem for SkyBlock farms, so this should improve performance for SkyBlock quite a bit.
2023-07-31 11:29:12 +01:00
Dylan K. Taylor
9b2a7b43c2
ItemEntity: fixed O(n^2) performance issue when many of the same unstackable item are in the same place
this produced a 40% performance improvement in a simulation with 800 item entities.

If the items were all different, then this would still be a problem. However, many of the same unstackable items occupying the same space is a problem for SkyBlock farms, so this should improve performance for SkyBlock quite a bit.
2023-07-28 16:06:29 +01:00
Dylan K. Taylor
5ec3f4655f
EntityDamageByEntityEvent: added APIs to get and set vertical knockback limits
this was requested and PR'd as far back as 2020 (see #3782).
Since no issue was filed about this, it became forgotten until #5946.
However, #5946 overcomplicates the solution to the problem, and breaks BC without an obvious reason.
2023-07-28 12:52:15 +01:00
Dylan K. Taylor
c972e65741
EntityDamageByEntityEvent: document methods 2023-07-28 12:41:27 +01:00
Dylan K. Taylor
a45763328b
Added constants for default knockback force and vertical limit 2023-07-28 12:36:46 +01:00
Dylan T
82a5ea9ed3
Allow thread errors and their traces to be properly recorded in crashdumps (#5910)
until now, any thread crash would show as a generic crash since we aren't able to get the trace from the crashed thread directly. This uses some dirty tricks to export a partially serialized stack trace to the main thread, where it can be written into a crashdump.
This enables us to see proper crash information for async tasks in the crash archive (finally!!!) as well as being able to capture RakLib errors properly.
2023-07-26 16:26:03 +01:00
rasu3n
bbdcab7277
Player: Added animation to missSwing() (#5942) 2023-07-26 10:04:36 +01:00