16063 Commits

Author SHA1 Message Date
Dylan K. Taylor
14c1a9550d
Update composer dependencies 2023-04-05 20:12:21 +01:00
Dylan K. Taylor
9037d5f16b
4.18.4 is next 2023-04-05 20:07:38 +01:00
Dylan K. Taylor
8b64ea9e65
Release 4.18.3 4.18.3 2023-04-05 20:07:23 +01:00
Dylan K. Taylor
2936726bf8
Fixed packets sent by EntityEventBroadcaster not firing DataPacketSendEvent
closes #5670

I'm not super happy with this fix, since it can still be broken if StandardPacketBroadcaster is replaced by something else. However, fixing that problem is probably going to require internal BC breaks, which are not suitable for a patch release.
2023-04-03 22:46:14 +01:00
Dylan K. Taylor
9cd07f6721
NetworkBroadcastUtils: remove dead code
we don't allow changing the target list anymore, since it increases internal complexity, so this code is redundant.
2023-04-03 22:37:22 +01:00
Dylan K. Taylor
4bb8daa1a5
ItemStackRequestExecutor: allow any action to take from the created output slot
fixes #5679
2023-04-03 22:24:40 +01:00
Dylan K. Taylor
6e8eda4ac1
Fixed creative inventory items getting modified by ItemStackRequests 2023-04-03 22:22:21 +01:00
Dylan K. Taylor
73522d06ef
... 2023-03-31 21:51:07 +01:00
Dylan K. Taylor
a6a360d179
Revert "Be more concise in event handler timing names"
This reverts commit 9db7e5f0ca984f17d6a8218d1c74b9be1c605863.
2023-03-31 21:51:00 +01:00
Dylan K. Taylor
199ef7401f
Revert "Timings: do not shorten event handler timing names"
This reverts commit a2ff9649d5f9a14a2bb6e9ab7bab4ea731d225a3.
2023-03-31 21:49:25 +01:00
Dylan K. Taylor
f63d349be4
Merge remote-tracking branch 'origin/stable' into minor-next 2023-03-31 21:28:14 +01:00
Dylan T
02e11b5a60
Timings tree (#5587)
Split timings into tree reports
this will allow the timings site to display timings as a tree, instead of as a list as is done now, which will enable more precise identification of performance issues.

An example of this can be seen here: https://timings.pmmp.io/?id=302629

The format changes are fully backwards compatible, as the timings site
aggregates timings from timers with the same names, and doesn't limit
how much extra data can appear at the end of a line.
2023-03-31 21:26:58 +01:00
Dylan K. Taylor
4a770e5801
CS 2023-03-31 20:32:42 +01:00
Dylan K. Taylor
a2ff9649d5
Timings: do not shorten event handler timing names
this doesn't work very well in tree view timings
2023-03-31 19:44:06 +01:00
Dylan K. Taylor
a862cf5144
Workaround ItemStackRequest offhand incorrect slot bug
closes #5667

this appears to be a client bug specific to ItemStackRequest.
2023-03-31 17:27:11 +01:00
Dylan K. Taylor
5ac0d7ae11
TimingsRecord: fixed incorrect violations calculation
closes #5665
2023-03-31 17:08:59 +01:00
Dylan K. Taylor
0c47455b24
Timings: ensure that Average Players count is shown properly when custom player classes are used 2023-03-30 18:12:06 +01:00
Dylan K. Taylor
821dd8885b
Merge branch 'stable' into minor-next 2023-03-29 23:56:08 +01:00
Dylan K. Taylor
a78ae73119
4.18.3 is next 2023-03-29 23:52:31 +01:00
Dylan K. Taylor
17a1266056
Release 4.18.2 4.18.2 2023-03-29 23:52:31 +01:00
Dylan K. Taylor
217d7ab4cf
Merge tag '4.17.2' into stable 2023-03-29 23:50:58 +01:00
Dylan K. Taylor
9e8c0a6bea
Release 4.17.2 4.17.2 2023-03-29 23:47:49 +01:00
Dylan K. Taylor
dc1b5a9285
it might help if we actually included the fix 2023-03-29 23:46:53 +01:00
Dylan K. Taylor
c3a16d9b1f
ItemStackResponseBuilder: fixed durability appearing to reset when moving durables around the inventory
closes #5656
2023-03-29 23:31:46 +01:00
Dylan K. Taylor
bed218d1dd
Fixed the first letter of event timing names getting trimmed off when src-namespace-prefix is not used 2023-03-29 23:11:30 +01:00
Dylan K. Taylor
5e1f837a73
... 2023-03-28 22:46:18 +01:00
Dylan K. Taylor
b49a9ae81d
Added timings for calling events
this gives a somewhat better overview of events, particularly if many plugins are subscribed to the same costly event (e.g. PlayerMoveEvent).

In addition, it allows us to see the frequency that events are occurring.
2023-03-28 17:26:20 +01:00
Dylan K. Taylor
4c60e82110
Merge remote-tracking branch 'origin/stable' into minor-next 2023-03-27 19:08:18 +01:00
Dylan K. Taylor
beb0713a40
4.18.2 is next 2023-03-27 18:03:17 +01:00
Dylan K. Taylor
cd603e8266
Release 4.18.1 4.18.1 2023-03-27 18:03:16 +01:00
Dylan K. Taylor
af385668c2
InventoryManager: give more detailed information on failure to get info for held item 2023-03-27 17:55:39 +01:00
Dylan K. Taylor
3ee62d8440
InGamePacketHandler: increase max ItemStackRequest actions to 60
due to implementation quirks + some unforeseen ways these actions can behave, there can be as many as 53 actions in a single crafting request. This is an edge case, but it has to be catered for.
2023-03-27 15:44:42 +01:00
Dylan K. Taylor
811639f2cd
InGamePacketHandler: relax errors on normal transactions to fix book editing
for some reason book edits generate a transaction in addition to BookEditPacket. PM has never used the transaction, and it doesn't pass anyway because CreateItemAction can't be used in survival mode.
However, since the strict validation introduced since ItemStackRequest, this dud transaction now causes the player to get kicked without these changes.
2023-03-27 13:26:26 +01:00
Dylan K. Taylor
58974765a6
InGamePacketHandler: fixed crash when attempting to drop more of an item than is available 2023-03-27 13:26:26 +01:00
dependabot[bot]
eca9fe50b6
Bump build/php from a464454 to 9d8807b (#5654)
Bumps [build/php](https://github.com/pmmp/php-build-scripts) from `a464454` to `9d8807b`.
- [Release notes](https://github.com/pmmp/php-build-scripts/releases)
- [Commits](a464454d1e...9d8807be82)

---
updated-dependencies:
- dependency-name: build/php
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-27 13:03:30 +01:00
Dylan K. Taylor
1959d6dc9b
Fix CS 2023-03-27 12:59:26 +01:00
Dylan K. Taylor
9db7e5f0ca
Be more concise in event handler timing names 2023-03-27 01:19:17 +01:00
Dylan K. Taylor
c1cef19f84
stringifyKeys 2023-03-27 01:17:15 +01:00
Dylan K. Taylor
cebdb95265
Optimise plugin timings report entries
this format is already supported by the timings host, so no changes are required to support this.
2023-03-27 01:15:42 +01:00
Dylan K. Taylor
006cdaf6ea
RakLibInterface: log the name of the session which triggered an unhandled exception
this makes it easier to identify what sequence of events led up to the crash.
2023-03-26 18:56:24 +01:00
Dylan K. Taylor
acc8ae87fb
4.18.1 is next 2023-03-25 20:51:38 +00:00
Dylan K. Taylor
0e8b28716a
Release 4.18.0 4.18.0 2023-03-25 20:51:34 +00:00
Dylan K. Taylor
7c77233d12
Merge branch 'stable' into minor-next 2023-03-25 20:26:54 +00:00
Dylan K. Taylor
6f02b83a26
Update composer dependencies 2023-03-25 20:26:50 +00:00
Dylan K. Taylor
fbfdf749f2
Merge branch 'stable' into minor-next 2023-03-25 20:25:48 +00:00
Dylan K. Taylor
289c0b08f4
Explicitly state that pocketmine\network\mcpe is an internal package 2023-03-24 14:06:25 +00:00
Dylan K. Taylor
dd37b531ad
CONTRIBUTING.md: document network API policy 2023-03-24 14:02:23 +00:00
Dylan K. Taylor
58d5126ada
InventoryManager: fixed crashes when setting contents or slots of inventories during InventoryCloseEvent (and other similar logic) 2023-03-24 13:31:30 +00:00
Dylan K. Taylor
f978c1e9a0
Merge remote-tracking branch 'origin/stable' into minor-next 2023-03-22 22:45:41 +00:00
Dylan K. Taylor
0b8193aeb3
4.17.2 is next 2023-03-22 22:35:25 +00:00