786 Commits

Author SHA1 Message Date
Dylan K. Taylor
3d9e19546f
EntityShootBowEvent: fixed incorrect field type 2021-12-07 23:35:45 +00:00
Dylan K. Taylor
0c012ca5d9
Replace usages of ItemFactory in tests with VanillaItems 2021-12-06 23:45:36 +00:00
Dylan K. Taylor
1669d33f7e
Updated DevTools submodule to pmmp/DevTools@39510af5bc 2021-12-02 00:58:15 +00:00
Dylan K. Taylor
f239b077b9
Fixed PHPStan complaints 2021-11-30 00:36:38 +00:00
Dylan K. Taylor
52f0c4f3ed
Removed dodgy test using invalid block metadata 2021-11-27 22:51:14 +00:00
Dylan K. Taylor
e2815eed60
BlockFactory: remap a bunch more invalid states 2021-11-27 20:07:58 +00:00
Dylan K. Taylor
932a88764c
composer commands suck 2021-11-27 04:07:25 +00:00
Dylan K. Taylor
9540193766
Fixed everything lighting on fire 2021-11-27 03:54:30 +00:00
Dylan K. Taylor
cc23e0b7a1
Updated DevTools submodule to pmmp/DevTools@6af57741e6 2021-11-27 03:52:32 +00:00
Dylan K. Taylor
1bc7869f6e
Added remapping for almost 4000 invalid blockstates
when a block has sole ownership of an ID, the state bitmask can be ignored and we can just claim the whole metadata range for that single block.
This fixes a large number of issues with unknown blocks on older worlds where world editors did not remove the metadata, although update blocks will currently still appear on initial chunk send due to lack of AOT conversion (TODO).
2021-11-26 01:58:52 +00:00
Dylan K. Taylor
9346ecdc39
Merge branch 'stable' 2021-11-25 00:01:48 +00:00
Dylan K. Taylor
c023c02b6c
MemoryManager: Removed obsolete workaround for $GLOBALS not being defined on threads
this was long since fixed, and everyone has since been forced to upgrade to pthreads 4.0.0, which definitely has the fix.
2021-11-24 23:57:55 +00:00
Dylan K. Taylor
bb7683158f
Remove dead ignoreErrors patterns 2021-11-24 23:52:51 +00:00
Dylan K. Taylor
fad96b77ce
stfu 2021-11-24 23:49:56 +00:00
Dylan K. Taylor
40f8f042da
Merge branch 'stable' 2021-11-24 23:42:53 +00:00
Dylan K. Taylor
adff561483
phpstan: go nuclear on OPcache
when using dynamic reflection (which is the default), any time static reflection comes into play, bad shit starts to happen because of FileReadTrapStreamWrapper.
I attempted to fix these issues (phpstan/phpstan-src#801) and failed miserably.
So, to save the hassle, it's time to just remove OPcache from the picture (which, unfortunately, also means that PHPStan will not benefit from JIT).
2021-11-24 23:40:54 +00:00
Dylan K. Taylor
472ffb28ff
ScriptPluginLoader: use parseDocComment() instead of reinventing the wheel 2021-11-24 17:22:49 +00:00
Dylan K. Taylor
b784a04e08
Utils: fixed parseDocComment() ignoring tags containing hyphens 2021-11-24 16:38:37 +00:00
Dylan K. Taylor
269231c228
Ban foreach(arrayWithStringKeys as k => v)
this is not as good as phpstan/phpstan-src#769 (e.g. array_key_first()/array_key_last() aren't covered by this, nor is array_rand()) but it does eliminate the most infuriating cases where this usually crops up.
2021-11-15 22:52:05 +00:00
Dylan K. Taylor
4c07078586
Merge branch 'stable' 2021-11-08 19:01:08 +00:00
Dylan K. Taylor
eb3530b6e6
Use pmmp/setup-php-action to compile PHP 2021-11-07 23:13:56 +00:00
Dylan K. Taylor
b84f7c18ec
Install ext/crypto from PECL 2021-11-07 19:18:09 +00:00
Dylan K. Taylor
4c3a5fdd73
Clean PHPStan baselines from 1.0.2 2021-11-04 19:28:52 +00:00
Dylan K. Taylor
84f8b3eb2d
Move CrashDump to pocketmine\crash namespace 2021-11-04 19:23:45 +00:00
Dylan K. Taylor
15fca84f3b
remove some PHPStan error patterns 2021-11-04 19:22:49 +00:00
Dylan K. Taylor
c60144210f
Regenerate PHPStan bugs baseline 2021-11-04 19:18:29 +00:00
Dylan K. Taylor
729f831b8f
PHPStan 1.0.2 2021-11-03 20:26:32 +00:00
Dylan K. Taylor
54442f7e4b
Merge branch 'stable' 2021-11-01 21:18:35 +00:00
Dylan K. Taylor
5257755dc5
shut 2021-11-01 21:15:58 +00:00
Dylan K. Taylor
8c16ecaa5b
Merge branch 'stable' 2021-11-01 21:08:32 +00:00
Dylan K. Taylor
3214da8642
pthreads 4.0.0 2021-11-01 21:01:59 +00:00
Dylan K. Taylor
f827a555d5
Merge branch 'stable' 2021-11-01 18:13:24 +00:00
Dylan K. Taylor
794142fe49
Merge l7/l8/l9 baselines into actual-problems
it doesn't serve any practical purpose to keep these separated, particularly since it's getting so difficult to figure out which errors are coming from which levels (since we always use 9, it doesn't really make any difference).
2021-11-01 17:27:31 +00:00
Dylan K. Taylor
ff27c5f7db
PHPStan 1.0.0 2021-11-01 17:24:20 +00:00
Dylan K. Taylor
1873457840
PopulationTask: stop using dynamic properties 2021-10-26 20:21:58 +01:00
Dylan K. Taylor
1d99cd329a
CS again 2021-10-26 00:50:43 +01:00
Dylan K. Taylor
bd8cba1a7f
Added unit tests for Utils::testValidInstance() 2021-10-26 00:49:41 +01:00
Dylan K. Taylor
baba25953f
Chunk: make all parameters of __construct() mandatory and non-nullable
having the constructor fill in defaults for these invariably causes bugs.
2021-10-25 20:22:50 +01:00
Dylan K. Taylor
e50072dc27
Clean PHPStan baselines 2021-10-23 01:55:10 +01:00
Dylan T
a788954551
Fixed dependency handling across plugin loaders (#3971) 2021-10-20 20:22:00 +01:00
Dylan K. Taylor
8db5732b44
Drop respect/validation
it's not worth this turning into compatibility baggage just so that we can parse plugin_list.yml, especially when we have new ways to handle data parsing coming in the pipeline.
For something as small as plugin_list.yml, it's easier (and in this case better too) to just validate it manually (respect/validation was anyway too strict considering it's YAML we're dealing with).
2021-10-15 17:15:46 +01:00
Dylan K. Taylor
48f809d3fa
Removed another dead PHPStan error pattern
this was actually a PHPStan bug fixed in 0.12.99.
2021-10-15 17:01:09 +01:00
Dylan K. Taylor
06e7338ff9
Move exception printing utilities from MainLogger to Utils
where they can be useful to other stuff apart from just the logger
2021-10-14 15:54:20 +01:00
Dylan K. Taylor
b5699679ef
Merge commit 'e38866c4ba90f8efd5630dbe674fd7ca15f586ff' 2021-10-12 23:23:27 +01:00
IceCruelStuff
49c1e4c06e
Implement fletching table (#4501) 2021-10-12 21:21:05 +01:00
Dylan K. Taylor
62f11360ee
Added unit tests for getAddableItemQuantity() 2021-10-11 21:52:27 +01:00
Dylan K. Taylor
974d08efd6
Bump PHP minimum requirement to 8.0
PHPStan failed on 7.4 after updating to 0.12.99, and I figured it was less hassle to just do this than fix the build. In any case, we stopped shipping 7.4 months ago, and warned at 3.22 release that 7.4 support would soon be dropped.
2021-10-09 20:09:42 +01:00
Dylan K. Taylor
e38866c4ba
phpstan 0.12.99 2021-10-09 19:33:43 +01:00
Dylan K. Taylor
2a3a57c519
Enable parsing/emitting .properties without creating a Config object
this is useful when the contents are just going to get passed straight into a model, making Config object redundant anyway.
2021-10-07 20:53:15 +01:00
Dylan K. Taylor
dc2e8e7e8f
ServerConfigGroup: do not assume that values are always bool|string 2021-10-07 20:02:21 +01:00