Dylan K. Taylor
959dd4cbf1
PluginManager: explicitly assume the result of FilesystemIterator arrayification
2020-04-15 12:59:15 +01:00
Dylan K. Taylor
0a3788f9ac
ScriptPluginLoader: properly handle the case where the script itself is somehow missing
...
this won't ever happen during PocketMine runtime, but it might happen if something else tries to use it.
2020-04-15 12:54:45 +01:00
Dylan K. Taylor
cdda74ef93
PluginDescription: use result of phpversion() to check if extension is loaded
...
technically phpstan should account for this with the extension_loaded() check, but it currently doesn't and it's not worth fighting with it when the fix is so simple anyway.
2020-04-15 12:50:53 +01:00
Dylan K. Taylor
bbe428a874
Spawnable: explicitly assume that NBTStream->write() will not return false
...
it will never return false under these circumstances
2020-04-15 12:43:44 +01:00
Dylan K. Taylor
755919c496
SendUsageTask: explicitly assume that json_encode() will not return false
2020-04-15 12:43:05 +01:00
Dylan K. Taylor
88b216a17b
AsyncTask: fix another phpstan level 7 error about wrong types
...
this should really be a dedicated type, but everything done with pthreads sucks.
2020-04-15 12:42:18 +01:00
Dylan K. Taylor
8020912448
AsyncPool: add phpstan array type information to all fields
2020-04-15 12:40:54 +01:00
Dylan K. Taylor
5571ae05b5
AsyncPool: silence a warning about wrong key type
...
getTaskId() returns int|null, although it won't happen after the ID has been set.
2020-04-15 12:40:23 +01:00
Dylan K. Taylor
bc985198a0
Config: do not expect string keys on parseProperties(), because of key casting (PHP sucks)
2020-04-15 12:20:23 +01:00
Dylan K. Taylor
27b2710c56
Config: make phpstan happy for load()
...
currently this will never be reached if the regular exception handler has been set, but it might not be set if the class is used on its own.
2020-04-15 12:18:22 +01:00
Dylan K. Taylor
1755b25808
Utils: make explicit assumption about result of scandir() in recursiveUnlink()
...
TODO: this assumption might be flawed in the case of threading...
2020-04-15 12:13:26 +01:00
Dylan K. Taylor
a78133d0e3
Utils: provide phpstan type information for testValidInstance()
2020-04-15 12:12:18 +01:00
Dylan K. Taylor
a51a16a55c
Utils: silence PHPStan warning about array_combine() result
...
phpstan doesn't account for having 2 arrays of the same size, and even if it did, the size cannot be inferred easily here.
2020-04-15 12:11:13 +01:00
Dylan K. Taylor
099562d582
Utils: assume explicitly that ob_get_contents() will not return false in getReferenceCount() based on context
2020-04-15 12:10:21 +01:00
Dylan K. Taylor
ae76e8f08f
Utils: fix some implicit casts to boolean on result of preg_match_all()
2020-04-15 12:09:10 +01:00
Dylan K. Taylor
42a08e7e4a
Utils: don't assume that callable is only array|string implicitly
...
this should really support closures too, but since it's not used anywhere, I feel OK with this change.
2020-04-15 12:08:33 +01:00
Dylan K. Taylor
b193d9f919
Process: shut up PHPStan about possible float returns on getMemoryUsage and friends
...
this can never actually happen because the given data sources will never have such large numbers, but PHPStan doesn't know this.
2020-04-15 12:07:24 +01:00
Dylan K. Taylor
24d64eedab
Process: make some assumptions about I/O explicit for type safety
2020-04-15 12:05:13 +01:00
Dylan K. Taylor
0c9d16f1ef
Internet: explicitly assume return of curl_exec() is string after error checking
...
this is documented as string|bool, but it's actually string|false if CURLOPT_RETURNTRANSFER is set, and bool if not.
2020-04-15 12:02:38 +01:00
Dylan K. Taylor
d246933e3e
TextFormat: account for failure to encode JSON in toJSON()
2020-04-15 11:29:50 +01:00
Dylan K. Taylor
41d7b8c0e4
TextFormat: properly handle pcre errors in some cases
...
these would previously just hit type errors.
2020-04-15 11:29:04 +01:00
Dylan K. Taylor
2622c34542
Terminal: explicitly assume that fopen(stdin) will not fail
2020-04-15 11:12:03 +01:00
Dylan K. Taylor
5c9419b55c
Timezone: use false checks instead of file existing for static analysis
2020-04-15 10:59:36 +01:00
Dylan K. Taylor
83c40f4502
Timezone: properly account for failure to read timezone file
2020-04-15 10:23:07 +01:00
Dylan K. Taylor
372202b3dc
Utils: use type-safe checks to ensure file validity
...
this gives the same results while keeping phpstan happy.
2020-04-15 10:19:51 +01:00
Dylan K. Taylor
917c744266
Properly handle error conditions in Utils::decodeJWT()
2020-04-15 10:18:02 +01:00
Dylan K. Taylor
2281fe4e67
Account for reflection filename being false (in the case of classes/functions defined by builtins)
2020-04-15 10:15:38 +01:00
Dylan K. Taylor
cf538d83bf
Timezone: shut phpstan up about impossible ini_get() errors
2020-04-15 09:48:20 +01:00
Dylan K. Taylor
7e9c38a9d9
Timezone::parseOffset() returns string|false, not string|bool
2020-04-15 09:47:52 +01:00
Dylan K. Taylor
ccad97727f
UUID: properly account for garbage inputs which aren't valid hexadecimal
...
this would previously throw a TypeError and crash.
2020-04-15 09:44:14 +01:00
Dylan K. Taylor
e3ebf8bb61
Internet::getIP() returns string|false, not string|bool
2020-04-15 09:39:38 +01:00
Dylan K. Taylor
cb6b59a52a
Internet: curl_init() may return false on error (unclear on reasons)
2020-04-15 09:38:39 +01:00
Dylan K. Taylor
53dbbd5f97
Internet: account for socket_create() maybe failing in getInternalIP()
2020-04-15 09:37:17 +01:00
Dylan K. Taylor
51908ec45a
Player: allow provision of a custom cooldown duration for items
...
this would be more useful to plugins, so that it's not necessary to extend any item classes for this trivial purpose.
2020-04-15 09:32:48 +01:00
Dylan K. Taylor
a2543ff80d
Position: add getLevelNonNull()
...
this allows assuming that a position has a valid world in places where it's never expected to not be valid. Since this is the vast majority of usages, it eliminates a lot of possible null-pointer warnings given by static analysers.
TODO: Consider whether we can make Position->getLevel/World use this behaviour out of the box in the next major version.
2020-04-14 11:08:37 +01:00
Dylan K. Taylor
20f3030709
3.11.8 is next
2020-04-14 02:54:41 +01:00
Dylan K. Taylor
3aa58f54dc
Release 3.11.7
3.11.7
2020-04-14 02:54:40 +01:00
Dylan K. Taylor
6e08b622b3
Merge branch 'stable' into next-minor
2020-04-14 01:43:23 +01:00
Dylan K. Taylor
5c12a95151
phpstan: force static reflection for COM class
...
com_dotnet has crap reflection exports and the class name case doesn't match.
2020-04-14 01:43:02 +01:00
Dylan K. Taylor
604900d4c5
Merge branch 'stable' into next-minor
2020-04-14 01:38:01 +01:00
dependabot-preview[bot]
5f07c5df1c
Bump irstea/phpunit-shim from 8.5.2 to 8.5.3 ( #3384 )
2020-04-12 03:40:14 +00:00
Twisted
6422ed7722
Added RakLibInterface::setPacketLimit() ( #3398 )
2020-04-11 23:27:17 +01:00
Dylan K. Taylor
5f33ef35e3
build: allow providing a git hash
2020-04-09 21:13:54 +01:00
Dylan K. Taylor
ec949840b2
Do not crash on failure to decompress region chunks
...
this could happen when a chunk was partially overwritten with one of the same sector size.
2020-04-01 21:30:25 +01:00
Dylan K. Taylor
e45e84b236
Updated composer dependencies
2020-03-31 18:43:30 +01:00
dependabot-preview[bot]
dfe68c9788
Bump phpstan/phpstan from 0.12.17 to 0.12.18 ( #3372 )
...
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan ) from 0.12.17 to 0.12.18.
- [Release notes](https://github.com/phpstan/phpstan/releases )
- [Commits](https://github.com/phpstan/phpstan/compare/0.12.17...0.12.18 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-03-23 15:21:00 +00:00
dependabot-preview[bot]
35b8f0bf25
Bump phpstan/phpstan from 0.12.15 to 0.12.17 ( #3363 )
2020-03-18 13:06:14 +00:00
Dylan K. Taylor
d4dc1c8a0c
AttributeMap: be aware of possible NULL offset in ArrayAccess
...
reported by phpstan 0.12.17
2020-03-18 12:59:01 +00:00
Dylan K. Taylor
517f9a3c3a
Player: fix weapons not taking damage from attacks (bug introduced by #3348 )
2020-03-18 12:51:05 +00:00
Dylan K. Taylor
636c35dcf1
replace daverandom/callback-validator with pocketmine/callback-validator, closes #3359
2020-03-17 12:24:50 +00:00