mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-04-22 00:33:59 +00:00
Code Issues Projects Releases Wiki Activity
9,455 Commits 15 Branches 438 Tags
Commit Graph

187 Commits

Author SHA1 Message Date
Dylan K. Taylor
fffa4b9501 phpstan: baseline our way to level 8 
we really need the level 8 checks on new code now, and waiting until old code is clean is not going to benefit us much because the issues that are there already exist.
 2020-05-18 20:09:25 +01:00
Dylan K. Taylor
a70fa15690 phpstan 0.12.25, drop some bug-filtering error patterns 2020-05-13 12:51:52 +01:00
Dylan T
ef97c8f99e
Utils: fix parsing of single-line doc comments, closes #3388 (#3469) 
* Utils: fix parsing of single-line doc comments, closes #3388

* correctly handle the empty doc-comment case, add another test case

* ignore an extra phpstan bug
 2020-05-06 14:17:08 +01:00
Dylan K. Taylor
6bfc309a0a phpstan 0.12.22 2020-05-04 22:26:44 +01:00
Dylan K. Taylor
b63ad032a9 phpstan 0.12.19 2020-04-26 00:08:41 +01:00
Dylan K. Taylor
4c1b10b24b restructure ignoreErrors to allow regenerating them file by file 2020-04-25 11:59:06 +01:00
Dylan K. Taylor
61dc9d7f6b phpstan: split up phpstan-bugs and phpstan-bugs-generated configs 2020-04-25 11:26:54 +01:00
Dylan K. Taylor
da9731ef59 phpstan: add stub defines to improve analysis 2020-04-25 11:07:05 +01:00
Dylan K. Taylor
7aa8bd18d3 Revert "Item: restrict bounds of count to 0-255" 
This reverts commit 10317527e4012fb1dbb1661f2f7fc33b05a7a6d1.

this breaks user code which exceeds stack limits in legitimate
circumstances. For example, it should be OK to add 6000x diamond to a
player's inventory without being forced to manually split the count up
for addItem().
 2020-02-25 20:42:03 +00:00
Dylan K. Taylor
04581e2700 DataPacket: account for splitscreen header when decoding 2020-02-24 21:20:25 +00:00
Dylan K. Taylor
10317527e4 Item: restrict bounds of count to 0-255 2020-02-23 17:23:53 +00:00
Dylan K. Taylor
681dd469a2 PluginManager: add class-string phpstan param to registerEvent() 2020-02-07 20:05:41 +00:00
Dylan K. Taylor
ada8cbb545 phpstan: drop some ignoreErrors that don't occur on 0.12.9 2020-02-06 21:01:05 +00:00
Dylan K. Taylor
6c7dada232 finally, integrate phpstan-strict-rules 2020-02-06 19:44:10 +00:00
Dylan K. Taylor
a1622fa345 UtilsTest: silence a phpstan-strict-rules warning 2020-02-06 18:53:05 +00:00
Dylan K. Taylor
5ad66c3c9b BlockTest: throw exception instead of always-false assert 2020-02-06 13:21:39 +00:00
Dylan K. Taylor
7885b54824 phpstan: run static analysis on tests 2020-02-06 13:13:12 +00:00
Dylan K. Taylor
532dc0fb6f tests/phpunit: populate iterable types for phpstan 2020-02-06 13:11:56 +00:00
Dylan K. Taylor
e12618c705 tests/phpunit: added missing native typehints 2020-02-06 12:13:42 +00:00
Dylan K. Taylor
4a4c28cd8c travis.sh: ditch PHP_BINARY variable, use PATH prefix instead 
this is how normal people do it ...
 2020-02-03 09:30:43 +00:00
Dylan K. Taylor
4bc2f28c6d Provide a ChunkUtils stub for PHPStan, so it doesn't get confused when the extension is loaded 
for some reason the presence of the type problems were reported as
problems on ChunkUtils.php, despite being outside of the project scope
and the errors not applying to the polyfill.
 2020-02-02 18:12:41 +00:00
Dylan K. Taylor
1f2fb73297 updated DevTools submodule to 1.14.0 2020-02-02 10:21:32 +00:00
Dylan K. Taylor
004f7ef82e phpstan: stub out the iterable bullshit with pthreads 
this isn't a perfect fix, but it's better than it whining about all the things.
 2020-01-30 22:31:15 +00:00
Dylan K. Taylor
89ebd2b880 remove some dead ignoreErrors 2020-01-30 22:30:04 +00:00
Dylan K. Taylor
41d02003c2 Install PHPStan and PHPUnit via dev dependencies 2020-01-27 12:04:42 +00:00
Dylan K. Taylor
156ecd9bd8 travis: use phpstan 0.12.8 2020-01-27 09:31:27 +00:00
Dylan K. Taylor
fa7736efbb phpstan 0.12.7 2020-01-25 17:16:14 +00:00
Dylan K. Taylor
d71a7ff2fa travis.sh: fix indentation 2020-01-25 17:15:37 +00:00
Dylan K. Taylor
5a97c378fc phpstan: green on level 6, minus iterable types 
iterable types are a big pain in the ass because of pthreads' awful architecture, and there's nothing I can do about that without BC-breaking changes to pthreads.
 2020-01-20 17:54:55 +00:00
Dylan K. Taylor
e5d62ec901 phpstan 0.12.6 2020-01-20 17:26:48 +00:00
Dylan K. Taylor
8252bea699 phpstan: enable MissingMethodReturnTypehintRule 
this was a bitch of a job, but it's one step closer to bypassing level 6.
 2020-01-19 19:43:52 +00:00
Dylan K. Taylor
30f2e75278 phpstan 0.12.5 2020-01-12 16:57:43 +00:00
Dylan K. Taylor
2cfc25b4f8 phpstan: enable checkGenericClassInNonGenericObjectType 2020-01-11 23:04:16 +00:00
Dylan K. Taylor
3614d9a78d phpstan: enable MissingMethodParameterTypehintRule 2020-01-11 21:54:42 +00:00
Dylan K. Taylor
8794292788 remove &$var reference notations in phpdoc 
this isn't required by the spec and PHPStan chokes on it. I was previously having it ignore these errors, but it turns out that PHPStan is not making use of extended typeinfo provided if it can't parse the tag, which is problematic on level 6 and also a problem for array-of-type. Therefore, we are going to have to take the hit.
 2020-01-11 21:20:55 +00:00
Dylan K. Taylor
039478223e phpstan: enable MissingFunctionReturnTypehintRule 2020-01-09 20:14:15 +00:00
Dylan K. Taylor
c85f4256c7 phpstan: enable MissingFunctionParameterTypehintRule 2020-01-09 20:10:15 +00:00
Dylan K. Taylor
6dcd2a4ece phpstan: start phasing in some level 6 checks 2020-01-09 19:56:04 +00:00
Dylan K. Taylor
6490a49c70 tests: drop lint.sh - no longer needed now that we have PHPStan 2020-01-04 15:23:53 +00:00
Dylan K. Taylor
5cd7e11b29 Use specialized build script for Travis 2020-01-04 15:15:01 +00:00
Dylan K. Taylor
3e23a568ca phpstan: properly fixing FPs on constant comparisons 2019-12-29 14:25:44 +00:00
Dylan K. Taylor
2de0ec02ba phpstan 0.12.3 2019-12-28 17:22:08 +00:00
Dylan K. Taylor
494660102e Replace empty() usages with count() 2019-12-18 11:23:24 +00:00
Dylan K. Taylor
70c3008b7b phpstan: green on level 4 2019-12-12 13:00:57 +00:00
Dylan K. Taylor
6127a02a8b phpstan 0.12.2 2019-12-12 10:43:45 +00:00
Dylan K. Taylor
7b1ae2a822 phpstan: green on level 3 2019-12-04 22:12:14 +00:00
Dylan K. Taylor
c57eb26fd5 phpstan-bugs: add some extra patterns for level 3 false positives 2019-12-04 19:50:15 +00:00
Dylan K. Taylor
c35d91a104 phpstan: allow blanket ignoreErrors in src to reduce merge work for master 2019-12-04 19:42:18 +00:00
Dylan K. Taylor
73d0f799c2 Update to PHPStan 0.12.0 2019-12-04 10:29:49 +00:00
Dylan K. Taylor
15f8886958 phpstan: separate non-PM bugs from the main neon config 
everything left in here is now a PM problem that needs to be looked into.
 2019-12-01 20:12:41 +00:00