Dylan K. Taylor
345ac75aac
Remove PHPStan rules (no longer needed)
...
this is enforced by php-cs-fixer now instead.
2022-01-20 19:25:34 +00:00
Dylan K. Taylor
2bcb629d78
Scrub baseline
2022-01-20 19:08:44 +00:00
Dylan K. Taylor
8db137882c
Scrub baseline
2022-01-20 16:58:38 +00:00
Dylan K. Taylor
6846f1e78a
Replace disallowed operators in tests/
2022-01-20 16:48:36 +00:00
Dylan K. Taylor
9c328690f8
Baseline for new rules (for now)
2022-01-20 16:46:41 +00:00
Dylan K. Taylor
b60dd1e9b4
Ban 'and' and 'or' operators via PHPStan
2022-01-20 16:44:59 +00:00
Dylan K. Taylor
a0bb7059c1
Merge remote-tracking branch 'origin/stable' into next-minor
2022-01-19 19:48:51 +00:00
Dylan K. Taylor
f1723acfd3
UnsafeForeachArrayOfStringRule: use statically analysable function reference
...
this will ensure that it get automatically updated during refactors.
2022-01-18 00:23:29 +00:00
Dylan K. Taylor
8da27ea0aa
UnsafeForeachArrayOfStringRule: fixed outdated function name
2022-01-18 00:15:44 +00:00
Dylan K. Taylor
ee6548aa50
Merge branch 'stable' into next-minor
2022-01-14 00:45:49 +00:00
Dylan K. Taylor
0a5b146189
substr() returns an empty string instead of false in 8.0
...
an empty string will pass through preg_match_all() without any harmful effects, so we don't need to check for it.
2022-01-07 22:38:00 +00:00
Dylan K. Taylor
1948b00008
Merge branch 'stable' into next-minor
2022-01-07 21:51:05 +00:00
Dylan K. Taylor
b4e1871899
Updated PHPStan baseline
2022-01-07 21:49:49 +00:00
Dylan K. Taylor
dbbbc4f9c9
updated phpstan baseline
2022-01-07 21:39:19 +00:00
Dylan K. Taylor
75fc7a2d1f
Merge branch 'stable' into next-minor
2022-01-07 20:16:35 +00:00
Dylan K. Taylor
6d249026cc
Merge branch 'legacy/pm3' into stable
2022-01-07 20:15:15 +00:00
Dylan K. Taylor
65dabefa3b
Config: improve config loading and parsing error handling
...
closes #4654
closes #3454
2021-12-19 16:53:29 +00:00
Dylan T
fc3a6c6984
Implemented fire spread ( #4617 )
2021-12-16 23:36:34 +00:00
Dylan K. Taylor
5b868e6d5e
Merge branch 'stable' into next-minor
2021-12-08 19:40:25 +00:00
Dylan K. Taylor
889d048ca3
Make use of Utils::assumeNotFalse() in a bunch of places
...
I've stuck to only doing this in the places where I'm sure we should never get false back. Other places I'm less sure of (and I found more bugs along the way).
2021-12-08 19:39:04 +00:00
Dylan K. Taylor
8b73549355
Use JSON_THROW_ON_ERROR for json_encode() and json_decode()
2021-12-08 19:14:07 +00:00
Dylan K. Taylor
3d9e19546f
EntityShootBowEvent: fixed incorrect field type
2021-12-07 23:35:45 +00:00
Dylan K. Taylor
f239b077b9
Fixed PHPStan complaints
2021-11-30 00:36:38 +00:00
Dylan K. Taylor
52a891ba73
shut
2021-11-26 22:32:25 +00:00
Dylan K. Taylor
71b813d4f9
Define pocketmine\BUILD_NUMBER from phar metadata
...
this way we don't have to patch the code (no idea why we were doing that anyway).
2021-11-26 22:27:58 +00:00
Dylan K. Taylor
9346ecdc39
Merge branch 'stable'
2021-11-25 00:01:48 +00:00
Dylan K. Taylor
c023c02b6c
MemoryManager: Removed obsolete workaround for $GLOBALS not being defined on threads
...
this was long since fixed, and everyone has since been forced to upgrade to pthreads 4.0.0, which definitely has the fix.
2021-11-24 23:57:55 +00:00
Dylan K. Taylor
bb7683158f
Remove dead ignoreErrors patterns
2021-11-24 23:52:51 +00:00
Dylan K. Taylor
fad96b77ce
stfu
2021-11-24 23:49:56 +00:00
Dylan K. Taylor
40f8f042da
Merge branch 'stable'
2021-11-24 23:42:53 +00:00
Dylan K. Taylor
adff561483
phpstan: go nuclear on OPcache
...
when using dynamic reflection (which is the default), any time static reflection comes into play, bad shit starts to happen because of FileReadTrapStreamWrapper.
I attempted to fix these issues (phpstan/phpstan-src#801 ) and failed miserably.
So, to save the hassle, it's time to just remove OPcache from the picture (which, unfortunately, also means that PHPStan will not benefit from JIT).
2021-11-24 23:40:54 +00:00
Dylan K. Taylor
472ffb28ff
ScriptPluginLoader: use parseDocComment() instead of reinventing the wheel
2021-11-24 17:22:49 +00:00
Dylan K. Taylor
269231c228
Ban foreach(arrayWithStringKeys as k => v)
...
this is not as good as phpstan/phpstan-src#769 (e.g. array_key_first()/array_key_last() aren't covered by this, nor is array_rand()) but it does eliminate the most infuriating cases where this usually crops up.
2021-11-15 22:52:05 +00:00
Dylan K. Taylor
4c3a5fdd73
Clean PHPStan baselines from 1.0.2
2021-11-04 19:28:52 +00:00
Dylan K. Taylor
84f8b3eb2d
Move CrashDump to pocketmine\crash namespace
2021-11-04 19:23:45 +00:00
Dylan K. Taylor
15fca84f3b
remove some PHPStan error patterns
2021-11-04 19:22:49 +00:00
Dylan K. Taylor
c60144210f
Regenerate PHPStan bugs baseline
2021-11-04 19:18:29 +00:00
Dylan K. Taylor
729f831b8f
PHPStan 1.0.2
2021-11-03 20:26:32 +00:00
Dylan K. Taylor
54442f7e4b
Merge branch 'stable'
2021-11-01 21:18:35 +00:00
Dylan K. Taylor
5257755dc5
shut
2021-11-01 21:15:58 +00:00
Dylan K. Taylor
f827a555d5
Merge branch 'stable'
2021-11-01 18:13:24 +00:00
Dylan K. Taylor
794142fe49
Merge l7/l8/l9 baselines into actual-problems
...
it doesn't serve any practical purpose to keep these separated, particularly since it's getting so difficult to figure out which errors are coming from which levels (since we always use 9, it doesn't really make any difference).
2021-11-01 17:27:31 +00:00
Dylan K. Taylor
ff27c5f7db
PHPStan 1.0.0
2021-11-01 17:24:20 +00:00
Dylan K. Taylor
1873457840
PopulationTask: stop using dynamic properties
2021-10-26 20:21:58 +01:00
Dylan K. Taylor
e50072dc27
Clean PHPStan baselines
2021-10-23 01:55:10 +01:00
Dylan K. Taylor
8db5732b44
Drop respect/validation
...
it's not worth this turning into compatibility baggage just so that we can parse plugin_list.yml, especially when we have new ways to handle data parsing coming in the pipeline.
For something as small as plugin_list.yml, it's easier (and in this case better too) to just validate it manually (respect/validation was anyway too strict considering it's YAML we're dealing with).
2021-10-15 17:15:46 +01:00
Dylan K. Taylor
48f809d3fa
Removed another dead PHPStan error pattern
...
this was actually a PHPStan bug fixed in 0.12.99.
2021-10-15 17:01:09 +01:00
Dylan K. Taylor
06e7338ff9
Move exception printing utilities from MainLogger to Utils
...
where they can be useful to other stuff apart from just the logger
2021-10-14 15:54:20 +01:00
Dylan K. Taylor
b5699679ef
Merge commit 'e38866c4ba90f8efd5630dbe674fd7ca15f586ff'
2021-10-12 23:23:27 +01:00
Dylan K. Taylor
974d08efd6
Bump PHP minimum requirement to 8.0
...
PHPStan failed on 7.4 after updating to 0.12.99, and I figured it was less hassle to just do this than fix the build. In any case, we stopped shipping 7.4 months ago, and warned at 3.22 release that 7.4 support would soon be dropped.
2021-10-09 20:09:42 +01:00
