c19ab97610
AddActorPacket: move BC hack to higher level
...
we shouldn't hack the protocol impl for BC.
2020-02-27 17:37:45 +00:00
04581e2700
DataPacket: account for splitscreen header when decoding
2020-02-24 21:20:25 +00:00
93597dcd50
SkinData: fixed loss of data from packet decode
2020-02-24 20:48:03 +00:00
3cd1da196a
UpdateTradePacket: fix order of fields, closes #3327
2020-02-24 20:16:07 +00:00
1257378198
clean up function imports
2020-02-08 09:31:15 +00:00
25bc95cd1e
removing more unnecessary casts
2020-02-06 19:33:34 +00:00
da3742b39e
Remove useless typecasts
2020-02-06 16:00:57 +00:00
34972c3327
Assume that getmypid() never returns false
...
my background research on this informs me that this returns false on negative PID, which never happens because the underlying C API call never fails - not on linux, bsd, or windows.
2020-02-05 21:00:56 +00:00
1a5228e7a6
Fixed property types with missing null PhpDoc types
2020-02-05 20:55:03 +00:00
495bfda044
Drop a bunch of invalid null defaults
...
phpstan doesn't report these out of the box, for reasons I'm not clear on. It's also not clear if having null defaults has any effect on nullability behaviour, so they are best removed. In addition, these would be problematic on 7.4.
2020-02-05 20:53:54 +00:00
889cd5e206
PlayerNetworkSessionAdapter: clean up leftovers from multi quote support for json decode
2020-02-05 20:45:13 +00:00
fa82cb26d8
added native types to closures (phpstan-strict-rules)
2020-02-05 16:35:10 +00:00
e5a2cfb65f
avoid type juggling in conditions, always use explicit boolean conditions
2020-02-05 15:44:06 +00:00
99038c752c
Avoid usage of for-loop vars outside of for-loop context
...
these problems were reported by PHPStan strict rules. They aren't actually bugs, but they could become bugs in the future.
2020-02-05 13:16:09 +00:00
260ac47588
add some phpstan array types
2020-01-30 22:23:11 +00:00
fc0619ee6e
populate missing array value types in network namespace
2020-01-30 21:12:00 +00:00
259f0425a9
ClientboundMapItemDataPacket: replace assoc array with MapDecoration class
...
I thought I'd done this already, but it appears not.
2020-01-30 20:05:18 +00:00
640df1003c
add some Generator generics for PHPStan
2020-01-29 16:38:50 +00:00
8184a6b114
SkinImage: enforce that height/width must be positive
2020-01-22 14:58:36 +00:00
b8d44ff162
SkinImage: fix formatting error
2020-01-22 14:58:00 +00:00
f624871b3f
strip extra blank lines (php-cs-fixer)
2020-01-22 14:50:29 +00:00
bff5bf25ae
LegacySkinAdapter: make resource patch validity check more robust
2020-01-22 14:36:40 +00:00
c4793241f5
Mass removal of useless @param/@return PHPDoc annotations, pass 1
2020-01-21 15:10:18 +00:00
fffeeddca6
DataPacket: add magic method return types to keep phpstan happy
...
this really shouldn't be necessary, but it is what it is.
2020-01-19 17:14:34 +00:00
b42966f61b
network: explicitly specify @return void
2020-01-18 19:35:01 +00:00
ab57914322
CraftingDataPacket: added native return typehints to private methods
2020-01-18 17:45:15 +00:00
f6d96c5827
DataPacket: clean() returns $this, not void
2020-01-14 17:30:48 +00:00
b1458db47b
Revert "CraftingDataPacket: fixed trying to return void result of parent function"
...
This reverts commit e12ecaf629
2020-01-14 17:16:17 +00:00
2d2c9379cd
DataPacket: apply @return void annotations to make phpstan happy
...
this eliminates 250+ errors on level 6.
2020-01-14 15:39:07 +00:00
3400771770
DataPacket: add missing return type info for pid()
2020-01-14 15:38:24 +00:00
e12ecaf629
CraftingDataPacket: fixed trying to return void result of parent function
2020-01-14 15:37:06 +00:00
17720041a3
phpdoc: populate missing parameter typeinfo
2020-01-11 21:53:24 +00:00
8794292788
remove &$var reference notations in phpdoc
...
this isn't required by the spec and PHPStan chokes on it. I was previously having it ignore these errors, but it turns out that PHPStan is not making use of extended typeinfo provided if it can't parse the tag, which is problematic on level 6 and also a problem for array-of-type. Therefore, we are going to have to take the hit.
2020-01-11 21:20:55 +00:00
1eedac87b2
added missing @var property types (reported by phpstan)
2020-01-09 14:13:54 +00:00
4794ba236a
Revert "resource packs: added new option remove_client_resources, fixed client packs being removed when forcing resource pack download"
...
This reverts commit 06ec8b8397
2020-01-04 16:04:07 +00:00
06ec8b8397
resource packs: added new option remove_client_resources, fixed client packs being removed when forcing resource pack download
2020-01-04 13:16:47 +00:00
216138a37e
PlayerAuthInputPacket: Fix assigning variable in static context
2019-12-17 22:04:24 +08:00
911b6feaf9
NetworkInventoryAction: remove dead code
...
the trading & beacon types need to be checked as well, but I don't have the tools to check that right now.
2019-12-17 11:17:40 +00:00
f7d66613df
CompletedUsingItemPacket: added missing #include, closes #3219
2019-12-13 19:50:40 +00:00
dbca36e5e2
SkinImage: throw on wrong data length
2019-12-11 22:45:14 +00:00
e6c3b0fc0d
Changes for 1.14
...
there are no protocol changes in 1.14 that matter; the reason the protocol version has been bumped is because of new blocks, items, mobs and recipes.
2019-12-11 18:32:22 +00:00
9568364277
fix minor formatting issue in SkinAdapterSingleton
2019-12-09 21:19:15 +00:00
f00c69c513
added missing function imports
2019-12-09 20:13:02 +00:00
50a4c42f3f
NetworkBinaryStream: fix misplaced import
2019-12-09 19:53:32 +00:00
6b61efcfc8
remove unused imports
2019-12-09 19:49:21 +00:00
1a99938e4b
LegacySkinAdapter: clean up nonsensical code ordering
2019-12-09 18:26:20 +00:00
a4d68fb32b
LegacySkinAdapter: fix some wacky cape handling logic
...
I added checks for length validity locally and ran into some interesting behaviour because of this code.
2019-12-09 18:16:46 +00:00
733d530ed0
fixing EOF newlines on new files
2019-12-07 10:08:29 +00:00
c10ce84035
fix invisible legacy skins which have empty geometry names
2019-12-07 10:02:22 +00:00
b6bbf655d7
InventoryTransactionPacket: fixed crafting flags being set on useless empty transactions
...
this fixes some misleading debug noise when getting stuff from creative inventory and triggers some different spam instead.
2019-12-06 20:08:09 +00:00
