mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-22 05:24:39 +00:00
Code Issues Projects Releases Wiki Activity
10,612 Commits 16 Branches 441 Tags
Commit Graph

9526 Commits

Author SHA1 Message Date
Dylan K. Taylor
af6cb605c5 Chunk: fix data loss caused by d3d7709ead3203c189f2ac3b79224b3e5e2bf902 2019-12-08 11:02:40 +00:00
Dylan K. Taylor
7d89f91fea Leaves: fixed decay 
detected by phpstan level 4
 2019-12-04 23:21:01 +00:00
Dylan K. Taylor
48e2473696 Position: mark world field as nullable (equivalent to 39c607cbd5e134a47fa338628d54eea4e45d6bc3) 2019-12-04 22:58:55 +00:00
Dylan K. Taylor
59793d4b68 Player: mark networkSession field as nullable 
while we do null this to break cycles, we also null it for other purposes, and it's null-checked in a few places.
 2019-12-04 22:54:04 +00:00
Dylan K. Taylor
fb78ec1f62 AsyncTask: mark threadLocalStorage static field as nullable 2019-12-04 22:50:30 +00:00
Dylan K. Taylor
908aa20eff EntityFactory: fixed type doc of knownEntities 2019-12-04 22:49:25 +00:00
Dylan K. Taylor
b43bd5fb67 PluginCommand: separate CommandExecutor param 
looking at the code now it's clear that this class combines two jobs into the same class.
closes #3203
 2019-12-04 19:14:52 +00:00
Dylan K. Taylor
2ff25dfbd2 Color: make mix() first parameter mandatory, closes #3204 2019-12-04 18:39:14 +00:00
Dylan K. Taylor
60154d8127 SubChunkIteratorManager: assert type of subchunk to make PHPStan happy 
we know this should be a SubChunk, even though it doesn't.
 2019-12-04 18:26:18 +00:00
Dylan K. Taylor
e35a92d8e8 tile\Banner: fixed bad default value for patterns field 
detected by PHPStan on level 3
 2019-12-04 18:25:08 +00:00
Dylan K. Taylor
117e46f639 LevelDB: fix doc comment handling for deserializeLegacyExtraData() 2019-12-04 11:29:41 +00:00
Dylan K. Taylor
66aa940ed1 Item: fixed foreach doc comment in deserializeCompoundTag() 
detected by PHPStan 0.12.0
 2019-12-04 11:28:59 +00:00
Dylan K. Taylor
dc5d985cf4 Merge branch 'next-minor' 2019-12-04 11:23:30 +00:00
Dylan K. Taylor
e65bc5c3ae Merge branch 'stable' into next-minor 2019-12-04 11:11:29 +00:00
Dylan K. Taylor
ecb2e6e3af PluginManager: remove useless information from softDepend debug 
we don't report the parameter type anywhere else, and since PHP doesn't support overloading, we don't need to.
This fixes PHPStan 0.12 complaints about ReflectionNamedType. I figured this was the best solution instead of adding an extra few lines of code.
 2019-12-04 10:17:25 +00:00
Dylan K. Taylor
7b75b6928d AvailableCommandsPacket: fixed foreach docs 
these probably aren't necessary at all to be honest.
 2019-12-04 10:15:50 +00:00
Dylan K. Taylor
753a8a6937 Event: remove useless @var $this annotations 
we are not in a trait here, the scope is always Event.
 2019-12-04 10:15:04 +00:00
Dylan K. Taylor
bc76b1cafe Server: remove several redundant @var annotations (copy pasta) 
these are all useless because it is implied by the parameter type anyway.
 2019-12-04 10:14:15 +00:00
Dylan K. Taylor
f302517a2d Door: fix deserialization of top flag 
it's not clear what bugs this caused, if any, but nonetheless it is incorrect.
 2019-12-03 21:04:04 +00:00
Dylan K. Taylor
5b91be81cc Entity: rewrite dbbe1f2d5c04059ee9ddad12a0d33fbaea933683 for master 2019-12-03 12:16:10 +00:00
Dylan K. Taylor
5f9ce78814 WorldProviderManager: removed incorrect param doc 
this was used to trick phpstorm, but PHPStan doesn't like it, and it isn't consistently used anyway.
 2019-12-03 12:08:04 +00:00
Dylan K. Taylor
fede6b8234 protocol: fixed static analysis warnings in MetadataProperty::equals() implementations 2019-12-03 12:06:57 +00:00
Dylan K. Taylor
e110ea5aea LoginPacket: fixed param doc for validate() 2019-12-03 11:59:28 +00:00
Dylan K. Taylor
d3d7709ead Merge branch 'next-minor' 2019-12-03 11:55:45 +00:00
Dylan K. Taylor
9a67192f74 Merge branch 'stable' into next-minor 2019-12-03 10:45:51 +00:00
Dylan K. Taylor
dbbe1f2d5c Revert "Entity: remove redundant check from spawnTo()" 
This reverts commit 3028832cd35c53937bb6502f74d3ad53646b12a7.

When I created this commit, I made the flawed assumption that spawnTo()
would not be used by plugins. In addition, I was not aware that there
are some usages of spawnTo() in the core which do not check for chunk
usage, such as in Player->showPlayer().

This caused a collection of problems including memory leaks and crashes
due to disconnecting players not removing their references from viewed
entities.

The reverted commit may be the cause of #3178.
 2019-12-03 10:41:13 +00:00
Dylan K. Taylor
ce27c03774 PlayerChatEvent: fixed crash when non-CommandSender permissibles subscribe to broadcast permission 
doing such a thing doesn't make any sense, but the system allows it, so it has to be accounted for.
 2019-12-01 21:44:13 +00:00
Dylan K. Taylor
c4a8781b5c Fixed doc type inconsistencies surrounding chat broadcast handling (several problems that are all related) 2019-12-01 21:40:11 +00:00
Dylan K. Taylor
dbab8b5733 Level: fixed type doc of tickRateTime field 2019-12-01 21:21:42 +00:00
Dylan K. Taylor
2b08bbc7b1 Server: fixed type doc comment of nextTick field 2019-12-01 21:18:20 +00:00
Dylan K. Taylor
17037f5e9c Chunk: clean up nonsensical code in initChunk() 
I have no idea why the extra check was there, or why the null assignment was used, because it doesn't make any sense.
 2019-12-01 21:14:23 +00:00
Dylan K. Taylor
fee3c17148 CraftingManager: fixed type doc of craftingDataCache field 2019-12-01 21:06:34 +00:00
Dylan K. Taylor
25e6cb74b3 Squid: fixed type doc comment of swimDirection field 2019-12-01 21:06:03 +00:00
Dylan K. Taylor
8d2e59222e Entity: fixed not calculating surrounding blocks on entity creation 
it's unclear if this was actually causing any bugs, but if it was it would likely manifest in the form of, for example, not burning in lava.
 2019-12-01 21:05:36 +00:00
Dylan K. Taylor
cd778661c2 Entity: fixed type doc comment for blocksAround field 2019-12-01 21:03:57 +00:00
Dylan K. Taylor
c2afc05e7c Entity: fix type doc comment for static knownEntities field 2019-12-01 21:03:29 +00:00
Dylan K. Taylor
9be95bf263 Block: return [] instead of null in getMetadata() (return type is non-nullable) 2019-12-01 21:02:49 +00:00
Dylan K. Taylor
4b65e1cbe1 Command: fix type doc comment for commandMap field 2019-12-01 21:01:57 +00:00
Dylan K. Taylor
5caae37768 Server: fixed return type doc comment for getCommandAliases() 2019-12-01 21:00:49 +00:00
Dylan K. Taylor
92e1811b06 DataPacket: fixed bad null assignment to buffer in clean() 
this is never expected to be null, so implicitly relies on PHP magic behaviour to convert it to string when appended.
 2019-12-01 20:36:56 +00:00
Dylan K. Taylor
293c2710d0 PlayerCreationEvent: fixed doc comments for baseClass and playerClass fields 2019-12-01 20:19:59 +00:00
Dylan K. Taylor
8a7017fd6b Enchantment: fixed doc comment for static enchantments field 2019-12-01 20:16:45 +00:00
Dylan K. Taylor
1a1e3ff63b BaseInventory: fixed incorrect & redundant default value for slots field 2019-12-01 19:45:16 +00:00
Dylan K. Taylor
0890b5fc99 AsyncPool: assert() that the unstacked task is actually an AsyncTask 
it's possible that it might not be if the workers were accessed directly, but that shouldn't be possible.
This also silences a PHPStan warning on level 2.
 2019-12-01 19:28:05 +00:00
Dylan K. Taylor
163ed225f2 NetworkBinaryStream: fixed crash when non-compound root tag is provided for itemstack 2019-12-01 18:41:02 +00:00
Dylan K. Taylor
a4a6d3e094 PlayerCreationEvent: fixed illegal doc comment types 2019-12-01 18:08:25 +00:00
Dylan K. Taylor
ecbf3e9722 GamemodeCommand: fix CommandSender assignment causing troubles for type inference on static analyzers 
this would never crash, but in strongly typed code it would be a compile failure.
 2019-12-01 09:33:12 +00:00
Dylan K. Taylor
47a959dace block: fix some possible crashes when plugins overwrite tile classes in bad ways 
phpstan was complaining on level 2, and it's not wrong to ...
 2019-12-01 09:29:22 +00:00
Dylan K. Taylor
6d109bfc6f CraftingDataPacket: fixed not retaining cleanRecipes during decode 2019-11-30 21:15:37 +00:00
Dylan K. Taylor
42d8357821 AvailableCommandsPacket: fixed missing decoded overloads with 0 arguments 
these should be listed even if they have 0 arguments
 2019-11-30 11:58:29 +00:00