Dylan K. Taylor
20dad95755
Liquid: don't try to flow out of the world, close #2510
...
this fix is only required for master, although it could be backported.
2018-11-14 17:48:14 +00:00
Dylan T
5d7feaaf21
Remove EventExecutor, event handlers now use closures ( #2525 )
...
This cleans up some cargo-cult code poorly copied from Bukkit, which has negative performance effects and also makes internal event handling more complex than necessary.
## API changes
- Removed `EventExecutor` and `MethodEventExecutor`.
- A listener is no longer required for an event handler to be registered. Closure objects can now be used directly provided that they meet the conditions for registration.
- `PluginManager->registerEvent()` signature has changed: the `Listener` and `EventExecutor` parameters have been removed and a `\Closure $handler` has been added in its place.
- `RegisteredListener` now requires a `Closure` parameter instead of `Listener, EventExecutor`.
## Behavioural changes
These changes reduce the execution complexity involved with calling an event handler. Since event calls can happen in hot paths, this may have visible positive effects on performance.
Initial testing reveals a performance improvement of ~15% per event handler call compared to the old method.
2018-11-13 21:04:47 +00:00
Dylan K. Taylor
ddef7bb09b
Merge branch 'master' of https://github.com/pmmp/pocketmine-mp
2018-11-13 18:31:34 +00:00
Dylan K. Taylor
3fb8029dff
Merge branch 'release/3.4'
2018-11-13 18:25:03 +00:00
Dylan K. Taylor
554c029fbd
Merge branch 'release/3.3' into release/3.4
2018-11-13 18:24:08 +00:00
Dylan K. Taylor
e018311e73
Make start script errors a bit more noob-friendly
2018-11-13 18:23:54 +00:00
Twisted
3c86944a7c
Item: make addEnchantment(), removeEnchantment() and removeEnchantments() fluent ( #2523 )
2018-11-13 16:48:13 +00:00
Dylan K. Taylor
45caec874e
Merge branch 'release/3.4'
2018-11-12 22:18:28 +00:00
Dylan K. Taylor
de50f02076
Merge branch 'release/3.3' into release/3.4
2018-11-12 22:07:22 +00:00
Dylan K. Taylor
71d02e5870
Improve dev build error messages
2018-11-12 22:07:14 +00:00
Dylan K. Taylor
3031128520
Merge branch 'release/3.4'
2018-11-11 19:52:05 +00:00
Dylan K. Taylor
46d9475568
Use Utils::getNiceClosureName() in PluginManager
2018-11-11 19:50:07 +00:00
Dylan K. Taylor
788b278fc3
Utils: fixed handling of non-anonymous closure functions
2018-11-11 19:43:00 +00:00
Dylan K. Taylor
e16171e37e
Merge branch 'release/3.4'
2018-11-11 12:39:01 +00:00
Dylan K. Taylor
2e4143f57e
Merge branch 'release/3.3' into release/3.4
2018-11-11 12:38:53 +00:00
Dylan K. Taylor
d312aef1ac
3.3.3 is next
2018-11-11 11:58:51 +00:00
Dylan K. Taylor
200de3fe84
Release 3.3.2
3.3.2
2018-11-11 11:58:25 +00:00
Dylan K. Taylor
f560a6efea
Merge tag '3.2.7' into release/3.3
2018-11-11 11:24:23 +00:00
Dylan K. Taylor
7ecd7fd13f
Release 3.2.7
3.2.7
2018-11-11 11:23:20 +00:00
Dylan K. Taylor
95bf3ab7a8
Merge branch 'release/3.4'
2018-11-11 11:15:54 +00:00
Dylan K. Taylor
5284ad0346
Merge branch 'release/3.3' into release/3.4
2018-11-11 11:15:46 +00:00
Dylan K. Taylor
b893645a81
Merge branch 'release/3.2' into release/3.3
2018-11-11 11:15:39 +00:00
Dylan K. Taylor
b19b3134ad
PluginManager: reduce unnecessary indentation
2018-11-11 11:15:27 +00:00
Dylan K. Taylor
2965109484
Merge branch 'release/3.4'
2018-11-10 22:37:17 +00:00
Dylan K. Taylor
7cf36f460b
Merge branch 'release/3.3' into release/3.4
2018-11-10 22:37:08 +00:00
Dylan K. Taylor
243f86b0a0
Merge branch 'release/3.2' into release/3.3
2018-11-10 22:37:02 +00:00
Dylan K. Taylor
9156cbc269
PluginManager: Make registerEvents() check order more logical
...
Prioritize validating that the function is actually a handler, before trying to parse its doc comment.
2018-11-10 22:36:46 +00:00
Dylan K. Taylor
3a6af3327f
Encapsulate plugin.yml commands handling inside PluginBase, removed CommandExecutor requirement from Plugin interface
...
This removes the need for custom Plugin implementations to implement onCommand().
In the future it's planned to remove plugin.yml commands completely and have them registered similarly to how events are handled.
2018-11-09 19:50:52 +00:00
Dylan K. Taylor
8b9ec5dde3
Merge branch 'release/3.4'
2018-11-07 22:11:27 +00:00
Dylan K. Taylor
a5f776af2f
Merge branch 'release/3.3' into release/3.4
2018-11-07 22:11:13 +00:00
Dylan K. Taylor
43fe6a1934
Merge branch 'release/3.2' into release/3.3
2018-11-07 20:02:28 +00:00
Dylan K. Taylor
342a74ffcb
Level: Collect garbage from chunk internals in doChunkGarbageCollection()
2018-11-07 20:01:07 +00:00
Dylan K. Taylor
0b03e3c95b
Update dependencies, fix travis failure
2018-11-05 21:20:42 +00:00
Dylan K. Taylor
67a5f3f557
Register MainLogger as SPL global, remove hard MainLogger dependency from many areas, break a bunch of cyclic dependencies
2018-11-05 19:01:59 +00:00
Dylan K. Taylor
ed8569a3f4
Remove Collectable class, fix memory leak on AsyncTask fatal error
2018-11-05 17:26:22 +00:00
Dylan K. Taylor
c201a0e909
Move language submodule to resources/
...
again, this isn't source code.
2018-11-05 09:49:21 +00:00
Dylan K. Taylor
ce7718f0d1
Move resources/ directory out of src/
...
this isn't source code and as such doesn't belong in here.
2018-11-05 09:46:43 +00:00
Dylan K. Taylor
2a5ab1f397
Merge branch 'release/3.4'
2018-11-04 23:33:10 +00:00
Dylan K. Taylor
3d2701e775
Merge branch 'release/3.3' into release/3.4
2018-11-04 23:32:56 +00:00
Dylan K. Taylor
2183bf875c
Merge remote-tracking branch 'origin/release/3.2' into release/3.3
2018-11-04 23:32:33 +00:00
Dylan T
8cc2a4ce5d
Remove start script support for source-code installations ( #2495 )
...
This was suggested recently by @TheDeibo. We don't want users running source-code installations unless they are developers, and developers should know how to boot a source-code installation anyway.
2018-11-04 23:31:57 +00:00
Dylan K. Taylor
6437078c8b
TaskScheduler: remove deprecated constructor parameter
2018-11-04 23:30:04 +00:00
Dylan K. Taylor
0028ce0ed2
Merge branch 'release/3.4'
2018-11-04 23:25:05 +00:00
Dylan K. Taylor
e26af3fa1b
TaskScheduler: don't catch unexpected exceptions
...
this means that errors in scheduled tasks which are uncaught will now cause a server crash.
2018-11-04 23:22:30 +00:00
Dylan K. Taylor
1634dd62e3
Don't catch unexpected exceptions during command execution
2018-11-04 23:11:51 +00:00
Dylan K. Taylor
2a43d9ecb6
Merge remote-tracking branch 'origin/release/3.4'
2018-11-04 22:56:03 +00:00
Dylan T
755db3dac8
Added a ClosureTask implementation for easier task scheduling ( #2497 )
2018-11-04 22:55:40 +00:00
Dylan K. Taylor
3dabf90b0e
Merge branch 'release/3.3' into release/3.4
2018-11-04 22:38:58 +00:00
Dylan K. Taylor
f61e14e341
Merge branch 'release/3.2' into release/3.3
2018-11-04 22:38:45 +00:00
Dylan K. Taylor
7b24fbc8db
Utils: fix a mistake in getNiceClassName() doc
2018-11-04 22:38:38 +00:00