a2543ff80d
Position: add getLevelNonNull()
...
this allows assuming that a position has a valid world in places where it's never expected to not be valid. Since this is the vast majority of usages, it eliminates a lot of possible null-pointer warnings given by static analysers.
TODO: Consider whether we can make Position->getLevel/World use this behaviour out of the box in the next major version.
2020-04-14 11:08:37 +01:00
3907a2b6ba
Process: split getMemoryUsage() into 2 functions
...
this isn't released yet so it's OK to change.
phpstan level 7 doesn't like these kinds of ambiguous return types because there's no way for it to tell which type is returned without a return type specifying extension, and it's easier to just change the API than to make PHPStan understand it.
2020-03-13 17:32:17 +00:00
19bd283807
Process: drop a blank line
2020-02-10 12:23:11 +00:00
20d1a048dd
fixup imports
2020-02-10 12:21:56 +00:00
15b76a24b7
scrub useless phpdoc
2020-02-10 12:21:07 +00:00
f08e411cad
Merge branch 'stable' into next-minor
2020-02-10 11:40:08 +00:00
79acaa3253
Utils: remove useless typecasts
2020-02-06 16:06:58 +00:00
41b1fa7b48
Config: clean up inconsistent data parsing & handling
2020-02-05 20:50:36 +00:00
fa82cb26d8
added native types to closures (phpstan-strict-rules)
2020-02-05 16:35:10 +00:00
e5a2cfb65f
avoid type juggling in conditions, always use explicit boolean conditions
2020-02-05 15:44:06 +00:00
260ac47588
add some phpstan array types
2020-01-30 22:23:11 +00:00
d3021c6281
populate missing array value types in utils namespace, pass 2
2020-01-30 21:39:15 +00:00
da43ae82fe
populate missing array value types in utils namespace, pass 1
2020-01-30 21:30:01 +00:00
9cdea43794
provide more array type information for Internet functions
2020-01-29 20:45:03 +00:00
e007fad5b8
fix return types for Utils/Internet getURL()/postURL()
2020-01-29 20:43:09 +00:00
5cf2fcbbb7
simpleCurl() second return value is string[][], not string[]
2020-01-29 20:38:19 +00:00
9e6cbb5b6a
Internet: fix type information for getURL(), postURL() and simpleCurl()
2020-01-29 20:20:52 +00:00
2b402e525a
add some PHPStan-specific callable prototypes
2020-01-29 15:03:55 +00:00
f624871b3f
strip extra blank lines (php-cs-fixer)
2020-01-22 14:50:29 +00:00
9cd6b3e1c7
fix remaining multiline @var annotations
2020-01-22 14:44:36 +00:00
9f44adf04a
pass 2, manual removal of incorrect non-nullable @param for nullable native types
2020-01-21 15:44:34 +00:00
c4793241f5
Mass removal of useless @param/@return PHPDoc annotations, pass 1
2020-01-21 15:10:18 +00:00
0b9d0f3cdc
utils: populate missing return type information
2020-01-19 17:07:48 +00:00
f16a530849
MainLogger: add native return types to private functions
2020-01-18 17:47:38 +00:00
7137b8a8a4
Config: added native void return types to private functions
2020-01-18 17:46:25 +00:00
bac788fd00
Timezone: add missing return type for detectSystemTimezone()
2020-01-15 20:18:35 +00:00
1303cbfe02
UUID: add some missing return type annotations
2020-01-14 15:35:46 +00:00
ad4a211cba
Color: add missing return type annotation for fromABGR()
2020-01-14 15:35:14 +00:00
17720041a3
phpdoc: populate missing parameter typeinfo
2020-01-11 21:53:24 +00:00
8794292788
remove &$var reference notations in phpdoc
...
this isn't required by the spec and PHPStan chokes on it. I was previously having it ignore these errors, but it turns out that PHPStan is not making use of extended typeinfo provided if it can't parse the tag, which is problematic on level 6 and also a problem for array-of-type. Therefore, we are going to have to take the hit.
2020-01-11 21:20:55 +00:00
0a39e580e9
MainLogger: log exception chains in logException(), closes #2447
...
this method is simpler than #2447 and easier to apply to stable.
2020-01-09 21:01:12 +00:00
c4580dd56d
MainLogger: extract a printErrorMessage() function from logException()
2020-01-09 20:51:13 +00:00
fab81d28bc
MainLogger: always log exceptions with CRITICAL level
...
if we reached this point, it's almost always due to a general exception handler which doesn't know what else to do with the error.
2020-01-09 20:44:21 +00:00
1eedac87b2
added missing @var property types (reported by phpstan)
2020-01-09 14:13:54 +00:00
ee08286eca
moved git hash detection code to its own unit
2020-01-02 21:01:31 +00:00
9cbe378e8c
Timezone: fix possible crash on CentOS
2019-12-18 11:23:24 +00:00
494660102e
Replace empty() usages with count()
2019-12-18 11:23:24 +00:00
1a467420e3
Merge branch 'stable' into next-minor
2019-12-12 13:07:02 +00:00
73d4ff6b52
more missed function imports
2019-12-09 21:16:35 +00:00
02fcfcc383
Merge branch 'stable' into next-minor
2019-12-09 10:47:53 +00:00
9159e8f002
MainLogger: mark static logger field as nullable
2019-12-05 15:48:58 +00:00
0591458ef6
Merge branch 'stable' into next-minor
2019-10-22 18:49:22 +01:00
305c63ba4d
MainLogger: initialize shutdown field in the conventional manner
...
this avoids uninitialized uses
2019-10-22 10:21:17 +01:00
348c2a599b
Internet: report PM version in user agent
...
this is useful for statistics
2019-10-04 10:59:32 +01:00
bb048fb361
Merge branch 'stable' into next-minor
2019-07-26 19:50:17 +01:00
622f93df45
remove usages of deprecated {} string access, closes #3035
2019-07-22 16:39:33 +01:00
7fc45bc5c3
partial fix for #2986
2019-07-04 18:18:42 +01:00
7b98d203f4
Merge branch 'stable' into next-minor
2019-06-16 14:47:01 +01:00
dbf4054b1f
backport 209135492: UUID: add type docs
2019-06-16 14:44:13 +01:00
82e4ef6d48
backport d8c81c0a1: UUID: remove useless default values
...
these are overwritten by the constructor, so they have no use here.
2019-06-16 14:43:28 +01:00
