Dylan K. Taylor
84ec8b7abe
Removed dead error patterns
...
I do think these are PHPStan bugs, since the trait should inherit the parent class's doc comment
But for the sake of catching more bugs, these doc comments have been manually added anyway.
2025-01-06 23:02:18 +00:00
Dylan K. Taylor
357dfb5c7e
Fixed build
2025-01-06 23:01:14 +00:00
Dylan K. Taylor
0358b7dce4
utils: avoid weak comparisons
2025-01-06 22:53:35 +00:00
Dylan K. Taylor
97c5902ae2
Internet: make postURL() error reporting behaviour more predictable
...
err is now always set to null when doing a new operation.
previously, if the same var was used multiple times and a previous one failed,
code might think that a previous error belonged to the current operation.
2025-01-06 22:52:05 +00:00
Dylan K. Taylor
9a130bce32
Config: remove bad assumptions about string root keys
...
these could just as easily be integers and the code should still work.
2025-01-06 22:50:25 +00:00
Dylan K. Taylor
20849d6268
Fixed potential crashes in type ID tests
...
if the constants had any non-stringable values, these would blow up.
this would still be fine in the sense that the tests would fail, but better that they fail gracefully if possible.
2025-01-06 22:48:22 +00:00
Dylan K. Taylor
b6bd3ef30c
Improve PHPDocs in world package
2025-01-06 22:46:16 +00:00
Dylan K. Taylor
c5a1c15389
TimingsCommand: beware crash on invalid timings server response
2025-01-06 22:44:17 +00:00
Dylan K. Taylor
e30ae487dc
SimpleCommandMap: ensure we always pass a list to Command::setAliases()
...
some offsets may have been removed if the alias failed to be registered.
2025-01-06 22:44:17 +00:00
Dylan K. Taylor
59f6c85105
Command: mark execute $args as being list<string>
2025-01-06 22:44:17 +00:00
Dylan K. Taylor
90f0b85d2e
Eliminate weak comparisons in entity package
...
Weak comparisons were used in cases when we were worried about comparing int and float.
In some cases (particularly involving Vector3) we do need to be wary of this, so floatval() is used to avoid incorrect type comparisons.
In other cases, we were already exclusively comparing float-float, so weak compare wasn't needed anyway.
2025-01-06 22:44:17 +00:00
Dylan K. Taylor
8ee70b209e
MemoryDump: fix PHPDoc types
2025-01-06 22:44:16 +00:00
Dylan K. Taylor
5c905d9a95
BlockBreakInfo: use strict comparison
...
weak compare isn't needed here since this can be float/float
2025-01-06 22:44:16 +00:00
Dylan K. Taylor
8b23231537
Fixup PHPDoc for blocks
2025-01-06 22:44:16 +00:00
pmmp-admin-bot[bot]
3f7f11b812
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12615442245
2025-01-05 01:37:23 +00:00
pmmp-admin-bot[bot]
8e039f2711
Merge 'stable' into 'minor-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12615442245
2025-01-05 01:37:22 +00:00
dependabot[bot]
4a4572131f
Bump shivammathur/setup-php in the github-actions group ( #6591 )
2025-01-04 22:26:14 +00:00
pmmp-admin-bot[bot]
984e995659
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12606221104
2025-01-04 01:22:34 +00:00
Dylan K. Taylor
3da0b82b86
Merge branch 'stable' into minor-next
2025-01-03 19:26:45 +00:00
Dylan K. Taylor
da62eb9f33
...
2025-01-03 19:26:24 +00:00
pmmp-admin-bot[bot]
46604b26f2
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12510342531
2024-12-27 01:23:48 +00:00
pmmp-admin-bot[bot]
09c434983b
Merge 'stable' into 'minor-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12510342531
2024-12-27 01:23:47 +00:00
dependabot[bot]
fbaa125d0c
Bump build/php from 9728fa5 to 56cec11 ( #6588 )
...
Bumps [build/php](https://github.com/pmmp/php-build-scripts ) from `9728fa5` to `56cec11`.
- [Release notes](https://github.com/pmmp/php-build-scripts/releases )
- [Commits](9728fa57f7...56cec11745
2024-12-26 12:36:17 +00:00
pmmp-admin-bot[bot]
6b2fb9c4f8
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12498201064
2024-12-26 01:23:26 +00:00
pmmp-admin-bot[bot]
6ad9dde43d
Merge 'stable' into 'minor-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12498201064
2024-12-26 01:23:25 +00:00
dependabot[bot]
d634a5fa3d
Bump build/php from b1eaaa4 to 9728fa5 ( #6587 )
...
Bumps [build/php](https://github.com/pmmp/php-build-scripts ) from `b1eaaa4` to `9728fa5`.
- [Release notes](https://github.com/pmmp/php-build-scripts/releases )
- [Commits](b1eaaa48ec...9728fa57f7
2024-12-25 13:06:46 +00:00
pmmp-admin-bot[bot]
80b761627a
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12487960388
2024-12-25 01:23:10 +00:00
pmmp-admin-bot[bot]
8cea4c13c4
Merge 'stable' into 'minor-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12487960388
2024-12-25 01:23:09 +00:00
Dylan T.
dc2e82df7f
crash.yml: add field ID for crash archive "report github issue" button
2024-12-24 16:37:18 +00:00
Dylan K. Taylor
debf8d18fc
Upgrade issue templates
2024-12-24 16:27:40 +00:00
Dylan K. Taylor
81e3730b99
Fixed crashes containing PHP internal stack frames being flagged as plugin-caused
2024-12-24 14:20:16 +00:00
pmmp-admin-bot[bot]
882d8c4ab9
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12475368381
2024-12-24 01:24:08 +00:00
Dylan K. Taylor
8a5eb71432
ChunkCache: track strings in cache directly instead of CompressBatchPromise
...
this reduces memory footprint slightly, but more importantly reduces GC workload.
Since it also reduces the work done on cache hit, it might *slightly* improve performance,
but any improvement is likely to be minimal.
2024-12-23 21:04:33 +00:00
pmmp-admin-bot[bot]
1c35987ead
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12450134566
2024-12-22 01:37:17 +00:00
Dylan K. Taylor
306623e890
FormatConverter: do periodic GC
...
this reduces the risk of OOM during conversion of large worlds
we probably ought to limit the size of region caches for regionized worlds, but that's a problem for another time.
2024-12-21 17:49:03 +00:00
Dylan K. Taylor
ada3acdba4
FormatConverter: ensure we don't get stalled due to stdout buffer flood
...
this can happen due to very noisy outputs during conversion, e.g. if there were many unknown blocks.
2024-12-21 17:49:03 +00:00
Dylan K. Taylor
6a1d80e021
tools/convert-world: fixed some UI issues
2024-12-21 17:49:02 +00:00
pmmp-admin-bot[bot]
88ae00fc4d
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12440895736
2024-12-21 01:22:55 +00:00
pmmp-admin-bot[bot]
1ff0988e75
Merge 'stable' into 'minor-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12440895736
2024-12-21 01:22:54 +00:00
dependabot[bot]
506cfe0362
Bump build/php from 5016e0a to b1eaaa4 ( #6579 )
...
Bumps [build/php](https://github.com/pmmp/php-build-scripts ) from `5016e0a` to `b1eaaa4`.
- [Release notes](https://github.com/pmmp/php-build-scripts/releases )
- [Commits](5016e0a3d5...b1eaaa48ec
2024-12-20 10:39:39 +00:00
pmmp-admin-bot[bot]
47a1aa6470
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12423751811
2024-12-20 01:24:32 +00:00
Dylan K. Taylor
fea17fa4a9
RakLibServer: disable GC
...
GC is not required for RakLib as it doesn't generate any unmanaged cycles.
Cycles in general do exist (e.g. Server <-> ServerSession), but these are
explicitly cleaned up, so GC wouldn't have any useful work to do.
2024-12-19 20:33:40 +00:00
Dylan K. Taylor
3e69ee87e4
Remove deprecated stuff
...
except Permission subscriptions; turns out we still need those
perhaps they should be marked @internal
2024-12-19 00:14:18 +00:00
pmmp-admin-bot[bot]
a2a2ec9d8b
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12364667325
2024-12-17 01:39:12 +00:00
Dylan T.
aee358d329
This timings handler management is a crap design
...
This has bitten me on the ass so many times now
2024-12-16 03:11:07 +00:00
pmmp-admin-bot[bot]
3a0f15ef0d
Merge 'minor-next' into 'major-next'
...
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12344337356
2024-12-16 01:42:31 +00:00
Dylan K. Taylor
80899ea72c
Make sure timings are counted under the proper parents
2024-12-15 21:34:16 +00:00
Dylan K. Taylor
42f90e94ff
AsyncWorker now manually triggers GC at the end of each task run, similar to the main thread
...
this avoids costly GC runs during hot code.
2024-12-15 21:25:32 +00:00
Dylan K. Taylor
8f536e6f21
always the CS
2024-12-15 20:46:10 +00:00
Dylan K. Taylor
45482e868d
Fixed AsyncWorker GC not getting re-enabled after memory dump
...
async workers still use automatic GC for now. We should probably switch to manual GC at some point, but it's not a priority right now.
2024-12-15 20:45:51 +00:00
