bc985198a0
Config: do not expect string keys on parseProperties(), because of key casting (PHP sucks)
2020-04-15 12:20:23 +01:00
27b2710c56
Config: make phpstan happy for load()
...
currently this will never be reached if the regular exception handler has been set, but it might not be set if the class is used on its own.
2020-04-15 12:18:22 +01:00
1755b25808
Utils: make explicit assumption about result of scandir() in recursiveUnlink()
...
TODO: this assumption might be flawed in the case of threading...
2020-04-15 12:13:26 +01:00
a78133d0e3
Utils: provide phpstan type information for testValidInstance()
2020-04-15 12:12:18 +01:00
a51a16a55c
Utils: silence PHPStan warning about array_combine() result
...
phpstan doesn't account for having 2 arrays of the same size, and even if it did, the size cannot be inferred easily here.
2020-04-15 12:11:13 +01:00
099562d582
Utils: assume explicitly that ob_get_contents() will not return false in getReferenceCount() based on context
2020-04-15 12:10:21 +01:00
ae76e8f08f
Utils: fix some implicit casts to boolean on result of preg_match_all()
2020-04-15 12:09:10 +01:00
42a08e7e4a
Utils: don't assume that callable is only array|string implicitly
...
this should really support closures too, but since it's not used anywhere, I feel OK with this change.
2020-04-15 12:08:33 +01:00
b193d9f919
Process: shut up PHPStan about possible float returns on getMemoryUsage and friends
...
this can never actually happen because the given data sources will never have such large numbers, but PHPStan doesn't know this.
2020-04-15 12:07:24 +01:00
24d64eedab
Process: make some assumptions about I/O explicit for type safety
2020-04-15 12:05:13 +01:00
0c9d16f1ef
Internet: explicitly assume return of curl_exec() is string after error checking
...
this is documented as string|bool, but it's actually string|false if CURLOPT_RETURNTRANSFER is set, and bool if not.
2020-04-15 12:02:38 +01:00
d246933e3e
TextFormat: account for failure to encode JSON in toJSON()
2020-04-15 11:29:50 +01:00
41d7b8c0e4
TextFormat: properly handle pcre errors in some cases
...
these would previously just hit type errors.
2020-04-15 11:29:04 +01:00
2622c34542
Terminal: explicitly assume that fopen(stdin) will not fail
2020-04-15 11:12:03 +01:00
5c9419b55c
Timezone: use false checks instead of file existing for static analysis
2020-04-15 10:59:36 +01:00
83c40f4502
Timezone: properly account for failure to read timezone file
2020-04-15 10:23:07 +01:00
372202b3dc
Utils: use type-safe checks to ensure file validity
...
this gives the same results while keeping phpstan happy.
2020-04-15 10:19:51 +01:00
917c744266
Properly handle error conditions in Utils::decodeJWT()
2020-04-15 10:18:02 +01:00
2281fe4e67
Account for reflection filename being false (in the case of classes/functions defined by builtins)
2020-04-15 10:15:38 +01:00
cf538d83bf
Timezone: shut phpstan up about impossible ini_get() errors
2020-04-15 09:48:20 +01:00
7e9c38a9d9
Timezone::parseOffset() returns string|false, not string|bool
2020-04-15 09:47:52 +01:00
ccad97727f
UUID: properly account for garbage inputs which aren't valid hexadecimal
...
this would previously throw a TypeError and crash.
2020-04-15 09:44:14 +01:00
e3ebf8bb61
Internet::getIP() returns string|false, not string|bool
2020-04-15 09:39:38 +01:00
cb6b59a52a
Internet: curl_init() may return false on error (unclear on reasons)
2020-04-15 09:38:39 +01:00
53dbbd5f97
Internet: account for socket_create() maybe failing in getInternalIP()
2020-04-15 09:37:17 +01:00
a2543ff80d
Position: add getLevelNonNull()
...
this allows assuming that a position has a valid world in places where it's never expected to not be valid. Since this is the vast majority of usages, it eliminates a lot of possible null-pointer warnings given by static analysers.
TODO: Consider whether we can make Position->getLevel/World use this behaviour out of the box in the next major version.
2020-04-14 11:08:37 +01:00
3907a2b6ba
Process: split getMemoryUsage() into 2 functions
...
this isn't released yet so it's OK to change.
phpstan level 7 doesn't like these kinds of ambiguous return types because there's no way for it to tell which type is returned without a return type specifying extension, and it's easier to just change the API than to make PHPStan understand it.
2020-03-13 17:32:17 +00:00
19bd283807
Process: drop a blank line
2020-02-10 12:23:11 +00:00
20d1a048dd
fixup imports
2020-02-10 12:21:56 +00:00
15b76a24b7
scrub useless phpdoc
2020-02-10 12:21:07 +00:00
f08e411cad
Merge branch 'stable' into next-minor
2020-02-10 11:40:08 +00:00
79acaa3253
Utils: remove useless typecasts
2020-02-06 16:06:58 +00:00
41b1fa7b48
Config: clean up inconsistent data parsing & handling
2020-02-05 20:50:36 +00:00
fa82cb26d8
added native types to closures (phpstan-strict-rules)
2020-02-05 16:35:10 +00:00
e5a2cfb65f
avoid type juggling in conditions, always use explicit boolean conditions
2020-02-05 15:44:06 +00:00
260ac47588
add some phpstan array types
2020-01-30 22:23:11 +00:00
d3021c6281
populate missing array value types in utils namespace, pass 2
2020-01-30 21:39:15 +00:00
da43ae82fe
populate missing array value types in utils namespace, pass 1
2020-01-30 21:30:01 +00:00
9cdea43794
provide more array type information for Internet functions
2020-01-29 20:45:03 +00:00
e007fad5b8
fix return types for Utils/Internet getURL()/postURL()
2020-01-29 20:43:09 +00:00
5cf2fcbbb7
simpleCurl() second return value is string[][], not string[]
2020-01-29 20:38:19 +00:00
9e6cbb5b6a
Internet: fix type information for getURL(), postURL() and simpleCurl()
2020-01-29 20:20:52 +00:00
2b402e525a
add some PHPStan-specific callable prototypes
2020-01-29 15:03:55 +00:00
f624871b3f
strip extra blank lines (php-cs-fixer)
2020-01-22 14:50:29 +00:00
9cd6b3e1c7
fix remaining multiline @var annotations
2020-01-22 14:44:36 +00:00
9f44adf04a
pass 2, manual removal of incorrect non-nullable @param for nullable native types
2020-01-21 15:44:34 +00:00
c4793241f5
Mass removal of useless @param/@return PHPDoc annotations, pass 1
2020-01-21 15:10:18 +00:00
0b9d0f3cdc
utils: populate missing return type information
2020-01-19 17:07:48 +00:00
f16a530849
MainLogger: add native return types to private functions
2020-01-18 17:47:38 +00:00
7137b8a8a4
Config: added native void return types to private functions
2020-01-18 17:46:25 +00:00
