3f1f135a59
remove a couple more Position->getWorld() usages
2020-05-19 21:38:51 +01:00
81dff6d4c5
Merge branch 'next-minor'
2020-05-19 21:32:44 +01:00
da4a2d8552
Fixed a bunch of missed Position->getLevel() usages
...
these were not in the usage search because PhpStorm decided to refer to ChunkLoader->getLevel() for any Player references, which caused them to only show when that was searched.
There's also an undetected LSP violation with ChunkLoader because it requires returning Level and Position->getLevel() returns Level|null. I don't know why PHPStan doesn't complain about that.
2020-05-19 21:01:18 +01:00
337addf1de
Eradicate remaining usages of public Position->world field
...
and as an added bonus, ditch a bunch of extra phpstan errors
2020-05-19 19:14:56 +01:00
8a8b1b0b97
Remove Position->setWorld()
2020-05-19 18:33:16 +01:00
f0fefecf40
updated l7 and l8 baselines for master
2020-05-18 20:36:50 +01:00
55f8314fa7
Merge branch 'next-minor'
...
# Conflicts:
# resources/vanilla
2020-05-18 20:33:22 +01:00
15baf09339
update l7 and l8 baselines for next-minor branch
2020-05-18 20:16:03 +01:00
fffa4b9501
phpstan: baseline our way to level 8
...
we really need the level 8 checks on new code now, and waiting until old code is clean is not going to benefit us much because the issues that are there already exist.
2020-05-18 20:09:25 +01:00
c30dd9f1b6
Entity: add abstract getNetworkTypeId(), remove NETWORK_ID constant
...
this now requires that subclasses supply a proper NETWORK_ID.
2020-05-16 16:08:12 +01:00
4c5fb1371d
Merge commit 'a70fa1569027b5a77979ae513f753e71b4454b05'
2020-05-13 13:48:51 +01:00
a70fa15690
phpstan 0.12.25, drop some bug-filtering error patterns
2020-05-13 12:51:52 +01:00
84f41153e9
silence another phpstan bug
2020-05-13 00:25:16 +01:00
acd37b95b8
Merge branch 'next-minor'
2020-05-06 20:41:48 +01:00
ef97c8f99e
Utils: fix parsing of single-line doc comments, closes #3388 ( #3469 )
...
* Utils: fix parsing of single-line doc comments, closes #3388
* correctly handle the empty doc-comment case, add another test case
* ignore an extra phpstan bug
2020-05-06 14:17:08 +01:00
6bfc309a0a
phpstan 0.12.22
2020-05-04 22:26:44 +01:00
a73c54bdd0
making tile spawn compound cache use CacheableNbt instead of strings
2020-05-04 12:35:13 +01:00
098a5518a6
phpstan: ignore another trait override bug
2020-04-29 11:35:12 +01:00
d9e4783b24
start making network compressors dynamic
...
this will facilitate future multi version support where compression types are different between versions
2020-04-28 14:47:01 +01:00
2d55b2db1b
Merge branch 'next-minor'
2020-04-26 00:38:20 +01:00
f87e96026c
Merge branch 'stable' into next-minor
2020-04-26 00:28:09 +01:00
b63ad032a9
phpstan 0.12.19
2020-04-26 00:08:41 +01:00
040fdc2875
Merge commit '8e1b3ed'
...
# Conflicts:
# phpstan.neon.dist
# resources/vanilla
# tests/phpstan/configs/phpstan-bugs.neon
# tests/phpstan/configs/phpunit-wiring-tests.neon
# tests/phpstan/configs/pthreads-bugs.neon
# tests/phpstan/configs/runtime-type-checks.neon
2020-04-25 12:35:30 +01:00
bb8ef3ff6d
Merge commit 'da9731e'
...
# Conflicts:
# phpstan.neon.dist
# resources/vanilla
# src/PocketMine.php
2020-04-25 12:20:23 +01:00
8e1b3edd2c
Merge branch 'stable' into next-minor
2020-04-25 12:06:52 +01:00
4c1b10b24b
restructure ignoreErrors to allow regenerating them file by file
2020-04-25 11:59:06 +01:00
61dc9d7f6b
phpstan: split up phpstan-bugs and phpstan-bugs-generated configs
2020-04-25 11:26:54 +01:00
da9731ef59
phpstan: add stub defines to improve analysis
2020-04-25 11:07:05 +01:00
d3da485278
fix phpstan analyze failure
2020-04-25 10:43:06 +01:00
86f67445c6
fix merge error
2020-04-19 11:19:06 +01:00
163c3855eb
Merge branch 'next-minor'
...
# Conflicts:
# resources/vanilla
# src/plugin/PluginBase.php
# src/plugin/PluginDescription.php
# src/pocketmine/Player.php
# src/pocketmine/network/rcon/RCON.php
# src/pocketmine/network/rcon/RCONInstance.php
# src/pocketmine/scheduler/AsyncTask.php
# src/pocketmine/tile/Spawnable.php
# src/scheduler/AsyncPool.php
# src/utils/Config.php
# src/utils/Timezone.php
# src/utils/UUID.php
# src/utils/Utils.php
# src/world/format/io/region/RegionLoader.php
2020-04-19 11:13:41 +01:00
5c9419b55c
Timezone: use false checks instead of file existing for static analysis
2020-04-15 10:59:36 +01:00
83a3adecff
LoginPacket: use netresearch/jsonmapper for login data decoding
...
this makes retrieval static analysis friendly without extra steps.
2020-03-23 22:00:13 +00:00
2d461251ed
phpstan: ignore more errors reported by strict-rules
2020-02-07 22:14:51 +00:00
1ffabbb567
fixed ignoreError for registerEvent()
2020-02-07 20:25:08 +00:00
347b94b284
Merge branch 'stable'
2020-02-07 20:18:17 +00:00
681dd469a2
PluginManager: add class-string phpstan param to registerEvent()
2020-02-07 20:05:41 +00:00
fb1126797a
Merge branch 'stable'
2020-02-07 18:13:55 +00:00
ada8cbb545
phpstan: drop some ignoreErrors that don't occur on 0.12.9
2020-02-06 21:01:05 +00:00
6c7dada232
finally, integrate phpstan-strict-rules
2020-02-06 19:44:10 +00:00
7885b54824
phpstan: run static analysis on tests
2020-02-06 13:13:12 +00:00
4bc2f28c6d
Provide a ChunkUtils stub for PHPStan, so it doesn't get confused when the extension is loaded
...
for some reason the presence of the type problems were reported as
problems on ChunkUtils.php, despite being outside of the project scope
and the errors not applying to the polyfill.
2020-02-02 18:12:41 +00:00
3688f78986
Merge commit '004f7ef82e9613d60c3614dbf634836b7e2f3774'
2020-01-31 22:09:20 +00:00
89c6da13ac
phpstan: use more class-string
2020-01-31 22:05:33 +00:00
004f7ef82e
phpstan: stub out the iterable bullshit with pthreads
...
this isn't a perfect fix, but it's better than it whining about all the things.
2020-01-30 22:31:15 +00:00
89ebd2b880
remove some dead ignoreErrors
2020-01-30 22:30:04 +00:00
35c23ea89a
com_exception is no longer missing from phpstan stubs
2020-01-27 09:35:27 +00:00
757f5b2fbf
Merge branch 'stable'
2020-01-20 18:12:58 +00:00
5a97c378fc
phpstan: green on level 6, minus iterable types
...
iterable types are a big pain in the ass because of pthreads' awful architecture, and there's nothing I can do about that without BC-breaking changes to pthreads.
2020-01-20 17:54:55 +00:00
f44c9adbb0
Merge branch 'stable'
2020-01-20 17:33:43 +00:00
