Commit Graph

287 Commits

Author SHA1 Message Date
269066b2d0 added unit test for Enum lazy initialization 2020-02-01 20:42:04 +00:00
3688f78986 Merge commit '004f7ef82e9613d60c3614dbf634836b7e2f3774' 2020-01-31 22:09:20 +00:00
89c6da13ac phpstan: use more class-string 2020-01-31 22:05:33 +00:00
004f7ef82e phpstan: stub out the iterable bullshit with pthreads
this isn't a perfect fix, but it's better than it whining about all the things.
2020-01-30 22:31:15 +00:00
89ebd2b880 remove some dead ignoreErrors 2020-01-30 22:30:04 +00:00
9a5d3e3d4f Merge branch 'stable' 2020-01-28 14:35:50 +00:00
41d02003c2 Install PHPStan and PHPUnit via dev dependencies 2020-01-27 12:04:42 +00:00
35c23ea89a com_exception is no longer missing from phpstan stubs 2020-01-27 09:35:27 +00:00
67e54d6fd6 Merge branch 'stable' 2020-01-27 09:34:48 +00:00
156ecd9bd8 travis: use phpstan 0.12.8 2020-01-27 09:31:27 +00:00
588ff8acf6 Merge branch 'stable' 2020-01-25 18:11:02 +00:00
fa7736efbb phpstan 0.12.7 2020-01-25 17:16:14 +00:00
d71a7ff2fa travis.sh: fix indentation 2020-01-25 17:15:37 +00:00
757f5b2fbf Merge branch 'stable' 2020-01-20 18:12:58 +00:00
5a97c378fc phpstan: green on level 6, minus iterable types
iterable types are a big pain in the ass because of pthreads' awful architecture, and there's nothing I can do about that without BC-breaking changes to pthreads.
2020-01-20 17:54:55 +00:00
f44c9adbb0 Merge branch 'stable' 2020-01-20 17:33:43 +00:00
e5d62ec901 phpstan 0.12.6 2020-01-20 17:26:48 +00:00
01016d7e17 Merge branch 'stable' 2020-01-19 19:59:56 +00:00
8252bea699 phpstan: enable MissingMethodReturnTypehintRule
this was a bitch of a job, but it's one step closer to bypassing level 6.
2020-01-19 19:43:52 +00:00
f2f4715d97 Merge commit '30f2e7527818e3275ceb0ff26093c4f26a84c51c' 2020-01-13 19:17:54 +00:00
0e1cea043a added some phpstan-specific generic type annotations 2020-01-13 15:05:02 +00:00
acaa34785f Merge commit '2cfc25b4f8f084c155a871934a10cc9010b05f7d' 2020-01-13 11:02:01 +00:00
30f2e75278 phpstan 0.12.5 2020-01-12 16:57:43 +00:00
2cfc25b4f8 phpstan: enable checkGenericClassInNonGenericObjectType 2020-01-11 23:04:16 +00:00
9c06c1a06f Merge branch 'stable' 2020-01-11 22:36:57 +00:00
3614d9a78d phpstan: enable MissingMethodParameterTypehintRule 2020-01-11 21:54:42 +00:00
96b91af66a Merge branch 'stable' 2020-01-11 21:41:38 +00:00
8794292788 remove &$var reference notations in phpdoc
this isn't required by the spec and PHPStan chokes on it. I was previously having it ignore these errors, but it turns out that PHPStan is not making use of extended typeinfo provided if it can't parse the tag, which is problematic on level 6 and also a problem for array-of-type. Therefore, we are going to have to take the hit.
2020-01-11 21:20:55 +00:00
05a450df87 Merge branch 'stable' 2020-01-09 20:16:17 +00:00
039478223e phpstan: enable MissingFunctionReturnTypehintRule 2020-01-09 20:14:15 +00:00
c85f4256c7 phpstan: enable MissingFunctionParameterTypehintRule 2020-01-09 20:10:15 +00:00
715a5c55f4 Merge branch 'stable' 2020-01-09 20:02:22 +00:00
6dcd2a4ece phpstan: start phasing in some level 6 checks 2020-01-09 19:56:04 +00:00
a733f094ac phpstan: added a custom rule to disallow strict equality operators on enum members
comparing enums with equality operators is unreliable because there is no guarantee that the enum objects won't be somehow duplicated, through serialization, cloning or ext-parallel dumb object copying. This means that two equal enum objects may not be thw same object.
2020-01-08 19:45:05 +00:00
305b4007d2 Merge commit '6490a49c702d0a3a9f62ffb915ffa22272f17b08'
# Conflicts:
#	resources/vanilla
#	tests/travis.sh
2020-01-04 16:25:40 +00:00
dd5be9692c Merge commit '5cd7e11b298a35bf796b41b577c28441e41ff411' 2020-01-04 16:24:29 +00:00
6490a49c70 tests: drop lint.sh - no longer needed now that we have PHPStan 2020-01-04 15:23:53 +00:00
5cd7e11b29 Use specialized build script for Travis 2020-01-04 15:15:01 +00:00
9204b11948 phpstan: 0.12.3 fixes for master 2019-12-29 17:55:03 +00:00
cccade9ade Merge branch 'stable' 2019-12-29 15:31:10 +00:00
3e23a568ca phpstan: properly fixing FPs on constant comparisons 2019-12-29 14:25:44 +00:00
2de0ec02ba phpstan 0.12.3 2019-12-28 17:22:08 +00:00
0f718ea28b Merge commit '8726604899d1a371567141e0831ed570d3233356' 2019-12-25 14:19:35 +00:00
494660102e Replace empty() usages with count() 2019-12-18 11:23:24 +00:00
1c6d3cd580 master: green on phpstan level 4 2019-12-12 15:25:15 +00:00
a9c09e4517 Merge branch 'next-minor' 2019-12-12 13:52:14 +00:00
70c3008b7b phpstan: green on level 4 2019-12-12 13:00:57 +00:00
6127a02a8b phpstan 0.12.2 2019-12-12 10:43:45 +00:00
ff5aedaf6b master: green on phpstan level 3 2019-12-05 14:35:02 +00:00
a5e8419d5b Merge branch 'next-minor'
# Conflicts:
#	phpstan.neon.dist
#	resources/vanilla
#	src/item/WritableBookBase.php
#	src/pocketmine/metadata/MetadataStore.php
#	src/world/Position.php
2019-12-05 14:11:59 +00:00