d155de35ed
Merge branch 'dktapps-drew-1.13' into stable
2019-12-01 22:03:03 -05:00
e37c8e3a5d
Merge branch 'drew-1.13' of https://github.com/dktapps/PocketMine-MP into dktapps-drew-1.13
2019-12-01 22:02:40 -05:00
e38c0c0fe1
Merge remote-tracking branch 'upstream/stable' into stable
2019-12-01 21:55:50 -05:00
ce27c03774
PlayerChatEvent: fixed crash when non-CommandSender permissibles subscribe to broadcast permission
...
doing such a thing doesn't make any sense, but the system allows it, so it has to be accounted for.
2019-12-01 21:44:13 +00:00
c4a8781b5c
Fixed doc type inconsistencies surrounding chat broadcast handling (several problems that are all related)
2019-12-01 21:40:11 +00:00
dbab8b5733
Level: fixed type doc of tickRateTime field
2019-12-01 21:21:42 +00:00
2b08bbc7b1
Server: fixed type doc comment of nextTick field
2019-12-01 21:18:20 +00:00
17037f5e9c
Chunk: clean up nonsensical code in initChunk()
...
I have no idea why the extra check was there, or why the null assignment was used, because it doesn't make any sense.
2019-12-01 21:14:23 +00:00
fee3c17148
CraftingManager: fixed type doc of craftingDataCache field
2019-12-01 21:06:34 +00:00
25e6cb74b3
Squid: fixed type doc comment of swimDirection field
2019-12-01 21:06:03 +00:00
8d2e59222e
Entity: fixed not calculating surrounding blocks on entity creation
...
it's unclear if this was actually causing any bugs, but if it was it would likely manifest in the form of, for example, not burning in lava.
2019-12-01 21:05:36 +00:00
cd778661c2
Entity: fixed type doc comment for blocksAround field
2019-12-01 21:03:57 +00:00
c2afc05e7c
Entity: fix type doc comment for static knownEntities field
2019-12-01 21:03:29 +00:00
9be95bf263
Block: return [] instead of null in getMetadata() (return type is non-nullable)
2019-12-01 21:02:49 +00:00
4b65e1cbe1
Command: fix type doc comment for commandMap field
2019-12-01 21:01:57 +00:00
5caae37768
Server: fixed return type doc comment for getCommandAliases()
2019-12-01 21:00:49 +00:00
92e1811b06
DataPacket: fixed bad null assignment to buffer in clean()
...
this is never expected to be null, so implicitly relies on PHP magic behaviour to convert it to string when appended.
2019-12-01 20:36:56 +00:00
293c2710d0
PlayerCreationEvent: fixed doc comments for baseClass and playerClass fields
2019-12-01 20:19:59 +00:00
8a7017fd6b
Enchantment: fixed doc comment for static enchantments field
2019-12-01 20:16:45 +00:00
15f8886958
phpstan: separate non-PM bugs from the main neon config
...
everything left in here is now a PM problem that needs to be looked into.
2019-12-01 20:12:41 +00:00
3226a9dc6a
phpstan: ignore more optional-leveldb errors
2019-12-01 19:52:49 +00:00
1a1e3ff63b
BaseInventory: fixed incorrect & redundant default value for slots field
2019-12-01 19:45:16 +00:00
ea413d0882
phpstan: analyze on level 2, close #3193
2019-12-01 19:32:03 +00:00
0890b5fc99
AsyncPool: assert() that the unstacked task is actually an AsyncTask
...
it's possible that it might not be if the workers were accessed directly, but that shouldn't be possible.
This also silences a PHPStan warning on level 2.
2019-12-01 19:28:05 +00:00
163ed225f2
NetworkBinaryStream: fixed crash when non-compound root tag is provided for itemstack
2019-12-01 18:41:02 +00:00
a4a6d3e094
PlayerCreationEvent: fixed illegal doc comment types
2019-12-01 18:08:25 +00:00
ecbf3e9722
GamemodeCommand: fix CommandSender assignment causing troubles for type inference on static analyzers
...
this would never crash, but in strongly typed code it would be a compile failure.
2019-12-01 09:33:12 +00:00
47a959dace
block: fix some possible crashes when plugins overwrite tile classes in bad ways
...
phpstan was complaining on level 2, and it's not wrong to ...
2019-12-01 09:29:22 +00:00
3968f85c82
sync composer dependencies
2019-12-01 08:54:48 +00:00
d8188b807a
CraftingDataPacket: read & write potion recipes
2019-11-30 21:18:54 +00:00
8e68655fc7
Merge branch 'stable' into drew-1.13
2019-11-30 21:15:50 +00:00
6d109bfc6f
CraftingDataPacket: fixed not retaining cleanRecipes during decode
2019-11-30 21:15:37 +00:00
b7a5a53c9d
MoveActorDeltaPacket: flags is now a short
2019-11-30 12:56:16 +00:00
76bd0f452c
AvailableCommandsPacket: add special handling for enums which aren't referenced by any command directly
...
the CommandName enum is a magic enum used by the argtype.
TODO: It's possible that not sending the CommandName enum might be causing client sided crashes. Investigate.
2019-11-30 12:41:44 +00:00
363556e9b6
AvailableCommandsPacket: encode & decode for enum value constraints
...
This is a peculiarly overengineered system that is used for restricting access to enum members under certain conditions, e.g. to disallow changing specific gamerules in survival.
2019-11-30 12:31:31 +00:00
6f08853b29
Merge branch 'stable' into drew-1.13
2019-11-30 12:04:46 +00:00
42d8357821
AvailableCommandsPacket: fixed missing decoded overloads with 0 arguments
...
these should be listed even if they have 0 arguments
2019-11-30 11:58:29 +00:00
f2ac63d235
update build/php submodule to pmmp/php-build-scripts@8308571448
2019-11-29 11:54:42 +00:00
5d17405b92
Better checks on resource patch
2019-11-28 19:48:34 -05:00
3dd53ad998
Remove offset for crafting grid
2019-11-28 19:42:34 -05:00
a303c4b294
Add some isset checks to prevent server from crashing on an invalid resourcepatch
2019-11-21 17:58:33 -05:00
fa56290bb4
Reflect StartGamePacket changes in Player
2019-11-21 15:05:09 -05:00
01d6cbe9c3
Added : void typehint to SkinAdapterSingleton & provide documentation
2019-11-21 15:01:34 -05:00
f682c16740
Changed eduMode to eduEditionOffer and added an unsignedVarInt in availablecommandspacket
2019-11-21 14:55:29 -05:00
74c09dc202
Remove inline assignment
2019-11-21 14:49:01 -05:00
0917b67573
Generate param docs for constructor
2019-11-21 14:46:10 -05:00
5cb0eafcb2
Should be checking the string, not an object
2019-11-21 14:24:47 -05:00
221e6db47d
Remove persona capes off of classic skins, add checks for empty cape data when converting
2019-11-21 14:21:08 -05:00
8d06018d81
make toSkinData return statement multi lined
2019-11-21 13:54:22 -05:00
600e16d9f6
Fixed floatingtextparticle yet again
2019-11-21 13:54:00 -05:00
