Dylan K. Taylor
f8ce01e2fd
ItemFactory: extract fromStringSingle() from fromString()
...
on PM4, the multiple functionality is removed, but on PM3 this is a problem for phpstan.
2020-03-13 17:54:25 +00:00
Dylan K. Taylor
78394a336c
Merge branch 'stable'
2020-02-25 20:45:39 +00:00
Dylan K. Taylor
7aa8bd18d3
Revert "Item: restrict bounds of count to 0-255"
...
This reverts commit 10317527e4012fb1dbb1661f2f7fc33b05a7a6d1.
this breaks user code which exceeds stack limits in legitimate
circumstances. For example, it should be OK to add 6000x diamond to a
player's inventory without being forced to manually split the count up
for addItem().
2020-02-25 20:42:03 +00:00
Dylan K. Taylor
5c2ae0257c
DataPacket: inject buffer via parameter instead of class field (packet & stream separation, step 2)
...
this is not complete yet, but the final change (having the binarystream actually come from outside) is a little more disruptive, and some extra changes need to be made. This will grant some sanity in the meantime without breaking too much stuff.
2020-02-25 16:19:11 +00:00
Dylan K. Taylor
bd00ee5038
Merge branch 'stable'
2020-02-24 22:11:13 +00:00
Dylan K. Taylor
04581e2700
DataPacket: account for splitscreen header when decoding
2020-02-24 21:20:25 +00:00
Dylan K. Taylor
8a770d837e
Merge branch 'stable'
2020-02-24 20:32:43 +00:00
Dylan K. Taylor
10317527e4
Item: restrict bounds of count to 0-255
2020-02-23 17:23:53 +00:00
Dylan K. Taylor
2d461251ed
phpstan: ignore more errors reported by strict-rules
2020-02-07 22:14:51 +00:00
Dylan K. Taylor
1ffabbb567
fixed ignoreError for registerEvent()
2020-02-07 20:25:08 +00:00
Dylan K. Taylor
347b94b284
Merge branch 'stable'
2020-02-07 20:18:17 +00:00
Dylan K. Taylor
681dd469a2
PluginManager: add class-string phpstan param to registerEvent()
2020-02-07 20:05:41 +00:00
Dylan K. Taylor
31405f7587
EnumTraitTest: use @doesNotPerformAssertions
2020-02-07 18:35:55 +00:00
Dylan K. Taylor
31fcd8e5fa
ItemTest: use the proper method to explicitly fail a test
2020-02-07 18:35:26 +00:00
Dylan K. Taylor
95896eb911
tests/phpunit: fill in some phpstan types
2020-02-07 18:34:57 +00:00
Dylan K. Taylor
091873ca51
HandlerListManagerTest: fix phpunit 8.x compatibility
2020-02-07 18:14:43 +00:00
Dylan K. Taylor
fb1126797a
Merge branch 'stable'
2020-02-07 18:13:55 +00:00
Dylan K. Taylor
4140af459e
travis: cache leveldb artifacts to reduce build time
2020-02-07 14:05:11 +00:00
Dylan K. Taylor
ada8cbb545
phpstan: drop some ignoreErrors that don't occur on 0.12.9
2020-02-06 21:01:05 +00:00
Dylan K. Taylor
6c7dada232
finally, integrate phpstan-strict-rules
2020-02-06 19:44:10 +00:00
Dylan K. Taylor
a1622fa345
UtilsTest: silence a phpstan-strict-rules warning
2020-02-06 18:53:05 +00:00
Dylan K. Taylor
5ad66c3c9b
BlockTest: throw exception instead of always-false assert
2020-02-06 13:21:39 +00:00
Dylan K. Taylor
7885b54824
phpstan: run static analysis on tests
2020-02-06 13:13:12 +00:00
Dylan K. Taylor
532dc0fb6f
tests/phpunit: populate iterable types for phpstan
2020-02-06 13:11:56 +00:00
Dylan K. Taylor
e12618c705
tests/phpunit: added missing native typehints
2020-02-06 12:13:42 +00:00
Dylan K. Taylor
e1eb9186fe
Merge branch 'stable'
2020-02-03 19:57:21 +00:00
Dylan K. Taylor
4a4c28cd8c
travis.sh: ditch PHP_BINARY variable, use PATH prefix instead
...
this is how normal people do it ...
2020-02-03 09:30:43 +00:00
Dylan K. Taylor
4bc2f28c6d
Provide a ChunkUtils stub for PHPStan, so it doesn't get confused when the extension is loaded
...
for some reason the presence of the type problems were reported as
problems on ChunkUtils.php, despite being outside of the project scope
and the errors not applying to the polyfill.
2020-02-02 18:12:41 +00:00
Dylan K. Taylor
afeb9838e4
Merge branch 'stable'
2020-02-02 16:47:19 +00:00
Dylan K. Taylor
1f2fb73297
updated DevTools submodule to 1.14.0
2020-02-02 10:21:32 +00:00
Dylan K. Taylor
269066b2d0
added unit test for Enum lazy initialization
2020-02-01 20:42:04 +00:00
Dylan K. Taylor
3688f78986
Merge commit '004f7ef82e9613d60c3614dbf634836b7e2f3774'
2020-01-31 22:09:20 +00:00
Dylan K. Taylor
89c6da13ac
phpstan: use more class-string
2020-01-31 22:05:33 +00:00
Dylan K. Taylor
004f7ef82e
phpstan: stub out the iterable bullshit with pthreads
...
this isn't a perfect fix, but it's better than it whining about all the things.
2020-01-30 22:31:15 +00:00
Dylan K. Taylor
89ebd2b880
remove some dead ignoreErrors
2020-01-30 22:30:04 +00:00
Dylan K. Taylor
9a5d3e3d4f
Merge branch 'stable'
2020-01-28 14:35:50 +00:00
Dylan K. Taylor
41d02003c2
Install PHPStan and PHPUnit via dev dependencies
2020-01-27 12:04:42 +00:00
Dylan K. Taylor
35c23ea89a
com_exception is no longer missing from phpstan stubs
2020-01-27 09:35:27 +00:00
Dylan K. Taylor
67e54d6fd6
Merge branch 'stable'
2020-01-27 09:34:48 +00:00
Dylan K. Taylor
156ecd9bd8
travis: use phpstan 0.12.8
2020-01-27 09:31:27 +00:00
Dylan K. Taylor
588ff8acf6
Merge branch 'stable'
2020-01-25 18:11:02 +00:00
Dylan K. Taylor
fa7736efbb
phpstan 0.12.7
2020-01-25 17:16:14 +00:00
Dylan K. Taylor
d71a7ff2fa
travis.sh: fix indentation
2020-01-25 17:15:37 +00:00
Dylan K. Taylor
757f5b2fbf
Merge branch 'stable'
2020-01-20 18:12:58 +00:00
Dylan K. Taylor
5a97c378fc
phpstan: green on level 6, minus iterable types
...
iterable types are a big pain in the ass because of pthreads' awful architecture, and there's nothing I can do about that without BC-breaking changes to pthreads.
2020-01-20 17:54:55 +00:00
Dylan K. Taylor
f44c9adbb0
Merge branch 'stable'
2020-01-20 17:33:43 +00:00
Dylan K. Taylor
e5d62ec901
phpstan 0.12.6
2020-01-20 17:26:48 +00:00
Dylan K. Taylor
01016d7e17
Merge branch 'stable'
2020-01-19 19:59:56 +00:00
Dylan K. Taylor
8252bea699
phpstan: enable MissingMethodReturnTypehintRule
...
this was a bitch of a job, but it's one step closer to bypassing level 6.
2020-01-19 19:43:52 +00:00
Dylan K. Taylor
f2f4715d97
Merge commit '30f2e7527818e3275ceb0ff26093c4f26a84c51c'
2020-01-13 19:17:54 +00:00
