46c224da86
phpstan: remove an obsolete ignored error pattern from explicit-mixed baseline
2020-08-03 19:54:53 +01:00
303344783a
CheckTestCompletionTask: use TaskHandler->cancel()
2020-07-08 10:57:20 +01:00
a34f3261cb
event: harden APIs that accept arrays
...
plugin devs can't be relied on to pass the proper types to these APIs, and when the wrong types get passed it makes type errors appear from inside the internals.
2020-07-04 21:55:23 +01:00
e990c5a0a5
Protocol changes for 1.16.0
2020-06-26 14:06:41 +01:00
df76c02e7a
Explicitly release server.lock file when shutdown the server. ( #3619 )
...
Previously, this relied on PHP itself to release locks during the resource destructor phase during process exit, but sometimes it doesn't for god knows what reason. This change makes the lock file get explicitly released before the process dies.
2020-06-26 11:41:39 +01:00
d343187e58
phpstan: drop 2 obsolete level 8 error patterns fixed by 763c8ebfe3
2020-06-23 12:57:25 +01:00
c5ad127854
BaseInventory: mark eventProcessor as nullable, fixes a phpstan level 8 error
2020-06-23 12:55:06 +01:00
c572e9bb6a
phpstan: regenerate l7 baseline
2020-06-21 18:58:41 +01:00
49d3a42120
phpstan: make EntityEvent generic, fix a bunch of 'actual-problems' ignored errors
2020-06-21 00:27:32 +01:00
c523595e85
Rewrite TeleportCommand (sadly I can't make this commit any smaller)
...
this pile of shit was overdue a rewrite. The new version is much easier to understand.
2020-06-21 00:04:18 +01:00
e32180ce93
phpstan: drop an obsolete phpstan-bugs ignoreError
2020-06-19 10:41:41 +01:00
e105578be0
LegacySkinAdapter: an extra check for resourcePatch (fixes 3 phpstan explicitMixed errors)
2020-06-18 20:08:38 +01:00
a9d98bdf73
phpstan: baseline our way into checkExplicitMixed territory
2020-06-18 18:07:21 +01:00
130c55d9f1
EntityLink: remove rogue default ctor parameters
2020-06-15 23:58:11 +01:00
2712befa82
SkinData: fixed capeImage type violation (doesn't accept null)
2020-06-15 23:51:48 +01:00
23b97d8e2d
TextFormat: wrap all preg_replace() usages in a type-safe exception-throwing version
...
fixes 3 phpstan level 8 errors
2020-06-15 23:31:46 +01:00
1fb5043eb1
build/server-phar: fixed a phpstan level 8 error
2020-06-15 23:16:40 +01:00
b0b1b29de4
Chunk: specify list<int> for heightMap
2020-06-15 23:07:35 +01:00
1c3b641e37
ChunkUtils: be more specific in extension stub too
2020-06-15 23:07:05 +01:00
8dcc88712c
ChunkUtils: fixed phpstan level 7 type inference error
2020-06-15 23:04:12 +01:00
04191ec44a
Rail: specify type for local static variable
...
fixes a phpstan level 7 error
phpstan doesn't make any assumptions about local static variable types because analysing them would require too much work, apparently.
2020-06-15 22:47:20 +01:00
cf06b5b8cf
Player: explicitly check for false return of dataPacket()
...
fixes a phpstan error on l7
this won't ever actually be a problem, but this isn't obvious from the type system.
2020-06-15 21:24:19 +01:00
a8ec51daac
Player: do not assign maybe-false result of json_encode() to ModalFormRequestPacket
...
fixes a phpstan error on l7
2020-06-15 21:22:33 +01:00
b902f9ded0
RegionLoader: fixed 2 phpstan level 7 errors (eof reading region header)
2020-06-15 15:09:37 +01:00
e05bee5ffb
RegionLoader: do a full check for chunk overlaps during initial load
2020-06-14 22:39:01 +01:00
d8d994351b
phpstan 0.12.29
2020-06-14 16:25:55 +01:00
a7f10d8ccf
phpstan: ignore a FP (fixed in 0.12.26, but we can't upgrade yet)
2020-06-10 10:45:28 +01:00
42613618a5
phpstan: add LevelDB::get() stub to fix return type
2020-06-10 10:31:54 +01:00
3f971a0c65
phpstan: fixed analyze failure caused by a27b29897c
2020-06-05 12:58:18 +01:00
da4a2d8552
Fixed a bunch of missed Position->getLevel() usages
...
these were not in the usage search because PhpStorm decided to refer to ChunkLoader->getLevel() for any Player references, which caused them to only show when that was searched.
There's also an undetected LSP violation with ChunkLoader because it requires returning Level and Position->getLevel() returns Level|null. I don't know why PHPStan doesn't complain about that.
2020-05-19 21:01:18 +01:00
15baf09339
update l7 and l8 baselines for next-minor branch
2020-05-18 20:16:03 +01:00
083dde8395
Merge branch 'stable' into next-minor
2020-05-18 20:10:47 +01:00
fffa4b9501
phpstan: baseline our way to level 8
...
we really need the level 8 checks on new code now, and waiting until old code is clean is not going to benefit us much because the issues that are there already exist.
2020-05-18 20:09:25 +01:00
8766d4050c
Merge branch 'stable' into next-minor
2020-05-13 13:18:55 +01:00
a70fa15690
phpstan 0.12.25, drop some bug-filtering error patterns
2020-05-13 12:51:52 +01:00
717b866605
Merge branch 'stable' into next-minor
2020-05-06 20:25:11 +01:00
ef97c8f99e
Utils: fix parsing of single-line doc comments, closes #3388 ( #3469 )
...
* Utils: fix parsing of single-line doc comments, closes #3388
* correctly handle the empty doc-comment case, add another test case
* ignore an extra phpstan bug
2020-05-06 14:17:08 +01:00
6bfc309a0a
phpstan 0.12.22
2020-05-04 22:26:44 +01:00
f87e96026c
Merge branch 'stable' into next-minor
2020-04-26 00:28:09 +01:00
b63ad032a9
phpstan 0.12.19
2020-04-26 00:08:41 +01:00
8e1b3edd2c
Merge branch 'stable' into next-minor
2020-04-25 12:06:52 +01:00
4c1b10b24b
restructure ignoreErrors to allow regenerating them file by file
2020-04-25 11:59:06 +01:00
61dc9d7f6b
phpstan: split up phpstan-bugs and phpstan-bugs-generated configs
2020-04-25 11:26:54 +01:00
da9731ef59
phpstan: add stub defines to improve analysis
2020-04-25 11:07:05 +01:00
5c9419b55c
Timezone: use false checks instead of file existing for static analysis
2020-04-15 10:59:36 +01:00
f8ce01e2fd
ItemFactory: extract fromStringSingle() from fromString()
...
on PM4, the multiple functionality is removed, but on PM3 this is a problem for phpstan.
2020-03-13 17:54:25 +00:00
7aa8bd18d3
Revert "Item: restrict bounds of count to 0-255"
...
This reverts commit 10317527e4
2020-02-25 20:42:03 +00:00
04581e2700
DataPacket: account for splitscreen header when decoding
2020-02-24 21:20:25 +00:00
10317527e4
Item: restrict bounds of count to 0-255
2020-02-23 17:23:53 +00:00
681dd469a2
PluginManager: add class-string phpstan param to registerEvent()
2020-02-07 20:05:41 +00:00
