Commit Graph

18115 Commits

Author SHA1 Message Date
Dries C
0b60a47cde Noteblock instrument changes from 1.21.50 (#6596)
Good thing this isn't saved on disk :|
2025-01-17 19:56:19 +00:00
dependabot[bot]
d1066d0199 Bump build/php from 56cec11 to ae94694 (#6595) 2025-01-17 19:54:48 +00:00
Sergi del Olmo
f349ce75e4 Player: add ability to get & set flight speed multiplier (#6076)
Since this doesn't directly correspond to flight speed (it's multiplied by different values depending on whether sprinting or not, and possibly other states), "multiplier" was preferred instead of directly calling it flight speed.

Default value is 0.05.
2025-01-09 20:13:46 +00:00
Dylan K. Taylor
b3f15435cc Projectile: clean up dodgy code 2025-01-08 02:31:50 +00:00
Dylan K. Taylor
847ae26cad PHPStan: don't remember possibly-impure function return values
I don't think we get much benefit from this, and the assumption that functions with a return value are pure is sketchy.
In any case, it's better to avoid these repeated calls anyway.
2025-01-08 02:04:06 +00:00
Dylan K. Taylor
d42ec06647 ZippedResourcePack: don't pass exception code to new exception
this is a BUT (int|string) under PHPStan, and we don't need the errors. We don't care about this code anyway.
2025-01-08 01:48:55 +00:00
Dylan K. Taylor
5e0f03dff0 Stub PalettedBlockArray functions that work with arrays
and workaround PHPStan stupidity
2025-01-08 01:48:15 +00:00
Dylan K. Taylor
4a83920db9 PlayerPreLoginEvent: improve array type info 2025-01-08 01:47:04 +00:00
Dylan K. Taylor
0a16daa619 Avoid dodgy array_flip hash building
the conventional way is using array_keys and array_fill_keys. Behaviour is more predictable & also avoids benevolent union fuckery from PHPStan.
2025-01-08 01:45:28 +00:00
Dylan K. Taylor
e34f34f9f4 Update BedrockProtocol dependency 2025-01-07 23:09:28 +00:00
Dylan K. Taylor
e8c4b743b5 LevelDB: stop overriding types from NBT
NBT has better quality type info already
2025-01-07 22:54:10 +00:00
Dylan K. Taylor
689a7996b9 Update NBT dependency 2025-01-07 22:51:38 +00:00
Dylan K. Taylor
794641c0f8 Utils: split some horrifying code across multiple lines 2025-01-07 22:35:19 +00:00
Dylan K. Taylor
9633b7d8a7 Update to PHPStan 2.x 2025-01-07 22:34:43 +00:00
Dylan K. Taylor
d25ec58a6f AsyncPoolTest: phpdoc 2025-01-07 22:25:37 +00:00
Dylan K. Taylor
d69a887b0d Utils: fix parameter doc for printableExceptionInfo() 2025-01-07 22:24:26 +00:00
Dylan K. Taylor
38441a6ba3 build: avoid weak comparison 2025-01-07 22:23:16 +00:00
Dylan K. Taylor
47cb04f6a6 tools: fix PHPStan 2.0 issues 2025-01-07 22:15:50 +00:00
Dylan K. Taylor
b1c7fc017a CS 2025-01-07 22:13:20 +00:00
Dylan K. Taylor
cd59e272bc PHPStan 2.0 fixes 2025-01-07 22:10:42 +00:00
Dylan K. Taylor
7b1b35ab1f generator: fixup issues reported by PHPStan 2.0 2025-01-07 22:07:38 +00:00
Dylan K. Taylor
28d31c97f8 Server: fixup PHPStan 2.x reported issues 2025-01-07 22:05:01 +00:00
Dylan K. Taylor
a17512de93 Command: don't trust plugins not to pass junk 2025-01-06 23:26:13 +00:00
Dylan K. Taylor
601be3fb33 stfu 2025-01-06 23:09:26 +00:00
Dylan K. Taylor
2e32c50670 NetworkSession: apparently aliases are already a list at this point??? 2025-01-06 23:08:48 +00:00
Dylan K. Taylor
d1fa6edc50 InGamePacketHandler: fix weak comparisons 2025-01-06 23:08:18 +00:00
Dylan K. Taylor
a1ba8bc3da NetworkSession: improve PHPDoc types 2025-01-06 23:07:54 +00:00
Dylan K. Taylor
73edb8799d SignalHandler: fixed dodgy setup logic 2025-01-06 23:06:19 +00:00
Dylan K. Taylor
9592f066f3 PHPDoc: Restrict ReversePriorityQueue to numeric priorities 2025-01-06 23:05:49 +00:00
Dylan K. Taylor
db9ba83001 Make some assumptions about proc_open() 2025-01-06 23:05:06 +00:00
Dylan K. Taylor
1b2d2a3fe1 plugin: improve PHPDocs and type compliance 2025-01-06 23:04:00 +00:00
Dylan K. Taylor
84ec8b7abe Removed dead error patterns
I do think these are PHPStan bugs, since the trait should inherit the parent class's doc comment
But for the sake of catching more bugs, these doc comments have been manually added anyway.
2025-01-06 23:02:18 +00:00
Dylan K. Taylor
357dfb5c7e Fixed build 2025-01-06 23:01:14 +00:00
Dylan K. Taylor
0358b7dce4 utils: avoid weak comparisons 2025-01-06 22:53:35 +00:00
Dylan K. Taylor
97c5902ae2 Internet: make postURL() error reporting behaviour more predictable
err is now always set to null when doing a new operation.

previously, if the same var was used multiple times and a previous one failed,
code might think that a previous error belonged to the current operation.
2025-01-06 22:52:05 +00:00
Dylan K. Taylor
9a130bce32 Config: remove bad assumptions about string root keys
these could just as easily be integers and the code should still work.
2025-01-06 22:50:25 +00:00
Dylan K. Taylor
20849d6268 Fixed potential crashes in type ID tests
if the constants had any non-stringable values, these would blow up.
this would still be fine in the sense that the tests would fail, but better that they fail gracefully if possible.
2025-01-06 22:48:22 +00:00
Dylan K. Taylor
b6bd3ef30c Improve PHPDocs in world package 2025-01-06 22:46:16 +00:00
Dylan K. Taylor
c5a1c15389 TimingsCommand: beware crash on invalid timings server response 2025-01-06 22:44:17 +00:00
Dylan K. Taylor
e30ae487dc SimpleCommandMap: ensure we always pass a list to Command::setAliases()
some offsets may have been removed if the alias failed to be registered.
2025-01-06 22:44:17 +00:00
Dylan K. Taylor
59f6c85105 Command: mark execute $args as being list<string> 2025-01-06 22:44:17 +00:00
Dylan K. Taylor
90f0b85d2e Eliminate weak comparisons in entity package
Weak comparisons were used in cases when we were worried about comparing int and float.

In some cases (particularly involving Vector3) we do need to be wary of this, so floatval() is used to avoid incorrect type comparisons.
In other cases, we were already exclusively comparing float-float, so weak compare wasn't needed anyway.
2025-01-06 22:44:17 +00:00
Dylan K. Taylor
8ee70b209e MemoryDump: fix PHPDoc types 2025-01-06 22:44:16 +00:00
Dylan K. Taylor
5c905d9a95 BlockBreakInfo: use strict comparison
weak compare isn't needed here since this can be float/float
2025-01-06 22:44:16 +00:00
Dylan K. Taylor
8b23231537 Fixup PHPDoc for blocks 2025-01-06 22:44:16 +00:00
pmmp-admin-bot[bot]
8e039f2711 Merge 'stable' into 'minor-next'
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12615442245
2025-01-05 01:37:22 +00:00
dependabot[bot]
4a4572131f Bump shivammathur/setup-php in the github-actions group (#6591) 2025-01-04 22:26:14 +00:00
Dylan K. Taylor
3da0b82b86 Merge branch 'stable' into minor-next 2025-01-03 19:26:45 +00:00
Dylan K. Taylor
da62eb9f33 ... 2025-01-03 19:26:24 +00:00
pmmp-admin-bot[bot]
09c434983b Merge 'stable' into 'minor-next'
Automatic merge performed by: https://github.com/pmmp/RestrictedActions/actions/runs/12510342531
2024-12-27 01:23:47 +00:00