Dylan K. Taylor
2b08bbc7b1
Server: fixed type doc comment of nextTick field
2019-12-01 21:18:20 +00:00
Dylan K. Taylor
17037f5e9c
Chunk: clean up nonsensical code in initChunk()
...
I have no idea why the extra check was there, or why the null assignment was used, because it doesn't make any sense.
2019-12-01 21:14:23 +00:00
Dylan K. Taylor
fee3c17148
CraftingManager: fixed type doc of craftingDataCache field
2019-12-01 21:06:34 +00:00
Dylan K. Taylor
25e6cb74b3
Squid: fixed type doc comment of swimDirection field
2019-12-01 21:06:03 +00:00
Dylan K. Taylor
8d2e59222e
Entity: fixed not calculating surrounding blocks on entity creation
...
it's unclear if this was actually causing any bugs, but if it was it would likely manifest in the form of, for example, not burning in lava.
2019-12-01 21:05:36 +00:00
Dylan K. Taylor
cd778661c2
Entity: fixed type doc comment for blocksAround field
2019-12-01 21:03:57 +00:00
Dylan K. Taylor
c2afc05e7c
Entity: fix type doc comment for static knownEntities field
2019-12-01 21:03:29 +00:00
Dylan K. Taylor
9be95bf263
Block: return [] instead of null in getMetadata() (return type is non-nullable)
2019-12-01 21:02:49 +00:00
Dylan K. Taylor
4b65e1cbe1
Command: fix type doc comment for commandMap field
2019-12-01 21:01:57 +00:00
Dylan K. Taylor
5caae37768
Server: fixed return type doc comment for getCommandAliases()
2019-12-01 21:00:49 +00:00
Dylan K. Taylor
92e1811b06
DataPacket: fixed bad null assignment to buffer in clean()
...
this is never expected to be null, so implicitly relies on PHP magic behaviour to convert it to string when appended.
2019-12-01 20:36:56 +00:00
Dylan K. Taylor
293c2710d0
PlayerCreationEvent: fixed doc comments for baseClass and playerClass fields
2019-12-01 20:19:59 +00:00
Dylan K. Taylor
8a7017fd6b
Enchantment: fixed doc comment for static enchantments field
2019-12-01 20:16:45 +00:00
Dylan K. Taylor
1a1e3ff63b
BaseInventory: fixed incorrect & redundant default value for slots field
2019-12-01 19:45:16 +00:00
Dylan K. Taylor
0890b5fc99
AsyncPool: assert() that the unstacked task is actually an AsyncTask
...
it's possible that it might not be if the workers were accessed directly, but that shouldn't be possible.
This also silences a PHPStan warning on level 2.
2019-12-01 19:28:05 +00:00
Dylan K. Taylor
163ed225f2
NetworkBinaryStream: fixed crash when non-compound root tag is provided for itemstack
2019-12-01 18:41:02 +00:00
Dylan K. Taylor
a4a6d3e094
PlayerCreationEvent: fixed illegal doc comment types
2019-12-01 18:08:25 +00:00
Dylan K. Taylor
ecbf3e9722
GamemodeCommand: fix CommandSender assignment causing troubles for type inference on static analyzers
...
this would never crash, but in strongly typed code it would be a compile failure.
2019-12-01 09:33:12 +00:00
Dylan K. Taylor
47a959dace
block: fix some possible crashes when plugins overwrite tile classes in bad ways
...
phpstan was complaining on level 2, and it's not wrong to ...
2019-12-01 09:29:22 +00:00
Dylan K. Taylor
6d109bfc6f
CraftingDataPacket: fixed not retaining cleanRecipes during decode
2019-11-30 21:15:37 +00:00
Dylan K. Taylor
42d8357821
AvailableCommandsPacket: fixed missing decoded overloads with 0 arguments
...
these should be listed even if they have 0 arguments
2019-11-30 11:58:29 +00:00
Dylan K. Taylor
8d2e3894ef
DataPacket: fixed var_dump() not showing private & protected subclass properties
2019-11-11 15:41:08 +00:00
Dylan K. Taylor
932418b951
fixing some PHPStan complaints about bootstrap
...
this isn't an ideal fix, but it'll do.
2019-11-07 18:22:37 +00:00
Dylan K. Taylor
95812252d6
NetworkBinaryStream: fix a mistake in doc for putEntityRuntimeId()
2019-11-07 18:22:37 +00:00
Dylan K. Taylor
cac3c356a5
Painting: fix dropping multiple items when multiple blockupdates occur in the same tick
...
test case: place sand on top of a line of signs, put a painting on the sand and break the supporting sign
fixes #2774 for stable
2019-11-06 14:29:43 -05:00
Dylan K. Taylor
4cb0b319c0
load some non-class constants with composer
...
this makes PHPStan happy and also makes working with PM code externally less of a pain in the ass.
2019-11-05 11:16:22 +00:00
Dylan K. Taylor
5edff79f5f
3.9.8 is next
2019-10-28 16:07:35 +00:00
Dylan K. Taylor
0c91d568b4
Release 3.9.7
2019-10-28 16:07:35 +00:00
Dylan K. Taylor
b5a98a993f
lazy-init RuntimeBlockMapping
2019-10-27 20:58:43 +00:00
Dylan K. Taylor
0840ba8067
PocketMine.php: reduce unnecessary pocketmine\NAME dependencies
2019-10-26 21:37:15 +01:00
Dylan K. Taylor
274cf58ccf
PocketMine.php: remove useless ini_set() (this is a PHP_INI_SYSTEM directive which can't be changed at runtime)
2019-10-25 21:38:47 +01:00
Dylan K. Taylor
1bce5d0bc2
PocketMine.php: move BaseClassLoader creation to where it's actually used
2019-10-25 21:26:22 +01:00
Dylan K. Taylor
0d5d5e21a8
CommandReader: define $w and $e to make PHPStan happy
2019-10-25 16:11:02 +01:00
Dylan K. Taylor
a145e18c1e
CrashDump: use fully qualified reference for GIT_COMMIT constant
...
this makes it easier to filter out PHPStan noise.
2019-10-25 16:08:37 +01:00
Dylan K. Taylor
d1ca779c1a
fix PHPStan @throws incompatible warning
2019-10-25 15:49:47 +01:00
Dylan K. Taylor
48080b7f90
PocketMine.php: define INT32_MASK earlier
...
this is non-dependent on any of the PM crap.
2019-10-24 09:23:37 +01:00
Dylan K. Taylor
b216fb8910
PocketMine.php: set INI entries as early as possible
2019-10-24 09:18:50 +01:00
Dylan K. Taylor
d3171d6a8e
backport a53f698d38
: PocketMine.php: remove useless set_time_limit() call
...
this is hardcoded to zero in the PHP core anyway.
2019-10-24 09:14:18 +01:00
Dylan K. Taylor
c063a4da29
backport 5c1f1f00cb
: move assert.exception to PocketMine.php with the other stuff
2019-10-24 09:12:05 +01:00
Dylan K. Taylor
cc79dfa64c
backport 8b40a8f217
: PocketMine.php: move INI entry setting to a separate function
2019-10-24 09:09:53 +01:00
Dylan K. Taylor
d6b9950901
backport fdfbaf4e95
: make startup performance warnings a little more coherent
2019-10-24 09:06:28 +01:00
Dylan K. Taylor
1815fe5b46
backport 647f86a5b8
: PocketMine.php: remove redundant ini_set()
...
this is overridden later on by MemoryManager.
2019-10-24 09:02:37 +01:00
Dylan K. Taylor
3e993250d8
backport 0c31b8731f
: PocketMine.php: use main logger to emit force-kill debug
2019-10-24 08:57:31 +01:00
Dylan K. Taylor
1163ac1d7a
backport 0c31b8731f
: PocketMine.php: get rid of redundant LOCK_FILE_PATH constant
2019-10-24 08:55:28 +01:00
Dylan K. Taylor
9a51ba697a
PocketMine.php: move some mission-critical stuff earlier in boot sequence
...
fixes #3161
2019-10-24 08:50:13 +01:00
Dylan K. Taylor
32ad9d0c1a
Squid: fix spammy rotation in enclosed spaces
...
this bug was caused by 2f3c77c68a
. It looks unrelated to the commit title, so it may have been committed by mistake.
2019-10-22 22:50:35 +01:00
Dylan K. Taylor
3d840e969d
3.9.7 is next
2019-10-22 14:38:02 +01:00
Dylan K. Taylor
d1b70bd400
Release 3.9.6
2019-10-22 14:38:02 +01:00
Dylan K. Taylor
29f002b32c
LightUpdate: fixed type doc for updateNodes field
2019-10-22 12:23:42 +01:00
Dylan K. Taylor
da17ade575
AvailableCommandsPacket: fixed wrong parameter type doc for putEnum()
2019-10-22 12:23:01 +01:00