14461 Commits

Author SHA1 Message Date
Dylan K. Taylor
ff0199cdf8
Fixed blue candle being missing from the creative inventory
this coincidentally fixes mangrove doors being tagged with unwanted blockstate runtime IDs. Their items client-side are not actually blockitems, so the client doesn't expect them to have blockstate IDs attached.
This reduces the chaos in the creative inventory slightly (for some reason the client responds to this stuff by putting random creative items in the wrong places), but the mess is still substantial and I don't know what caused the rest of it.

closes #5818

technically we shouldn't be breaking BC of internals signatures in a patch release, but it's internals, and that's an unwritten rule anyway. In any case, no one is likely to be affected.
2023-06-13 18:03:10 +01:00
Dylan T
df4a8d4788
AsyncTask: lazy-init progressUpdates (#5806)
this is only possible since pthreads 5.1 and pmmpthread

the performance cost of this one ThreadSafeArray allocation is 30% of the total cost of allocating an AsyncTask object on Windows, which is enormous.

In past versions we couldn't lazily initialize it, because the object might get destroyed before the main thread had a chance to dereference it, leading to a crash when collecting completed tasks. This is no longer an issue thanks to object rescue behaviour implemented in pthreads 5.1.
I think this is probably OK in terms of thread-safety, as only one thread writes the property.
2023-06-11 14:45:44 +01:00
ItsZodiaX
1b35c352cc
StandardEntityEventBroadcaster: Accepting PacketBroadcaster interface instead of StandardPacketBroadcaster (#5813) 2023-06-11 13:48:58 +01:00
Dylan K. Taylor
1533dc4e56
Added cherry leaves 2023-06-10 13:21:21 +01:00
Dylan K. Taylor
3800c0480f
Group leaves (de)serializers together 2023-06-09 19:19:29 +01:00
Dylan K. Taylor
0f8e61eda4
Implemented new cherry-wood blocks 2023-06-09 18:04:52 +01:00
Dylan K. Taylor
0eb5f9b684
Fixed missing ItemTypeNames (forgot to regenerate from 1.20) 2023-06-09 17:59:11 +01:00
Dylan K. Taylor
0f9283fda1
Reduce chaos in blockstate (de)serializers wrt. wooden blocks
these started to get flattened in 1.19, and rather than dump them in random places in the main function I made a new method, creating placement inconsistencies.
2023-06-09 17:47:06 +01:00
Dylan K. Taylor
64c1776910
Merge branch 'stable' into minor-next 2023-06-09 13:57:47 +01:00
Dylan K. Taylor
92bd88c77c
5.1.3 is next 2023-06-09 01:37:46 +01:00
Dylan K. Taylor
7cd317bf39
Release 5.1.2 2023-06-09 01:37:45 +01:00
Dylan K. Taylor
35fc9abacf
Merge branch 'legacy/pm4' into stable 2023-06-09 01:34:33 +01:00
Dylan K. Taylor
dfd70615ad
4.22.2 is next 2023-06-09 01:33:35 +01:00
Dylan K. Taylor
ee903cad1f
Release 4.22.1 2023-06-09 01:33:35 +01:00
Dylan K. Taylor
9a04481bec
Entity: broadcast teleports as regular movements
fixes #5810

probably fixes #4986

#5810 was caused by the workaround for #4394, which broke in 1.20 for reasons I'm still unclear on.

As FLAG_TELEPORT does not work at all for non-player entities, and causes bugs with player entities, sending the teleport movement without the flag is the least buggy way to solve all of these issues. Having the client interpolate teleport movements is not ideal, but there doesn't seem to be a way to reliably prevent it without causing even more bugs, so this will have to do.
2023-06-09 01:24:57 +01:00
Dylan K. Taylor
833f9401f9
Merge branch 'stable' into minor-next 2023-06-07 22:03:34 +01:00
Dylan K. Taylor
a46dfaf677
5.1.2 is next 2023-06-07 21:59:28 +01:00
Dylan K. Taylor
4a3b175468
Release 5.1.1 2023-06-07 21:59:28 +01:00
Dylan K. Taylor
73ee94b62c
Fixed BlockStateData::CURRENT_VERSION 2023-06-07 21:58:21 +01:00
Dylan K. Taylor
ab83210aa0
5.1.1 is next 2023-06-07 21:35:11 +01:00
Dylan K. Taylor
3f2d51c58a
Release 5.1.0 2023-06-07 21:35:10 +01:00
Dylan K. Taylor
2220dc557e
4.22.1 is next 2023-06-07 21:23:57 +01:00
Dylan K. Taylor
b5fc31a781
Release 4.22.0 2023-06-07 21:23:54 +01:00
Dylan K. Taylor
9a67e3d660
PM5-specific changes for 1.20.0.23 beta 2023-06-07 21:08:41 +01:00
Dylan K. Taylor
132330e16f
Merge branch 'legacy/pm4' into stable 2023-06-07 21:08:09 +01:00
Dylan K. Taylor
441f1f534f
Random change PHP-CS-Fixer wanted to make 2023-06-07 20:59:32 +01:00
Dylan K. Taylor
2538880408
1.20.0 2023-06-07 20:56:59 +01:00
Dylan K. Taylor
57cbc25080
Merge remote-tracking branch 'origin/stable' into minor-next 2023-06-04 16:10:07 +01:00
Dylan K. Taylor
b9bdfe580b
Bump version to 5.2.0+dev
next feature release go brrrr
2023-06-04 16:07:10 +01:00
IvanCraft623
6d7f44d8fe
Implement glow lichen (#5401) 2023-06-04 16:04:08 +01:00
Dylan K. Taylor
7fef8f0ab6
5.0.2 is next 2023-06-03 21:56:30 +01:00
Dylan K. Taylor
2f43ccea6f
Release 5.0.1 2023-06-03 21:56:26 +01:00
Dylan K. Taylor
af1f7e098b
Require pmmpthread 6.0.1 2023-06-03 21:42:43 +01:00
Dylan K. Taylor
8d7f8ff3f5
Merge branch 'legacy/pm4' into stable 2023-06-03 21:23:00 +01:00
Dylan K. Taylor
c715efb18e
Jukebox: fix music not stopping when destroyed by explosion
closes #5794
2023-06-03 21:22:26 +01:00
Dylan K. Taylor
40be564689
BlockSpreadEvent: document poorly-named constructor parameters 2023-06-03 17:08:02 +01:00
IvanCraft623
4e031e7b3e
Always drop spore blossom item when it is broken (#5796) 2023-06-03 16:07:44 +01:00
Dylan K. Taylor
4340c26029
RuntimeDataSizeCalculator: Tidy up junk comments 2023-06-02 16:37:08 +01:00
Dylan K. Taylor
9c6d4093ae
Fixed crash when getting an item from a block which came from an item which came from a block
had a stroke yet?
2023-06-02 16:16:54 +01:00
Dylan K. Taylor
73e7201acb
5.0.1 is next 2023-06-01 16:09:52 +01:00
Dylan K. Taylor
b16cc69974
Release 5.0.0 2023-06-01 16:09:49 +01:00
Dylan K. Taylor
de49910e84
Fix CS 2023-05-31 22:18:25 +01:00
Dylan K. Taylor
d2fe537159
Merge branch 'minor-next' into major-next 2023-05-31 22:12:39 +01:00
Dylan K. Taylor
bb31df051d
Merge branch 'stable' into minor-next 2023-05-31 22:10:18 +01:00
Dylan K. Taylor
07225df936
Block: fixed tile-stored properties sticking to the item in asItem()
this was enabling duplication of items, since the dropped item object would contain a Block which still referenced the framed Item.
2023-05-31 21:48:06 +01:00
Muqsit Rayyan
3948dc4f75
Remove calls to ReflectionProperty::setAccessible() (#5783)
This is a no-op in PHP 8.1 and up.
2023-05-31 14:03:14 +01:00
Dylan K. Taylor
4f4dca7fc0
Mark WoodLikeBlockIdHelper as internal 2023-05-30 21:41:25 +01:00
Dylan K. Taylor
0ed5e94a72
Merge branch 'minor-next' into major-next 2023-05-30 16:15:56 +01:00
Dylan K. Taylor
3a4e958e84
Merge branch 'stable' into minor-next 2023-05-30 16:08:03 +01:00
Dylan K. Taylor
d343db8750
4.21.2 is next 2023-05-30 14:42:59 +01:00