Dylan K. Taylor
ad87c11ae1
ThreadManager: use array-access instead of variable property access
2020-02-05 16:36:11 +00:00
Dylan K. Taylor
fa82cb26d8
added native types to closures (phpstan-strict-rules)
2020-02-05 16:35:10 +00:00
Dylan K. Taylor
e5a2cfb65f
avoid type juggling in conditions, always use explicit boolean conditions
2020-02-05 15:44:06 +00:00
Dylan K. Taylor
b96bb7d824
Player: use strict base64_decode() for login decoding
...
though, perhaps we should beware of false returns?
2020-02-05 13:55:38 +00:00
Dylan K. Taylor
59cf8e95f0
Tree: fixed populator not growing trees any lower than y=2
...
this would only be a problem for custom generators, but nonetheless...
2020-02-05 13:17:09 +00:00
Dylan K. Taylor
99038c752c
Avoid usage of for-loop vars outside of for-loop context
...
these problems were reported by PHPStan strict rules. They aren't actually bugs, but they could become bugs in the future.
2020-02-05 13:16:09 +00:00
Dylan K. Taylor
88afedd1e8
Human: avoid overwriting non-foreach vars in foreach
2020-02-05 12:59:59 +00:00
Dylan K. Taylor
c43e21235d
HelpCommand: do not overwrite non-foreach vars in foreach
2020-02-05 12:57:27 +00:00
Dylan K. Taylor
3f7e7352fb
added SplFixedArray generics for phpstan 0.12.9
2020-02-05 11:57:37 +00:00
Dylan K. Taylor
32d6ea0fba
Chest: do not crash on failure to fetch pair, closes #2701
...
isPaired() returning true is not semantically equivalent to getPair() returning non-null. getPair() might return null if the pair is inaccessible, such as when it's in an unloaded chunk (it doesn't check this yet, but it should).
For the sake of opening inventory, we don't care if the chest believes if it is paired, we care if there is actually a pair to be accessed for inventory viewing.
In addition, it's possible to create this broken-data scenario artificially by close()ing a chest tile without unpairing it first, because a tile doesn't know the difference between being closed due to unload and being destroyed.
2020-02-03 19:32:58 +00:00
Dylan K. Taylor
28c787371a
Server::$rcon may be null (disabled or failed to start)
2020-02-03 19:25:56 +00:00
Dylan K. Taylor
dba14c9f08
PharPluginLoader: remove useless instanceof, offset is always PharFileInfo at this point
2020-02-03 12:35:34 +00:00
Dylan K. Taylor
eba8d77034
3.11.6 is next
2020-02-02 18:31:51 +00:00
Dylan K. Taylor
13e4772f98
Release 3.11.5
2020-02-02 18:31:51 +00:00
Dylan K. Taylor
496732999c
reintroduce BedrockData submodule
2020-02-01 22:05:07 +00:00
Dylan K. Taylor
6a8105f5a0
delete BedrockData submodule
2020-02-01 22:01:22 +00:00
Dylan K. Taylor
0a566f8218
LevelProvider::generate() accepts class-string<Generator>, not any
...
string
2020-02-01 20:16:05 +00:00
Dylan K. Taylor
829dd02eea
Server: fixed more bad non-nullable phpdocs
2020-02-01 19:30:47 +00:00
Dylan K. Taylor
f1083bd9c4
SimpleCommandMap: beware case mismatches in alias recursion, closes #3281
2020-01-31 10:36:47 +00:00
Dylan K. Taylor
799183e13e
make use of phpstan class-string in some areas
2020-01-30 22:23:11 +00:00
Dylan K. Taylor
260ac47588
add some phpstan array types
2020-01-30 22:23:11 +00:00
Dylan K. Taylor
5d8bb84269
add more mixed[] to item namespace
2020-01-30 21:48:11 +00:00
Dylan K. Taylor
9eebfa7cc3
populate missing array value types in root namespace
2020-01-30 21:43:00 +00:00
Dylan K. Taylor
d3021c6281
populate missing array value types in utils namespace, pass 2
2020-01-30 21:39:15 +00:00
Dylan K. Taylor
9097d6c4d3
AutoUpdater: fixed type doc for updateInfo
2020-01-30 21:34:26 +00:00
Dylan K. Taylor
da43ae82fe
populate missing array value types in utils namespace, pass 1
2020-01-30 21:30:01 +00:00
Dylan K. Taylor
60b405d944
populate missing array value types in updater namespace
2020-01-30 21:23:05 +00:00
Dylan K. Taylor
92a752053d
populate missing array value types in tile namespace
2020-01-30 21:20:42 +00:00
Dylan K. Taylor
0537c66849
populate missing array value types in scheduler namespace
2020-01-30 21:19:15 +00:00
Dylan K. Taylor
d94995e161
populate missing array value types in plugin namespace
2020-01-30 21:17:13 +00:00
Dylan K. Taylor
58bc08838b
populate missing array value types in permission namespace
2020-01-30 21:14:18 +00:00
Dylan K. Taylor
fc0619ee6e
populate missing array value types in network namespace
2020-01-30 21:12:00 +00:00
Dylan K. Taylor
a5764b3ae9
populate missing array value types in level namespace
2020-01-30 21:01:59 +00:00
Dylan K. Taylor
8bf469f7fc
populate missing array value types in lang namespace
2020-01-30 20:55:03 +00:00
Dylan K. Taylor
3b9a5c5ccc
populate missing array value types in item namespace
2020-01-30 20:54:38 +00:00
Dylan K. Taylor
4c36ca58e2
populate missing array value types in inventory namespace
2020-01-30 20:53:41 +00:00
Dylan K. Taylor
a67fa5c007
populate missing array value types in event namespace
2020-01-30 20:52:54 +00:00
Dylan K. Taylor
839a789180
populate missing array value types in entity namespace
2020-01-30 20:50:24 +00:00
Dylan K. Taylor
e61c3e8bf6
populate missing array value types in command namespace
2020-01-30 20:48:14 +00:00
Dylan K. Taylor
7ce6c8aa13
TimingsCommand: fix confusing indentation
2020-01-30 20:47:33 +00:00
Dylan K. Taylor
9abcc99c10
Command: fixed spacing of phpdoc on execute()
2020-01-30 20:46:25 +00:00
Dylan K. Taylor
5c8a625d88
populate missing iterable value types in block namespace
2020-01-30 20:43:13 +00:00
Dylan K. Taylor
259f0425a9
ClientboundMapItemDataPacket: replace assoc array with MapDecoration class
...
I thought I'd done this already, but it appears not.
2020-01-30 20:05:18 +00:00
Dylan K. Taylor
9cdea43794
provide more array type information for Internet functions
2020-01-29 20:45:03 +00:00
Dylan K. Taylor
e007fad5b8
fix return types for Utils/Internet getURL()/postURL()
2020-01-29 20:43:09 +00:00
Dylan K. Taylor
5cf2fcbbb7
simpleCurl() second return value is string[][], not string[]
2020-01-29 20:38:19 +00:00
Dylan K. Taylor
9e6cbb5b6a
Internet: fix type information for getURL(), postURL() and simpleCurl()
2020-01-29 20:20:52 +00:00
Dylan K. Taylor
64b3d02974
Chunk: remove useless condition from populateSkyLight()
...
this was detected by latest bleeding-edge PHPStan.
2020-01-29 16:42:42 +00:00
Dylan K. Taylor
640df1003c
add some Generator generics for PHPStan
2020-01-29 16:38:50 +00:00
Dylan K. Taylor
2b402e525a
add some PHPStan-specific callable prototypes
2020-01-29 15:03:55 +00:00
