Dylan K. Taylor
124e60301a
updated submodule to pmmp/BedrockData@a38b427888
2019-12-06 11:26:58 +00:00
Dylan K. Taylor
4d13c48e5c
UPnP: COM constructor never returns false anymore
2019-12-05 16:07:06 +00:00
Dylan K. Taylor
9159e8f002
MainLogger: mark static logger field as nullable
2019-12-05 15:48:58 +00:00
Dylan K. Taylor
f5aa461945
GlobalConstants: assume we are on 64-bit when declaring INT32_MASK
...
fixes a FP reported by phpstan level 4
2019-12-05 15:48:11 +00:00
Dylan K. Taylor
16817ff301
Player: remove superfluous conditions for RESPAWN action handling
...
spawned is always true here because of the condition at the top of the function.
isOnline() is always true here because the handler won't even be called if it isn't.
2019-12-05 14:52:12 +00:00
Dylan K. Taylor
18863b1098
Player: remove superfluous check from processMovement()
...
if we reached this branch, revert is always false because it is not modified between this branch and the parent one.
detected by phpstan level 4
2019-12-05 14:47:15 +00:00
Dylan K. Taylor
ff5aedaf6b
master: green on phpstan level 3
2019-12-05 14:35:02 +00:00
Dylan K. Taylor
a5e8419d5b
Merge branch 'next-minor'
...
# Conflicts:
# phpstan.neon.dist
# resources/vanilla
# src/item/WritableBookBase.php
# src/pocketmine/metadata/MetadataStore.php
# src/world/Position.php
2019-12-05 14:11:59 +00:00
Dylan K. Taylor
e3cffca34b
StartGamePacket: fixed possible type violation on decoding block table
2019-12-05 11:05:34 +00:00
Dylan K. Taylor
d20d9fb689
Merge branch 'stable' into drew-1.13
2019-12-05 10:59:53 +00:00
Dylan K. Taylor
7d89f91fea
Leaves: fixed decay
...
detected by phpstan level 4
2019-12-04 23:21:01 +00:00
Dylan K. Taylor
48e2473696
Position: mark world field as nullable (equivalent to 39c607cbd5e134a47fa338628d54eea4e45d6bc3)
2019-12-04 22:58:55 +00:00
Dylan K. Taylor
59793d4b68
Player: mark networkSession field as nullable
...
while we do null this to break cycles, we also null it for other purposes, and it's null-checked in a few places.
2019-12-04 22:54:04 +00:00
Dylan K. Taylor
fb78ec1f62
AsyncTask: mark threadLocalStorage static field as nullable
2019-12-04 22:50:30 +00:00
Dylan K. Taylor
908aa20eff
EntityFactory: fixed type doc of knownEntities
2019-12-04 22:49:25 +00:00
Dylan K. Taylor
09961b5cd0
Merge branch 'stable' into next-minor
2019-12-04 22:16:04 +00:00
Dylan K. Taylor
7b1ae2a822
phpstan: green on level 3
2019-12-04 22:12:14 +00:00
Dylan K. Taylor
8ecf5e02b9
bad fix for WritableBook phpstan warning
...
master has this shit so much better
2019-12-04 22:00:19 +00:00
Dylan K. Taylor
39c607cbd5
Position: mark level field as nullable
...
allowing the level to be null is, to be honest, a big design flaw, but one that can't be fixed without BC breaks.
2019-12-04 21:31:35 +00:00
Dylan K. Taylor
d867ffc60d
MetadataStore: fix some doc comments
2019-12-04 21:14:09 +00:00
Dylan K. Taylor
0e3ce7ff39
Merge branch 'next-minor'
2019-12-04 19:59:57 +00:00
Dylan K. Taylor
71a472e0eb
Merge branch 'stable' into next-minor
2019-12-04 19:52:01 +00:00
Dylan K. Taylor
c57eb26fd5
phpstan-bugs: add some extra patterns for level 3 false positives
2019-12-04 19:50:15 +00:00
Dylan K. Taylor
c35d91a104
phpstan: allow blanket ignoreErrors in src to reduce merge work for master
2019-12-04 19:42:18 +00:00
Dylan K. Taylor
9fc260fb1a
keep phpstan.neon.dist ignoreErrors sorted by file
2019-12-04 19:38:54 +00:00
Dylan K. Taylor
b43bd5fb67
PluginCommand: separate CommandExecutor param
...
looking at the code now it's clear that this class combines two jobs into the same class.
closes #3203
2019-12-04 19:14:52 +00:00
Dylan K. Taylor
2ff25dfbd2
Color: make mix() first parameter mandatory, closes #3204
2019-12-04 18:39:14 +00:00
Dylan K. Taylor
60154d8127
SubChunkIteratorManager: assert type of subchunk to make PHPStan happy
...
we know this should be a SubChunk, even though it doesn't.
2019-12-04 18:26:18 +00:00
Dylan K. Taylor
e35a92d8e8
tile\Banner: fixed bad default value for patterns field
...
detected by PHPStan on level 3
2019-12-04 18:25:08 +00:00
Dylan K. Taylor
850dbb38c6
phpstan-bugs: remove false positive that is fixed in 0.12.0
2019-12-04 11:38:01 +00:00
Dylan K. Taylor
c0ea871599
updated rules for master on PHPStan 0.12
2019-12-04 11:35:57 +00:00
Dylan K. Taylor
117e46f639
LevelDB: fix doc comment handling for deserializeLegacyExtraData()
2019-12-04 11:29:41 +00:00
Dylan K. Taylor
66aa940ed1
Item: fixed foreach doc comment in deserializeCompoundTag()
...
detected by PHPStan 0.12.0
2019-12-04 11:28:59 +00:00
Dylan K. Taylor
dc5d985cf4
Merge branch 'next-minor'
2019-12-04 11:23:30 +00:00
Dylan K. Taylor
e65bc5c3ae
Merge branch 'stable' into next-minor
2019-12-04 11:11:29 +00:00
Dylan K. Taylor
73d0f799c2
Update to PHPStan 0.12.0
2019-12-04 10:29:49 +00:00
Dylan K. Taylor
ecb2e6e3af
PluginManager: remove useless information from softDepend debug
...
we don't report the parameter type anywhere else, and since PHP doesn't support overloading, we don't need to.
This fixes PHPStan 0.12 complaints about ReflectionNamedType. I figured this was the best solution instead of adding an extra few lines of code.
2019-12-04 10:17:25 +00:00
Dylan K. Taylor
7b75b6928d
AvailableCommandsPacket: fixed foreach docs
...
these probably aren't necessary at all to be honest.
2019-12-04 10:15:50 +00:00
Dylan K. Taylor
753a8a6937
Event: remove useless @var $this annotations
...
we are not in a trait here, the scope is always Event.
2019-12-04 10:15:04 +00:00
Dylan K. Taylor
bc76b1cafe
Server: remove several redundant @var annotations (copy pasta)
...
these are all useless because it is implied by the parameter type anyway.
2019-12-04 10:14:15 +00:00
Dylan K. Taylor
f302517a2d
Door: fix deserialization of top flag
...
it's not clear what bugs this caused, if any, but nonetheless it is incorrect.
2019-12-03 21:04:04 +00:00
Dylan K. Taylor
962e6162eb
Merge branch 'next-minor'
2019-12-03 20:00:08 +00:00
Dylan K. Taylor
2ae37cc1c5
Merge branch 'stable' into next-minor
2019-12-03 19:59:35 +00:00
Dylan K. Taylor
00e415fc79
move phpstan.neon to phpstan.neon.dist to allow phpstan.neon to be locally modified for development
2019-12-03 19:57:19 +00:00
Dylan K. Taylor
29ce829247
fix error counts for UPnP
2019-12-03 17:45:23 +00:00
Dylan K. Taylor
5b91be81cc
Entity: rewrite dbbe1f2d5c04059ee9ddad12a0d33fbaea933683 for master
2019-12-03 12:16:10 +00:00
Dylan K. Taylor
54c2778e56
phpstan: update split configs for master branch
2019-12-03 12:08:56 +00:00
Dylan K. Taylor
5f9ce78814
WorldProviderManager: removed incorrect param doc
...
this was used to trick phpstorm, but PHPStan doesn't like it, and it isn't consistently used anyway.
2019-12-03 12:08:04 +00:00
Dylan K. Taylor
fede6b8234
protocol: fixed static analysis warnings in MetadataProperty::equals() implementations
2019-12-03 12:06:57 +00:00
Dylan K. Taylor
e110ea5aea
LoginPacket: fixed param doc for validate()
2019-12-03 11:59:28 +00:00