Dylan K. Taylor
54cb5ee0fa
ItemTranslator: ensure that the correct meta value is returned after translation
...
-1 is a PM-specific thing. Right now there is a hack in the NetworkBinaryStream which prevents this from becoming a problem, but that might not be the case in future.
2021-04-07 13:10:29 +01:00
Jitendra Adhikari
cdae8b42eb
Bump adhocore/json-comment to ^1.1.0, new version strips trailing comma as well ( #4146 )
2021-04-06 11:58:23 +01:00
Ali
a45a4a91ae
Call InventoryCloseEvent in Player::removeWindow() ( #4142 )
...
closes #4130
2021-04-04 01:07:58 +01:00
Dylan K. Taylor
21378b7f27
Regenerate PHPStan baselines
...
this should be the last time we get baselines randomly rearranging themselves on changes ...
2021-04-03 22:36:15 +01:00
Dylan K. Taylor
502aed41b0
phpstan 0.12.83
2021-04-03 22:34:48 +01:00
Dylan K. Taylor
1898d4b42c
Fixed corner case with player spawning in ungenerated terrain
...
we can't get the safe spawn location of a set of coordinates if the coordinates are in an ungenerated chunk. This can happen if doing /setworldspawn <somewhere ungenerated> and then having a new player join the server.
2021-04-03 22:20:19 +01:00
Dylan K. Taylor
125837324f
Player: don't dump cursor contents on mouseover interaction
...
this can fire while the player has the inventory window open, because it also gets sent when the player swaps their held itemstack for something new.
We already had a special-case for mouseover with entity ID 0, but since
this isn't just a zero problem, a more general fix suits better
(particularly since we might need to handle the 0 case anyway).
closes #4140
closes #4141
2021-04-02 21:35:38 +01:00
Ali
609dff1aae
Player: Revert invalid attempts to toggle flight, instead of kicking ( #4139 )
...
If allowFlight was toggled by the server (e.g. due to gamemode change), a race could occur due to network latency where the client could try to enable flight, and then get kicked for cheating.
Since this can happen in legitimate, non-cheating cases, we can't make any assumptions about whether a player is cheating, so instead we just revert it, like we do with every other bad input.
2021-04-01 17:57:26 +01:00
Dylan K. Taylor
4eaa600f35
actions: clone submodules in PHPUnit job
2021-03-31 21:54:27 +01:00
Dylan K. Taylor
cd71fec53d
fucking phpstorm 2020.3 and its broken autocomplete
2021-03-31 21:41:50 +01:00
Dylan K. Taylor
5e8078f3dd
PacketSerializer: Improved performance of item serialize/deserialize
2021-03-31 21:39:55 +01:00
Dylan K. Taylor
b7a6c9dc17
Renamed BadPacketException -> PacketHandlingException
...
this better describes the intent, instead of just vaguely describing a packet as 'bad'.
2021-03-30 01:15:28 +01:00
Dylan K. Taylor
b03212053c
3.18.2 is next
2021-03-28 21:24:07 +01:00
Dylan K. Taylor
fd4ac885bb
Release 3.18.1
2021-03-28 21:24:03 +01:00
Dylan K. Taylor
f35886f18a
Updated composer dependencies
2021-03-28 21:14:02 +01:00
Dylan K. Taylor
25998720ce
Fixed server crash on invalid gamemode in SetPlayerGameTypePacket
...
this really ought to be detected at the decode layer, but right now that's a bit difficult ...
2021-03-28 21:11:07 +01:00
Dylan K. Taylor
7fe6815f7c
Merge branch 'stable'
2021-03-28 20:39:59 +01:00
Dylan K. Taylor
a9eaa55427
actions: added a php-cs-fixer run
2021-03-28 20:38:56 +01:00
Dylan K. Taylor
b032d49722
Merge branch 'stable'
2021-03-28 19:41:23 +01:00
Dylan K. Taylor
5c41f79be4
Added php-cs-fixer configuration
...
this is by no means a complete code style guide, but it fixes a lot of common issues that show up, particularly in PRs.
2021-03-28 19:21:41 +01:00
Dylan K. Taylor
34c2b62ffe
Remove unused import
2021-03-28 19:12:18 +01:00
Dylan K. Taylor
e42a691da9
Strip trailing whitespace
2021-03-28 19:02:51 +01:00
Ali
3b3fb5e662
fix ItemFrames ( #4101 )
...
removing items from item frames was broken due to behavioural changes in 1.16.210.
2021-03-28 18:53:46 +01:00
Dylan K. Taylor
01ffe8bf57
Updated build/php submodule to pmmp/php-build-scripts@c64baa0f1c
2021-03-28 18:14:40 +01:00
Dylan K. Taylor
7139eccfbe
Merge branch 'stable'
2021-03-28 18:11:53 +01:00
Dylan K. Taylor
4abf4aecad
MainLogger: fixed potential deadlock during syncFlushBuffer()
...
the notify() to flush the buffer might arrive in between the writeLogStream() and synchronized() calls in the thread body, resulting in a deadlock if the logger thread managed to call wait() before the main thread did.
2021-03-28 18:10:23 +01:00
Dylan K. Taylor
d5549b72de
...
2021-03-27 00:08:23 +00:00
Dylan K. Taylor
9137666952
Fixed build
2021-03-26 22:57:21 +00:00
Dylan K. Taylor
06f20234f7
Scrub unused imports
2021-03-26 22:56:09 +00:00
Dylan K. Taylor
adbc58f326
TickingChunkLoader: use native return types
2021-03-26 22:55:48 +00:00
Dylan K. Taylor
cdeedbad8b
Player: extract some entity spawning logic into a separate function
2021-03-26 22:51:56 +00:00
Dylan K. Taylor
de49a361c0
NetworkSession: Remove parameters from startUsingChunk() callback
...
these can easily be use()d into the closure (which also has slightly better performance, because no type checks - not that anyone will notice).
2021-03-26 22:45:36 +00:00
Dylan K. Taylor
49cf009017
Remove unused variable
2021-03-26 22:43:21 +00:00
Dylan K. Taylor
a223d1cbf3
NetworkSession: allow Player to handle its own business in chunk sending
...
these checks should appear consistently in all of these async callbacks.
2021-03-26 22:00:42 +00:00
Dylan T
f047ecfd2d
Fixed player spawning in ungenerated terrain ( #4087 )
...
fixes #4044
fixes #2724
this is significantly more complex than I hoped for, but it's a start... and it works.
2021-03-26 21:36:27 +00:00
Dylan K. Taylor
64886707b2
SubChunkExplorer: avoid repeated shift-right instructions
2021-03-25 23:36:10 +00:00
Dylan K. Taylor
5e9ce92b55
Explosion: don't depend on air having stateID 0
2021-03-25 23:17:33 +00:00
Dylan K. Taylor
52ce8ad8ae
Plugin: removed useless shit
...
Plugin is the interface by which the server core interacts with plugins, so it should be limited only to the stuff that the server actually uses.
These methods are still provided by PluginBase, so in 99.9% of cases there will be no BC break.
2021-03-25 19:17:16 +00:00
Dylan K. Taylor
d9b548bfde
Fixed unintentional formatting change introduced by ae75d73f4894fb792649e7a6af1a63376d162578
2021-03-25 01:37:26 +00:00
Dylan K. Taylor
9c10599c30
Updated PreProcessor to pmmp/PreProcessor@6e223fa9a0
2021-03-25 01:33:05 +00:00
Dylan K. Taylor
61bca7cfbc
master supports 7.4 only
2021-03-25 01:31:25 +00:00
Dylan K. Taylor
95eb70a924
Merge branch 'stable'
2021-03-25 01:30:52 +00:00
Dylan K. Taylor
b29f83ee99
Added preprocessor test build job to Actions
...
this should catch problems like the one that broke 3.17.6 at the root.
2021-03-25 01:25:04 +00:00
Dylan K. Taylor
4bc57f00b8
Updated LevelSoundEventPacket constants
2021-03-23 23:36:48 +00:00
Dylan K. Taylor
0d775f8731
Require ext-chunkutils2 at ^0.2.0
2021-03-23 22:23:17 +00:00
Dylan K. Taylor
aa8c13ec45
Remove dynamic LightArray constants
...
sad, no constexpr functions :(
2021-03-23 20:23:56 +00:00
Dylan K. Taylor
17dd574814
Fixed composer lockfile
2021-03-23 20:00:37 +00:00
Dylan K. Taylor
f2a320bb5c
Merge branch 'stable'
2021-03-23 19:57:54 +00:00
Dylan K. Taylor
ff61e1e018
ClientCacheBlobStatusPacket: fixed field order
...
miss comes first, not hit.
2021-03-23 19:52:25 +00:00
Dylan K. Taylor
9ee80357b0
phpstan baselines cleanup
2021-03-23 15:24:20 +00:00
