Dylan K. Taylor
01016d7e17
Merge branch 'stable'
2020-01-19 19:59:56 +00:00
Dylan K. Taylor
8252bea699
phpstan: enable MissingMethodReturnTypehintRule
...
this was a bitch of a job, but it's one step closer to bypassing level 6.
2020-01-19 19:43:52 +00:00
Dylan K. Taylor
f2f4715d97
Merge commit '30f2e7527818e3275ceb0ff26093c4f26a84c51c'
2020-01-13 19:17:54 +00:00
Dylan K. Taylor
0e1cea043a
added some phpstan-specific generic type annotations
2020-01-13 15:05:02 +00:00
Dylan K. Taylor
acaa34785f
Merge commit '2cfc25b4f8f084c155a871934a10cc9010b05f7d'
2020-01-13 11:02:01 +00:00
Dylan K. Taylor
30f2e75278
phpstan 0.12.5
2020-01-12 16:57:43 +00:00
Dylan K. Taylor
2cfc25b4f8
phpstan: enable checkGenericClassInNonGenericObjectType
2020-01-11 23:04:16 +00:00
Dylan K. Taylor
9c06c1a06f
Merge branch 'stable'
2020-01-11 22:36:57 +00:00
Dylan K. Taylor
3614d9a78d
phpstan: enable MissingMethodParameterTypehintRule
2020-01-11 21:54:42 +00:00
Dylan K. Taylor
96b91af66a
Merge branch 'stable'
2020-01-11 21:41:38 +00:00
Dylan K. Taylor
8794292788
remove &$var reference notations in phpdoc
...
this isn't required by the spec and PHPStan chokes on it. I was previously having it ignore these errors, but it turns out that PHPStan is not making use of extended typeinfo provided if it can't parse the tag, which is problematic on level 6 and also a problem for array-of-type. Therefore, we are going to have to take the hit.
2020-01-11 21:20:55 +00:00
Dylan K. Taylor
05a450df87
Merge branch 'stable'
2020-01-09 20:16:17 +00:00
Dylan K. Taylor
039478223e
phpstan: enable MissingFunctionReturnTypehintRule
2020-01-09 20:14:15 +00:00
Dylan K. Taylor
c85f4256c7
phpstan: enable MissingFunctionParameterTypehintRule
2020-01-09 20:10:15 +00:00
Dylan K. Taylor
715a5c55f4
Merge branch 'stable'
2020-01-09 20:02:22 +00:00
Dylan K. Taylor
6dcd2a4ece
phpstan: start phasing in some level 6 checks
2020-01-09 19:56:04 +00:00
Dylan K. Taylor
a733f094ac
phpstan: added a custom rule to disallow strict equality operators on enum members
...
comparing enums with equality operators is unreliable because there is no guarantee that the enum objects won't be somehow duplicated, through serialization, cloning or ext-parallel dumb object copying. This means that two equal enum objects may not be thw same object.
2020-01-08 19:45:05 +00:00
Dylan K. Taylor
9204b11948
phpstan: 0.12.3 fixes for master
2019-12-29 17:55:03 +00:00
Dylan K. Taylor
cccade9ade
Merge branch 'stable'
2019-12-29 15:31:10 +00:00
Dylan K. Taylor
3e23a568ca
phpstan: properly fixing FPs on constant comparisons
2019-12-29 14:25:44 +00:00
Dylan K. Taylor
2de0ec02ba
phpstan 0.12.3
2019-12-28 17:22:08 +00:00
Dylan K. Taylor
0f718ea28b
Merge commit '8726604899d1a371567141e0831ed570d3233356'
2019-12-25 14:19:35 +00:00
Dylan K. Taylor
494660102e
Replace empty() usages with count()
2019-12-18 11:23:24 +00:00
Dylan K. Taylor
1c6d3cd580
master: green on phpstan level 4
2019-12-12 15:25:15 +00:00
Dylan K. Taylor
a9c09e4517
Merge branch 'next-minor'
2019-12-12 13:52:14 +00:00
Dylan K. Taylor
70c3008b7b
phpstan: green on level 4
2019-12-12 13:00:57 +00:00
Dylan K. Taylor
6127a02a8b
phpstan 0.12.2
2019-12-12 10:43:45 +00:00
Dylan K. Taylor
ff5aedaf6b
master: green on phpstan level 3
2019-12-05 14:35:02 +00:00
Dylan K. Taylor
a5e8419d5b
Merge branch 'next-minor'
...
# Conflicts:
# phpstan.neon.dist
# resources/vanilla
# src/item/WritableBookBase.php
# src/pocketmine/metadata/MetadataStore.php
# src/world/Position.php
2019-12-05 14:11:59 +00:00
Dylan K. Taylor
7b1ae2a822
phpstan: green on level 3
2019-12-04 22:12:14 +00:00
Dylan K. Taylor
0e3ce7ff39
Merge branch 'next-minor'
2019-12-04 19:59:57 +00:00
Dylan K. Taylor
c57eb26fd5
phpstan-bugs: add some extra patterns for level 3 false positives
2019-12-04 19:50:15 +00:00
Dylan K. Taylor
c35d91a104
phpstan: allow blanket ignoreErrors in src to reduce merge work for master
2019-12-04 19:42:18 +00:00
Dylan K. Taylor
850dbb38c6
phpstan-bugs: remove false positive that is fixed in 0.12.0
2019-12-04 11:38:01 +00:00
Dylan K. Taylor
dc5d985cf4
Merge branch 'next-minor'
2019-12-04 11:23:30 +00:00
Dylan K. Taylor
73d0f799c2
Update to PHPStan 0.12.0
2019-12-04 10:29:49 +00:00
Dylan K. Taylor
29ce829247
fix error counts for UPnP
2019-12-03 17:45:23 +00:00
Dylan K. Taylor
54c2778e56
phpstan: update split configs for master branch
2019-12-03 12:08:56 +00:00
Dylan K. Taylor
d3d7709ead
Merge branch 'next-minor'
2019-12-03 11:55:45 +00:00
Dylan K. Taylor
15f8886958
phpstan: separate non-PM bugs from the main neon config
...
everything left in here is now a PM problem that needs to be looked into.
2019-12-01 20:12:41 +00:00
Dylan K. Taylor
932418b951
fixing some PHPStan complaints about bootstrap
...
this isn't an ideal fix, but it'll do.
2019-11-07 18:22:37 +00:00
