mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-05-15 18:29:46 +00:00
Code Issues Projects Releases Wiki Activity

World: remove temporalVector (premature cold path optimisation again)

Browse Source
This commit is contained in:
Dylan K. Taylor 2020-06-20 21:44:05 +01:00
parent 80e150c803
commit fc7672c6ba
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/world/World.php
View File

@ -227,8 +227,6 @@ class World implements ChunkManager{
/** @var Position */ /** @var Position */
private $temporalPosition; private $temporalPosition;
/** @var Vector3 */
private $temporalVector;
/** @var int */ /** @var int */
private $sleepTicks = 0; private $sleepTicks = 0;
@ -369,7 +367,6 @@ class World implements ChunkManager{
$this->timings = new WorldTimings($this); $this->timings = new WorldTimings($this);
$this->temporalPosition = new Position(0, 0, 0, $this); $this->temporalPosition = new Position(0, 0, 0, $this);
$this->temporalVector = new Vector3(0, 0, 0);
} }
public function getTickRateTime() : float{ public function getTickRateTime() : float{
@ -1407,7 +1404,7 @@ class World implements ChunkManager{
$orb = new ExperienceOrb(Location::fromObject($pos, $this, lcg_value() * 360, 0)); $orb = new ExperienceOrb(Location::fromObject($pos, $this, lcg_value() * 360, 0));
$orb->setXpValue($split); $orb->setXpValue($split);
$orb->setMotion($this->temporalVector->setComponents((lcg_value() * 0.2 - 0.1) * 2, lcg_value() * 0.4, (lcg_value() * 0.2 - 0.1) * 2)); $orb->setMotion(new Vector3((lcg_value() * 0.2 - 0.1) * 2, lcg_value() * 0.4, (lcg_value() * 0.2 - 0.1) * 2));
$orb->spawnToAll(); $orb->spawnToAll();
$orbs[] = $orb; $orbs[] = $orb;