mirrors/PocketMine-MP
1
0
Fork 0
mirror of https://github.com/pmmp/PocketMine-MP.git synced 2025-09-08 02:42:58 +00:00
Code Issues Projects Releases Wiki Activity

Add Shulker Boxes (#3678)

Browse Source 
this implementation is working, although incomplete:

- The shulker close sound should not be played until the end of the shulker closing animation, which takes approximately 1 second.
- An open shulker box has a different collision box than a closed one - it should be +0.5 in whichever direction the shulker is facing. (During the animation, the bounding box also dynamically changes size - you can see this in vanilla by shooting an arrow into the top of an open shulkerbox facing UP, and then closing it - the arrow will fall and collide with the lid multiple times.

However, resolving both of these issues requires significant internal changes which are beyond the scope of this PR.
This commit is contained in:
Aericio
2021-07-10 08:48:38 -10:00
committed by GitHub
parent 3997e612b1
commit fc090e238d
10 changed files with 393 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/block/VanillaBlocks.php
View File

@ -161,6 +161,7 @@ use function assert;
* @method static DoubleTallGrass DOUBLE_TALLGRASS()
* @method static DragonEgg DRAGON_EGG()
* @method static DriedKelp DRIED_KELP()
* @method static DyedShulkerBox DYED_SHULKER_BOX()
* @method static Element ELEMENT_ACTINIUM()
* @method static Element ELEMENT_ALUMINUM()
* @method static Element ELEMENT_AMERICIUM()
@ -484,6 +485,7 @@ use function assert;
* @method static Wall SANDSTONE_WALL()
* @method static SeaLantern SEA_LANTERN()
* @method static SeaPickle SEA_PICKLE()
* @method static ShulkerBox SHULKER_BOX()
* @method static Opaque SMOOTH_QUARTZ()
* @method static Slab SMOOTH_QUARTZ_SLAB()
* @method static Stair SMOOTH_QUARTZ_STAIRS()
@ -720,6 +722,7 @@ final class VanillaBlocks{
self::register("double_tallgrass", $factory->get(175, 2));
self::register("dragon_egg", $factory->get(122, 0));
self::register("dried_kelp", $factory->get(394, 0));
self::register("dyed_shulker_box", $factory->get(218, 0));
self::register("element_actinium", $factory->get(355, 0));
self::register("element_aluminum", $factory->get(279, 0));
self::register("element_americium", $factory->get(361, 0));
@ -1043,6 +1046,7 @@ final class VanillaBlocks{
self::register("sandstone_wall", $factory->get(139, 5));
self::register("sea_lantern", $factory->get(169, 0));
self::register("sea_pickle", $factory->get(411, 0));
self::register("shulker_box", $factory->get(205, 0));
self::register("smooth_quartz", $factory->get(155, 3));
self::register("smooth_quartz_slab", $factory->get(421, 1));
self::register("smooth_quartz_stairs", $factory->get(440, 0));